Apply suggestions from code review

Co-authored-by: Marcel Wagner <[email protected]>

Author: michael-hawker

UnitTests/UnitTests.UWP/UI/Controls/Test_ConstrainedBox.AspectRatio.cs

@@ -51,8 +51,8 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 200, "Width unexpected");
-                Assert.AreEqual(child.ActualHeight, 100, "Height unexpected");
+            Assert.AreEqual(200, child.ActualWidth, 1, "Actual width does not meet expected value of 200");
+            Assert.AreEqual(100, child.ActualHeight, 1, "Actual height does not meet expected value of 100");
             });
         }
 
@@ -88,9 +88,9 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 100, "Width unexpected");
-                Assert.AreEqual(child.ActualHeight, 200, "Height unexpected");
+            Assert.AreEqual(100, child.ActualWidth, 1, "Actual width does not meet expected value of 100");
+            Assert.AreEqual(200, child.ActualHeight, 1, "Actual height does not meet expected value of 200");
             });
         }
     }
-}
+}

UnitTests/UnitTests.UWP/UI/Controls/Test_ConstrainedBox.Multiple.cs

@@ -55,15 +55,15 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 192);
-                Assert.AreEqual(child.ActualHeight, 200);
+            Assert.AreEqual(192, child.ActualWidth, 1, "Actual width does not meet expected value of 192");
+            Assert.AreEqual(200, child.ActualHeight, 1, "Actual height does not meet expected value of 200");
 
                 // Check inner Positioning, we do this from the Grid as the ConstainedBox also modifies its own size
                 // and is hugging the child.
                 var position = grid.CoordinatesTo(child);
 
-                Assert.AreEqual(position.X, 4);
-                Assert.AreEqual(position.Y, 0);
+                Assert.AreEqual(4, position.X);
+                Assert.AreEqual(0, position.Y);
             });
         }
 
@@ -104,16 +104,16 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 200);
-                Assert.AreEqual(child.ActualHeight, 192);
+                Assert.AreEqual(200, child.ActualWidth, "Actual width does not meet expected value of 200");
+                Assert.AreEqual(192, child.ActualHeight, "Actual height does not meet expected value of 192");
 
                 // Check inner Positioning, we do this from the Grid as the ConstainedBox also modifies its own size
                 // and is hugging the child.
                 var position = grid.CoordinatesTo(child);
 
-                Assert.AreEqual(position.X, 0);
-                Assert.AreEqual(position.Y, 4);
+                Assert.AreEqual(0, position.X);
+                Assert.AreEqual(4, position.Y);
             });
         }
     }
-}
+}

UnitTests/UnitTests.UWP/UI/Controls/Test_ConstrainedBox.Scale.cs

@@ -55,15 +55,15 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 100);
-                Assert.AreEqual(child.ActualHeight, 200);
+            Assert.AreEqual(100, child.ActualWidth, 1, "Actual width does not meet expected value of 100");
+            Assert.AreEqual(200, child.ActualHeight, 1, "Actual height does not meet expected value of 200");
 
                 // Check inner Positioning, we do this from the Grid as the ConstainedBox also modifies its own size
                 // and is hugging the child.
                 var position = grid.CoordinatesTo(child);
 
-                Assert.AreEqual(position.X, 50);
-                Assert.AreEqual(position.Y, 0);
+                Assert.AreEqual(50, position.X);
+                Assert.AreEqual(0, position.Y);
             });
         }
 
@@ -104,16 +104,16 @@ await App.DispatcherQueue.EnqueueAsync(async () =>
                 Assert.IsNotNull(child, "Could not find inner Border");
 
                 // Check Size
-                Assert.AreEqual(child.ActualWidth, 200);
-                Assert.AreEqual(child.ActualHeight, 100);
+            Assert.AreEqual(200, child.ActualWidth, 1, "Actual width does not meet expected value of 200");
+            Assert.AreEqual(100, child.ActualHeight, 1, "Actual height does not meet expected value of 100");
 
                 // Check inner Positioning, we do this from the Grid as the ConstainedBox also modifies its own size
                 // and is hugging the child.
                 var position = grid.CoordinatesTo(child);
 
-                Assert.AreEqual(position.X, 0);
-                Assert.AreEqual(position.Y, 50);
+                Assert.AreEqual(0, position.X);
+                Assert.AreEqual(50, position.Y);
             });
         }
     }
-}
+}