Minor code refactoring

Author: Sergio0694

Microsoft.Toolkit.Mvvm.SourceGenerators/ComponentModel/TransitiveMembersGenerator.SyntaxReceiver.cs

@@ -21,12 +21,12 @@ private sealed class SyntaxReceiver : ISyntaxContextReceiver
             /// <summary>
             /// The list of info gathered during exploration.
             /// </summary>
-            private readonly List<(ClassDeclarationSyntax Class, AttributeSyntax Attribute, AttributeData Data)> gatheredInfo = new();
+            private readonly List<Item> gatheredInfo = new();
 
             /// <summary>
             /// Gets the collection of gathered info to process.
             /// </summary>
-            public IReadOnlyCollection<(ClassDeclarationSyntax Class, AttributeSyntax Attribute, AttributeData Data)> GatheredInfo => this.gatheredInfo;
+            public IReadOnlyCollection<Item> GatheredInfo => this.gatheredInfo;
 
             /// <inheritdoc/>
             public void OnVisitSyntaxNode(GeneratorSyntaxContext context)
@@ -38,9 +38,22 @@ public void OnVisitSyntaxNode(GeneratorSyntaxContext context)
                     attributeData.ApplicationSyntaxReference is SyntaxReference syntaxReference &&
                     syntaxReference.GetSyntax() is AttributeSyntax attributeSyntax)
                 {
-                    this.gatheredInfo.Add((classDeclaration, attributeSyntax, attributeData));
+                    this.gatheredInfo.Add(new Item(classDeclaration, classSymbol, attributeSyntax, attributeData));
                 }
             }
+
+            /// <summary>
+            /// A model for a group of item representing a discovered type to process.
+            /// </summary>
+            /// <param name="ClassDeclaration">The <see cref="ClassDeclarationSyntax"/> instance for the target class declaration.</param>
+            /// <param name="ClassSymbol">The <see cref="INamedTypeSymbol"/> instance for <paramref name="ClassDeclaration"/>.</param>
+            /// <param name="AttributeSyntax">The <see cref="AttributeSyntax"/> instance for the target attribute over <paramref name="ClassDeclaration"/>.</param>
+            /// <param name="AttributeData">The <see cref="AttributeData"/> instance for <paramref name="AttributeSyntax"/>.</param>
+            public sealed record Item(
+                ClassDeclarationSyntax ClassDeclaration,
+                INamedTypeSymbol ClassSymbol,
+                AttributeSyntax AttributeSyntax,
+                AttributeData AttributeData);
         }
     }
 }

Microsoft.Toolkit.Mvvm.SourceGenerators/ComponentModel/TransitiveMembersGenerator.cs

@@ -53,25 +53,22 @@ public void Execute(GeneratorExecutionContext context)
             // Load the syntax tree with the members to generate
             SyntaxTree sourceSyntaxTree = LoadSourceSyntaxTree();
 
-            foreach (var info in syntaxReceiver.GatheredInfo)
+            foreach (SyntaxReceiver.Item item in syntaxReceiver.GatheredInfo)
             {
-                SemanticModel semanticModel = context.Compilation.GetSemanticModel(info.Class.SyntaxTree);
-                INamedTypeSymbol classDeclarationSymbol = semanticModel.GetDeclaredSymbol(info.Class)!;
-
-                if (!ValidateTargetType(context, info.Data, info.Class, classDeclarationSymbol, out var descriptor))
+                if (!ValidateTargetType(context, item.AttributeData, item.ClassDeclaration, item.ClassSymbol, out var descriptor))
                 {
-                    context.ReportDiagnostic(descriptor, info.Attribute, classDeclarationSymbol);
+                    context.ReportDiagnostic(descriptor, item.AttributeSyntax, item.ClassSymbol);
 
                     continue;
                 }
 
                 try
                 {
-                    OnExecute(context, info.Data, info.Class, classDeclarationSymbol, sourceSyntaxTree);
+                    OnExecute(context, item.AttributeData, item.ClassDeclaration, item.ClassSymbol, sourceSyntaxTree);
                 }
                 catch
                 {
-                    context.ReportDiagnostic(TargetTypeErrorDescriptor, info.Attribute, classDeclarationSymbol);
+                    context.ReportDiagnostic(TargetTypeErrorDescriptor, item.AttributeSyntax, item.ClassSymbol);
                 }
             }
         }

Microsoft.Toolkit.Mvvm.SourceGenerators/System.Runtime.CompilerServices/IsExternalInit.cs

@@ -0,0 +1,17 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.ComponentModel;
+
+namespace System.Runtime.CompilerServices
+{
+    /// <summary>
+    /// Reserved to be used by the compiler for tracking metadata.
+    /// This class should not be used by developers in source code.
+    /// </summary>
+    [EditorBrowsable(EditorBrowsableState.Never)]
+    internal static class IsExternalInit
+    {
+    }
+}