PR updates

Author: shweaver-MSFT

Microsoft.Toolkit/Helpers/ObjectStorage/IObjectSerializer.cs

@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Diagnostics.CodeAnalysis;
-
 namespace Microsoft.Toolkit.Helpers
 {
     /// <summary>
@@ -17,7 +15,6 @@ public interface IObjectSerializer
         /// <typeparam name="T">The type of the object to serialize.</typeparam>
         /// <param name="value">The object to serialize.</param>
         /// <returns>The serialized object.</returns>
-        [return: NotNullIfNotNull("value")]
         string? Serialize<T>(T value);
 
         /// <summary>
@@ -26,7 +23,6 @@ public interface IObjectSerializer
         /// <typeparam name="T">The type of the deserialized object.</typeparam>
         /// <param name="value">The string to deserialize.</param>
         /// <returns>The deserialized object.</returns>
-        [return: NotNullIfNotNull("value")]
         T Deserialize<T>(string value);
     }
 }

Microsoft.Toolkit/Helpers/ObjectStorage/ISettingsStorageHelper.cs

@@ -19,7 +19,7 @@ public interface ISettingsStorageHelper<TKey>
         /// <typeparam name="TValue">Type of object retrieved.</typeparam>
         /// <param name="key">Key of the object.</param>
         /// <exception cref="KeyNotFoundException">Throws when the specified key is not found.</exception>
-        /// <returns>The TValue object</returns>
+        /// <returns>The <see typeparamref="TValue"/> object for <see typeparamref="TKey"/> key.</returns>
         TValue? Read<TValue>(TKey key);
 
         /// <summary>

Microsoft.Toolkit/Microsoft.Toolkit.csproj

@@ -21,11 +21,9 @@
     <DefineConstants>NETSTANDARD2_1_OR_GREATER</DefineConstants>
   </PropertyGroup>
 
-  <!-- .NET Standard 1.4 doesn't have the [Pure] attribute -->
+  <!-- .NET Standard 1.4 doesn't have the [Pure] attribute or ValueTuple -->
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.4'">
     <PackageReference Include="System.Diagnostics.Contracts" Version="4.3.0" />
-  </ItemGroup>
-  <ItemGroup>
     <PackageReference Include="System.ValueTuple" Version="4.5.0" />
   </ItemGroup>
 

UnitTests/UnitTests.UWP/Helpers/JsonObjectSerializer.cs

@@ -26,7 +26,7 @@ public T Deserialize<T>(string value)
                 return (T)Convert.ChangeType(value, type);
             }
 
-            return JsonConvert.DeserializeObject<T>((string)value);
+            return JsonConvert.DeserializeObject<T>(value);
         }
 
         public string Serialize<T>(T value)