Skip to content

Commit eb61e6d

Browse files
authored
Apply suggestions from code review
1 parent 55944ef commit eb61e6d

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"Name": "ColorPickerButton",
4949
"Type": "ColorPickerButtonPage",
5050
"Subcategory": "Input",
51-
"About": "A color picker within a flyout opened by pressing a drop down button containing the selected color.",
51+
"About": "A color picker within a flyout opened by pressing a dropdown button containing the selected color.",
5252
"CodeUrl": "https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/master/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker",
5353
"XamlCodeFile": "/SamplePages/ColorPicker/ColorPickerButtonXaml.bind",
5454
"Icon": "/SamplePages/ColorPicker/ColorPicker.png",

Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,7 +1378,7 @@ private void PreviewBorder_PointerPressed(object sender, Windows.UI.Xaml.Input.P
13781378

13791379
/// <summary>
13801380
/// Event handler for when a key is pressed within the Hex RGB value TextBox.
1381-
/// This is used to trigger re-evaluation of the color based on the TextBox value.
1381+
/// This is used to trigger a re-evaluation of the color based on the TextBox value.
13821382
/// </summary>
13831383
private void HexInputTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRoutedEventArgs e)
13841384
{
@@ -1402,7 +1402,7 @@ private void HexInputTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRou
14021402

14031403
/// <summary>
14041404
/// Event handler for when the Hex RGB value TextBox looses focus.
1405-
/// This is used to trigger re-evaluation of the color based on the TextBox value.
1405+
/// This is used to trigger a re-evaluation of the color based on the TextBox value.
14061406
/// </summary>
14071407
private void HexInputTextBox_LostFocus(object sender, RoutedEventArgs e)
14081408
{
@@ -1423,7 +1423,7 @@ private void HexInputTextBox_LostFocus(object sender, RoutedEventArgs e)
14231423

14241424
/// <summary>
14251425
/// Event handler for when a key is pressed within a color channel TextBox.
1426-
/// This is used to trigger re-evaluation of the color based on the TextBox value.
1426+
/// This is used to trigger a re-evaluation of the color based on the TextBox value.
14271427
/// </summary>
14281428
private void ChannelTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRoutedEventArgs e)
14291429
{
@@ -1436,8 +1436,8 @@ private void ChannelTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRout
14361436
}
14371437

14381438
/// <summary>
1439-
/// Event handler for when a color channel TextBox looses focus.
1440-
/// This is used to trigger re-evaluation of the color based on the TextBox value.
1439+
/// Event handler for when a color channel TextBox loses focus.
1440+
/// This is used to trigger a re-evaluation of the color based on the TextBox value.
14411441
/// </summary>
14421442
private void ChannelTextBox_LostFocus(object sender, RoutedEventArgs e)
14431443
{
@@ -1481,4 +1481,4 @@ private void ChannelSlider_ValueChanged(object sender, RangeBaseValueChangedEven
14811481
return;
14821482
}
14831483
}
1484-
}
1484+
}

Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@
414414
<!--
415415
The -1 and +1 accent preview originally had a drop shadow as well.
416416
However, due to Z-order issues with the checkered background,
417-
shadow and preview border, it would have required it's own
417+
shadow and preview border, it would have required its own
418418
checkered background. This was judged not worth the performance
419419
trade-off so shadows were removed.
420420
-->
@@ -1338,4 +1338,4 @@
13381338

13391339
</ControlTemplate>
13401340

1341-
</ResourceDictionary>
1341+
</ResourceDictionary>

Microsoft.Toolkit.Uwp.UI.Controls/SwitchPresenter/SwitchPresenter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ private void EvaluateCases()
152152
{
153153
if (xcase.IsDefault)
154154
{
155-
// If there are multiple default cases provided, this'll override and just grab the last one, the developer will have to fix this in their XAML. We call this out in the case comments.
155+
// If there are multiple default cases provided, this will override and just grab the last one, the developer will have to fix this in their XAML. We call this out in the case comments.
156156
xdefault = xcase;
157157
continue;
158158
}

0 commit comments

Comments
 (0)