Apply suggestions from code review

michael-hawker · Sergio0694 · web-flow · commit f583ee495dca · 2020-12-08T17:00:53.000-08:00
Co-authored-by: Sergio Pedri &lt;sergio0694@live.com&gt;
diff --git a/UITests/UITests.App/App.AppService.xaml.cs b/UITests/UITests.App/App.AppService.xaml.cs
@@ -53,7 +53,7 @@ private async void OnAppServiceRequestReceived(AppServiceConnection sender, AppS
                     ValueSet returnMessage = new ValueSet();
 
                     // We await the OpenPage method to ensure the navigation has finished.
-                    if (await WeakReferenceMessenger.Default.Send<RequestPageMessage>(new (pageName)))
+                    if (await WeakReferenceMessenger.Default.Send(new RequestPageMessage(pageName)))
                     {
                         returnMessage.Add("Status", "OK");
                     }
diff --git a/UITests/UITests.App/MainTestHost.xaml.cs b/UITests/UITests.App/MainTestHost.xaml.cs
@@ -30,7 +30,7 @@ public MainTestHost()
         {
             InitializeComponent();
 
-            WeakReferenceMessenger.Default.RegisterAll(this);
+            WeakReferenceMessenger.Default.Register<RequestPageMessage>(this);
 
             _queue = DispatcherQueue.GetForCurrentThread();
         }
diff --git a/UITests/UITests.App/RequestPageMessage.cs b/UITests/UITests.App/RequestPageMessage.cs
@@ -6,13 +6,13 @@
 
 namespace UITests.App
 {
-    public class RequestPageMessage : AsyncRequestMessage<bool>
+    public sealed class RequestPageMessage : AsyncRequestMessage<bool>
     {
-        public string PageName { get; private set; }
-
         public RequestPageMessage(string name)
         {
             PageName = name;
         }
+        
+        public string PageName { get; }
     }
 }
diff --git a/UITests/UITests.App/UITests.App.csproj b/UITests/UITests.App/UITests.App.csproj
@@ -10,7 +10,6 @@
     <RootNamespace>UITests.App</RootNamespace>
     <AssemblyName>UITests.App</AssemblyName>
     <DefaultLanguage>en-US</DefaultLanguage>
-    <LangVersion>9.0</LangVersion>
     <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
     <TargetPlatformVersion Condition=" '$(TargetPlatformVersion)' == '' ">10.0.19041.0</TargetPlatformVersion>
     <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
@@ -260,4 +259,4 @@
   </Target>
   -->
   <Import Project="..\UITests.Tests.Shared\UITests.Tests.Shared.projitems" Label="Shared" />
-</Project>
+</Project>

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ private async void OnAppServiceRequestReceived(AppServiceConnection sender, AppS`
`53`	`53`	`ValueSet returnMessage = new ValueSet();`
`54`	`54`
`55`	`55`	`// We await the OpenPage method to ensure the navigation has finished.`
`56`		`- if (await WeakReferenceMessenger.Default.Send<RequestPageMessage>(new (pageName)))`
	`56`	`+ if (await WeakReferenceMessenger.Default.Send(new RequestPageMessage(pageName)))`
`57`	`57`	`{`
`58`	`58`	`returnMessage.Add("Status", "OK");`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public MainTestHost()`
`30`	`30`	`{`
`31`	`31`	`InitializeComponent();`
`32`	`32`
`33`		`- WeakReferenceMessenger.Default.RegisterAll(this);`
	`33`	`+ WeakReferenceMessenger.Default.Register<RequestPageMessage>(this);`
`34`	`34`
`35`	`35`	`_queue = DispatcherQueue.GetForCurrentThread();`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,13 +6,13 @@`
`6`	`6`
`7`	`7`	`namespace UITests.App`
`8`	`8`	`{`
`9`		`- public class RequestPageMessage : AsyncRequestMessage<bool>`
	`9`	`+ public sealed class RequestPageMessage : AsyncRequestMessage<bool>`
`10`	`10`	`{`
`11`		`- public string PageName { get; private set; }`
`12`		`-`
`13`	`11`	`public RequestPageMessage(string name)`
`14`	`12`	`{`
`15`	`13`	`PageName = name;`
`16`	`14`	`}`
	`15`	`+`
	`16`	`+ public string PageName { get; }`
`17`	`17`	`}`
`18`	`18`	`}`