Merge branch 'master' into fix-local-release-build

Author: michael-hawker

Microsoft.Toolkit.HighPerformance/Extensions/NullableExtensions.cs

@@ -0,0 +1,55 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+// This extension is restricted to the .NET 5 because it shares the same BCL
+// across all targets, ensuring that the layout of our Nullable<T> mapping type
+// will be correct. Exposing this API on older targets (especially .NET Standard)
+// is not guaranteed to be correct and could result in invalid memory accesses.
+#if NET5_0
+
+using System;
+using System.Runtime.CompilerServices;
+
+namespace Microsoft.Toolkit.HighPerformance.Extensions
+{
+    /// <summary>
+    /// Helpers for working with the <see cref="Nullable{T}"/> type.
+    /// </summary>
+    public static class NullableExtensions
+    {
+        /// <summary>
+        /// Returns a reference to the value of the input <see cref="Nullable{T}"/> instance, regardless of whether
+        /// the <see cref="Nullable{T}.HasValue"/> property is returning <see langword="true"/> or not. If that is not
+        /// the case, this method will still return a reference to the underlying <see langword="default"/> value.
+        /// </summary>
+        /// <typeparam name="T">The type of the underlying value</typeparam>
+        /// <param name="value">The <see cref="Nullable{T}"/></param>
+        /// <returns>A reference to the underlying value from the input <see cref="Nullable{T}"/> instance.</returns>
+        /// <remarks>
+        /// Note that attempting to mutate the returned reference will not change the value returned by <see cref="Nullable{T}.HasValue"/>.
+        /// That means that reassigning the value of an empty instance will not make <see cref="Nullable{T}.HasValue"/> return <see langword="true"/>.
+        /// </remarks>
+        public static ref T DangerousGetValueOrDefaultReference<T>(this ref T? value)
+            where T : struct
+        {
+            return ref Unsafe.As<T?, RawNullableData<T>>(ref value).Value;
+        }
+
+        /// <summary>
+        /// Mapping type that reflects the internal layout of the <see cref="Nullable{T}"/> type.
+        /// See https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Nullable.cs.
+        /// </summary>
+        /// <typeparam name="T">The value type wrapped by the current instance.</typeparam>
+        private struct RawNullableData<T>
+            where T : struct
+        {
+#pragma warning disable CS0649 // Unassigned fields
+            public bool HasValue;
+            public T Value;
+#pragma warning restore CS0649
+        }
+    }
+}
+
+#endif

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/InAppNotification/InAppNotificationPage.xaml.cs

@@ -14,8 +14,6 @@ namespace Microsoft.Toolkit.Uwp.SampleApp.SamplePages
 {
     public sealed partial class InAppNotificationPage : Page, IXamlRenderListener
     {
-        private ControlTemplate _defaultInAppNotificationControlTemplate;
-        private ControlTemplate _customInAppNotificationControlTemplate;
         private InAppNotification _exampleInAppNotification;
         private InAppNotification _exampleCustomInAppNotification;
         private InAppNotification _exampleVSCodeInAppNotification;
@@ -36,9 +34,7 @@ public void OnXamlRendered(FrameworkElement control)
             NotificationDuration = 0;
 
             _exampleInAppNotification = control.FindChild("ExampleInAppNotification") as InAppNotification;
-            _defaultInAppNotificationControlTemplate = _exampleInAppNotification?.Template;
             _exampleCustomInAppNotification = control.FindChild("ExampleCustomInAppNotification") as InAppNotification;
-            _customInAppNotificationControlTemplate = _exampleCustomInAppNotification?.Template;
             _exampleVSCodeInAppNotification = control.FindChild("ExampleVSCodeInAppNotification") as InAppNotification;
             _resources = control.Resources;
 
@@ -53,24 +49,24 @@ private void Load()
         {
             SampleController.Current.RegisterNewCommand("Show notification with random text", (sender, args) =>
             {
-                _exampleVSCodeInAppNotification?.Dismiss();
-                SetDefaultControlTemplate();
+                _exampleVSCodeInAppNotification.Dismiss(true);
+                _exampleCustomInAppNotification.Dismiss(true);
                 _exampleInAppNotification?.Show(GetRandomText(), NotificationDuration);
             });
 
             SampleController.Current.RegisterNewCommand("Show notification with object", (sender, args) =>
             {
-                _exampleVSCodeInAppNotification?.Dismiss();
-                SetDefaultControlTemplate();
+                _exampleVSCodeInAppNotification.Dismiss(true);
+                _exampleCustomInAppNotification.Dismiss(true);
 
                 var random = new Random();
                 _exampleInAppNotification?.Show(new KeyValuePair<int, string>(random.Next(1, 10), GetRandomText()), NotificationDuration);
             });
 
             SampleController.Current.RegisterNewCommand("Show notification with buttons (without DataTemplate)", (sender, args) =>
             {
-                _exampleVSCodeInAppNotification?.Dismiss();
-                SetDefaultControlTemplate();
+                _exampleVSCodeInAppNotification.Dismiss(true);
+                _exampleCustomInAppNotification.Dismiss(true);
 
                 var grid = new Grid()
                 {
@@ -126,46 +122,30 @@ private void Load()
 
             SampleController.Current.RegisterNewCommand("Show notification with buttons (with DataTemplate)", (sender, args) =>
             {
-                _exampleVSCodeInAppNotification?.Dismiss();
-                SetCustomControlTemplate(); // Use the custom template without the Dismiss button. The DataTemplate will handle re-adding it.
+                _exampleVSCodeInAppNotification.Dismiss(true);
+                _exampleInAppNotification.Dismiss(true);
 
-                object inAppNotificationWithButtonsTemplate = null;
-                bool? isTemplatePresent = _resources?.TryGetValue("InAppNotificationWithButtonsTemplate", out inAppNotificationWithButtonsTemplate);
-
-                if (isTemplatePresent == true && inAppNotificationWithButtonsTemplate is DataTemplate template)
+                object inAppNotificationWithButtonsTemplateResource = null;
+                bool? isTemplatePresent = _resources?.TryGetValue("InAppNotificationWithButtonsTemplate", out inAppNotificationWithButtonsTemplateResource);
+                if (isTemplatePresent == true && inAppNotificationWithButtonsTemplateResource is DataTemplate inAppNotificationWithButtonsTemplate)
                 {
-                    _exampleInAppNotification.Show(template, NotificationDuration);
+                    _exampleCustomInAppNotification.Show(inAppNotificationWithButtonsTemplate, NotificationDuration);
                 }
             });
 
-            SampleController.Current.RegisterNewCommand("Show notification with Drop Shadow (based on default template)", (sender, args) =>
-            {
-                _exampleVSCodeInAppNotification.Dismiss();
-                SetDefaultControlTemplate();
-
-                // Update control template
-                object inAppNotificationDropShadowControlTemplate = null;
-                bool? isTemplatePresent = _resources?.TryGetValue("InAppNotificationDropShadowControlTemplate", out inAppNotificationDropShadowControlTemplate);
-
-                if (isTemplatePresent == true && inAppNotificationDropShadowControlTemplate is ControlTemplate template)
-                {
-                    _exampleInAppNotification.Template = template;
-                }
-
-                _exampleInAppNotification.Show(GetRandomText(), NotificationDuration);
-            });
-
             SampleController.Current.RegisterNewCommand("Show notification with Visual Studio Code template (info notification)", (sender, args) =>
             {
-                _exampleInAppNotification.Dismiss();
+                _exampleInAppNotification.Dismiss(true);
+                _exampleCustomInAppNotification.Dismiss(true);
                 _exampleVSCodeInAppNotification.Show(NotificationDuration);
             });
 
             SampleController.Current.RegisterNewCommand("Dismiss", (sender, args) =>
             {
                 // Dismiss all notifications (should not be replicated in production)
-                _exampleInAppNotification.Dismiss();
-                _exampleVSCodeInAppNotification.Dismiss();
+                _exampleInAppNotification.Dismiss(true);
+                _exampleCustomInAppNotification.Dismiss(true);
+                _exampleVSCodeInAppNotification.Dismiss(true);
             });
         }
 
@@ -182,18 +162,6 @@ private string GetRandomText()
             }
         }
 
-        private void SetDefaultControlTemplate()
-        {
-            // Update control template
-            _exampleInAppNotification.Template = _defaultInAppNotificationControlTemplate;
-        }
-
-        private void SetCustomControlTemplate()
-        {
-            // Update control template
-            _exampleInAppNotification.Template = _customInAppNotificationControlTemplate;
-        }
-
         private void NotificationDurationTextBox_TextChanged(object sender, TextChangedEventArgs e)
         {
             int newDuration;