Renamed Task.ResultOrDefault extensions

Author: Sergio0694

Microsoft.Toolkit.Uwp.UI/Converters/TaskResultConverter.cs

@@ -24,7 +24,7 @@ public object Convert(object value, Type targetType, object parameter, string la
         {
             if (value is Task task)
             {
-                return task.ResultOrDefault();
+                return task.GetResultOrDefault();
             }
 
             return null;

Microsoft.Toolkit/Extensions/TaskExtensions.cs

@@ -30,7 +30,7 @@ public static class TaskExtensions
         /// </remarks>
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static object? ResultOrDefault(this Task task)
+        public static object? GetResultOrDefault(this Task task)
         {
             // Check if the instance is a completed Task
             if (
@@ -78,7 +78,7 @@ public static class TaskExtensions
         [Pure]
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         [return: MaybeNull]
-        public static T ResultOrDefault<T>(this Task<T> task)
+        public static T GetResultOrDefault<T>(this Task<T> task)
         {
 #if NETSTANDARD2_1
             return task.IsCompletedSuccessfully ? task.Result : default;

UnitTests/UnitTests.Shared/Extensions/Test_TaskExtensions.cs

@@ -18,23 +18,23 @@ public void Test_TaskExtensions_ResultOrDefault()
         {
             TaskCompletionSource<int> tcs = new TaskCompletionSource<int>();
 
-            Assert.AreEqual(null, ((Task)tcs.Task).ResultOrDefault());
+            Assert.AreEqual(null, ((Task)tcs.Task).GetResultOrDefault());
 
             tcs.SetCanceled();
 
-            Assert.AreEqual(null, ((Task)tcs.Task).ResultOrDefault());
+            Assert.AreEqual(null, ((Task)tcs.Task).GetResultOrDefault());
 
             tcs = new TaskCompletionSource<int>();
 
             tcs.SetException(new InvalidOperationException("Test"));
 
-            Assert.AreEqual(null, ((Task)tcs.Task).ResultOrDefault());
+            Assert.AreEqual(null, ((Task)tcs.Task).GetResultOrDefault());
 
             tcs = new TaskCompletionSource<int>();
 
             tcs.SetResult(42);
 
-            Assert.AreEqual(42, ((Task)tcs.Task).ResultOrDefault());
+            Assert.AreEqual(42, ((Task)tcs.Task).GetResultOrDefault());
         }
 
         [TestCategory("TaskExtensions")]
@@ -43,23 +43,23 @@ public void Test_TaskExtensions_ResultOrDefault_OfT_Int32()
         {
             TaskCompletionSource<int> tcs = new TaskCompletionSource<int>();
 
-            Assert.AreEqual(0, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(0, tcs.Task.GetResultOrDefault());
 
             tcs.SetCanceled();
 
-            Assert.AreEqual(0, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(0, tcs.Task.GetResultOrDefault());
 
             tcs = new TaskCompletionSource<int>();
 
             tcs.SetException(new InvalidOperationException("Test"));
 
-            Assert.AreEqual(0, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(0, tcs.Task.GetResultOrDefault());
 
             tcs = new TaskCompletionSource<int>();
 
             tcs.SetResult(42);
 
-            Assert.AreEqual(42, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(42, tcs.Task.GetResultOrDefault());
         }
 
         [TestCategory("TaskExtensions")]
@@ -68,23 +68,23 @@ public void Test_TaskExtensions_ResultOrDefault_OfT_String()
         {
             TaskCompletionSource<string> tcs = new TaskCompletionSource<string>();
 
-            Assert.AreEqual(null, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(null, tcs.Task.GetResultOrDefault());
 
             tcs.SetCanceled();
 
-            Assert.AreEqual(null, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(null, tcs.Task.GetResultOrDefault());
 
             tcs = new TaskCompletionSource<string>();
 
             tcs.SetException(new InvalidOperationException("Test"));
 
-            Assert.AreEqual(null, tcs.Task.ResultOrDefault());
+            Assert.AreEqual(null, tcs.Task.GetResultOrDefault());
 
             tcs = new TaskCompletionSource<string>();
 
             tcs.SetResult("Hello world");
 
-            Assert.AreEqual("Hello world", tcs.Task.ResultOrDefault());
+            Assert.AreEqual("Hello world", tcs.Task.GetResultOrDefault());
         }
     }
 }