Remove unnecessary constructor

Author: Sergio0694

CommunityToolkit.Mvvm/Collections/ReadOnlyObservableGroupedCollection{TKey,TValue}.cs

@@ -38,15 +38,6 @@ public ReadOnlyObservableGroupedCollection(IEnumerable<ReadOnlyObservableGroup<T
     {
     }
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="ReadOnlyObservableGroupedCollection{TKey, TValue}"/> class.
-    /// </summary>
-    /// <param name="collection">The initial data to add in the grouped collection.</param>
-    public ReadOnlyObservableGroupedCollection(IEnumerable<IGrouping<TKey, TValue>> collection)
-        : this(collection.Select(static g => new ReadOnlyObservableGroup<TKey, TValue>(g.Key, g)))
-    {
-    }
-
     private void OnSourceCollectionChanged(object? sender, NotifyCollectionChangedEventArgs e)
     {
         // Even if NotifyCollectionChangedEventArgs allows multiple items, the actual implementation

CommunityToolkit.Mvvm/Collections/ReadOnlyObservableGroup{TKey,TValue}.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
 
@@ -37,17 +36,6 @@ public ReadOnlyObservableGroup(ObservableGroup<TKey, TValue> group)
         Key = group.Key;
     }
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="ReadOnlyObservableGroup{TKey, TValue}"/> class.
-    /// </summary>
-    /// <param name="key">The key of the group.</param>
-    /// <param name="collection">The collection of items to add in the group.</param>
-    public ReadOnlyObservableGroup(TKey key, IEnumerable<TValue> collection)
-        : base(new ObservableCollection<TValue>(collection))
-    {
-        Key = key;
-    }
-
     /// <inheritdoc/>
     public TKey Key { get; }
 

tests/CommunityToolkit.Mvvm.UnitTests/Collections/ReadOnlyObservableGroupTests.cs

@@ -38,7 +38,7 @@ public void Ctor_ObservableGroup_ShouldHaveExpectedInitialState()
     [TestMethod]
     public void Ctor_WithKeyAndCollection_ShouldHaveExpectedInitialState()
     {
-        int[]? source = new[] { 1, 2, 3 };
+        ObservableCollection<int> source = new() { 1, 2, 3 };
         ReadOnlyObservableGroup<string, int>? group = new("key", source);
 
         Assert.AreEqual(group.Key, "key");

tests/CommunityToolkit.Mvvm.UnitTests/Collections/ReadOnlyObservableGroupedCollectionTests.cs

@@ -47,32 +47,13 @@ public void Ctor_WithObservableGroupedCollection_ShoudInitializeObject()
         CollectionAssert.AreEquivalent(readOnlyGroup.ElementAt(1), new[] { 2, 4, 6 });
     }
 
-    [TestMethod]
-    public void Ctor_WithListOfIGroupingSource_ShoudInitializeObject()
-    {
-        List<IGrouping<string, int>>? source = new()
-        {
-            new IntGroup("A", new[] { 1, 3, 5 }),
-            new IntGroup("B", new[] { 2, 4, 6 }),
-        };
-        ReadOnlyObservableGroupedCollection<string, int>? readOnlyGroup = new(source);
-
-        Assert.AreEqual(readOnlyGroup.Count, 2);
-
-        Assert.AreEqual(readOnlyGroup.ElementAt(0).Key, "A");
-        CollectionAssert.AreEquivalent(readOnlyGroup.ElementAt(0), new[] { 1, 3, 5 });
-
-        Assert.AreEqual(readOnlyGroup.ElementAt(1).Key, "B");
-        CollectionAssert.AreEquivalent(readOnlyGroup.ElementAt(1), new[] { 2, 4, 6 });
-    }
-
     [TestMethod]
     public void Ctor_WithListOfReadOnlyObservableGroupSource_ShoudInitializeObject()
     {
-        List<ReadOnlyObservableGroup<string, int>>? source = new()
+        ObservableCollection<ReadOnlyObservableGroup<string, int>>? source = new()
         {
-            new ReadOnlyObservableGroup<string, int>("A", new[] { 1, 3, 5 }),
-            new ReadOnlyObservableGroup<string, int>("B", new[] { 2, 4, 6 }),
+            new ReadOnlyObservableGroup<string, int>("A", new ObservableCollection<int> { 1, 3, 5 }),
+            new ReadOnlyObservableGroup<string, int>("B", new ObservableCollection<int> { 2, 4, 6 }),
         };
         ReadOnlyObservableGroupedCollection<string, int>? readOnlyGroup = new(source);