Merge pull request #69 from CommunityToolkit/dev/remove-pure-attributes

Remove [Pure] attribute usages

Author: Sergio0694

CommunityToolkit.Common/Collections/ObservableGroupedCollectionExtensions.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.Contracts;
 using System.Linq;
 using System.Runtime.CompilerServices;
 
@@ -24,7 +23,6 @@ public static class ObservableGroupedCollectionExtensions
     /// <param name="key">The key of the group to query.</param>
     /// <returns>The first group matching <paramref name="key"/>.</returns>
     /// <exception cref="InvalidOperationException">The target group does not exist.</exception>
-    [Pure]
     public static ObservableGroup<TKey, TValue> First<TKey, TValue>(this ObservableGroupedCollection<TKey, TValue> source, TKey key)
         where TKey : notnull
     {
@@ -51,7 +49,6 @@ static void ThrowArgumentExceptionForKeyNotFound()
     /// <param name="source">The source <see cref="ObservableGroupedCollection{TKey, TValue}"/> instance.</param>
     /// <param name="key">The key of the group to query.</param>
     /// <returns>The first group matching <paramref name="key"/> or null.</returns>
-    [Pure]
     public static ObservableGroup<TKey, TValue>? FirstOrDefault<TKey, TValue>(this ObservableGroupedCollection<TKey, TValue> source, TKey key)
         where TKey : notnull
     {
@@ -89,7 +86,6 @@ static void ThrowArgumentExceptionForKeyNotFound()
     /// <returns>The element.</returns>
     /// <exception cref="InvalidOperationException">The target group does not exist.</exception>
     /// <exception cref="ArgumentOutOfRangeException"><paramref name="index"/> is less than zero or <paramref name="index"/> is greater than the group elements' count.</exception>
-    [Pure]
     public static TValue ElementAt<TKey, TValue>(
         this ObservableGroupedCollection<TKey, TValue> source,
         TKey key,
@@ -106,7 +102,6 @@ public static TValue ElementAt<TKey, TValue>(
     /// <param name="key">The key of the group to query.</param>
     /// <param name="index">The index of the item from the targeted group.</param>
     /// <returns>The element or default(TValue) if it does not exist.</returns>
-    [Pure]
     public static TValue? ElementAtOrDefault<TKey, TValue>(
         this ObservableGroupedCollection<TKey, TValue> source,
         TKey key,

CommunityToolkit.Common/Extensions/TaskExtensions.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Diagnostics.Contracts;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
@@ -24,7 +23,6 @@ public static class TaskExtensions
     /// and uses reflection to access the <see cref="Task{TResult}.Result"/> property and boxes the result if it's
     /// a value type, which adds overhead. It should only be used when using generics is not possible.
     /// </remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static object? GetResultOrDefault(this Task task)
     {
@@ -66,7 +64,6 @@ public static class TaskExtensions
     /// <param name="task">The input <see cref="Task{TResult}"/> instance to get the result for.</param>
     /// <returns>The result of <paramref name="task"/> if completed successfully, or <see langword="default"/> otherwise.</returns>
     /// <remarks>This method does not block if <paramref name="task"/> has not completed yet.</remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static T? GetResultOrDefault<T>(this Task<T?> task)
     {

CommunityToolkit.Diagnostics/Extensions/TypeExtensions.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.Contracts;
 using System.Linq;
 using System.Runtime.CompilerServices;
 
@@ -48,7 +47,6 @@ public static class TypeExtensions
     /// </summary>
     /// <param name="type">The input type.</param>
     /// <returns>The string representation of <paramref name="type"/>.</returns>
-    [Pure]
     public static string ToTypeString(this Type type)
     {
         // Local function to create the formatted string for a given type

CommunityToolkit.Diagnostics/Extensions/ValueTypeExtensions.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
@@ -42,7 +41,6 @@ public static class ValueTypeExtensions
     /// Console.WriteLine((-1).ToHexString()); // "0xFFFFFFFF"
     /// </code>
     /// </remarks>
-    [Pure]
     [SkipLocalsInit]
     public static unsafe string ToHexString<T>(this T value)
         where T : unmanaged

CommunityToolkit.Diagnostics/Guard.Comparable.Generic.cs

@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 
 namespace CommunityToolkit.Diagnostics;
@@ -191,7 +190,6 @@ public static unsafe void IsBitwiseEqualTo<T>(T value, T target, [CallerArgument
     }
 
     // Compares 64 bits of data from two given memory locations for bitwise equality
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private static unsafe bool Bit64Compare(ref ulong left, ref ulong right)
     {

CommunityToolkit.Diagnostics/Internals/Guard.ThrowHelper.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Diagnostics.CodeAnalysis;
-using System.Diagnostics.Contracts;
 
 namespace CommunityToolkit.Diagnostics;
 
@@ -23,7 +22,6 @@ private static partial class ThrowHelper
         /// </summary>
         /// <param name="obj">The input <see cref="object"/> to format.</param>
         /// <returns>A formatted representation of <paramref name="obj"/> to display in error messages.</returns>
-        [Pure]
         private static string AssertString(object? obj)
         {
             return obj switch

CommunityToolkit.HighPerformance/Box{T}.cs

@@ -5,7 +5,6 @@
 using System;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 
 namespace CommunityToolkit.HighPerformance;
@@ -69,7 +68,6 @@ private Box()
     /// </summary>
     /// <param name="obj">The input <see cref="object"/> instance, representing a boxed <typeparamref name="T"/> value.</param>
     /// <returns>A <see cref="Box{T}"/> reference pointing to <paramref name="obj"/>.</returns>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Box<T> GetFrom(object obj)
     {
@@ -90,7 +88,6 @@ public static Box<T> GetFrom(object obj)
     /// This method doesn't check the actual type of <paramref name="obj"/>, so it is responsibility of the caller
     /// to ensure it actually represents a boxed <typeparamref name="T"/> value and not some other instance.
     /// </remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static Box<T> DangerousGetFrom(object obj)
     {
@@ -197,7 +194,6 @@ public static class BoxExtensions
     /// <typeparam name="T">The type of reference to retrieve.</typeparam>
     /// <param name="box">The input <see cref="Box{T}"/> instance.</param>
     /// <returns>A <typeparamref name="T"/> reference to the boxed value within <paramref name="box"/>.</returns>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static ref T GetReference<T>(this Box<T> box)
         where T : struct

CommunityToolkit.HighPerformance/Buffers/ArrayPoolBufferWriter{T}.cs

@@ -5,7 +5,6 @@
 using System;
 using System.Buffers;
 using System.Diagnostics;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using CommunityToolkit.HighPerformance.Buffers.Views;
@@ -320,7 +319,6 @@ public void Dispose()
     }
 
     /// <inheritdoc/>
-    [Pure]
     public override string ToString()
     {
         // See comments in MemoryOwner<T> about this

CommunityToolkit.HighPerformance/Buffers/MemoryBufferWriter{T}.cs

@@ -5,7 +5,6 @@
 using System;
 using System.Buffers;
 using System.Diagnostics;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 using CommunityToolkit.HighPerformance.Buffers.Views;
 
@@ -144,7 +143,6 @@ private void ValidateSizeHint(int sizeHint)
     }
 
     /// <inheritdoc/>
-    [Pure]
     public override string ToString()
     {
         // See comments in MemoryOwner<T> about this

CommunityToolkit.HighPerformance/Buffers/MemoryOwner{T}.cs

@@ -5,7 +5,6 @@
 using System;
 using System.Buffers;
 using System.Diagnostics;
-using System.Diagnostics.Contracts;
 using System.Runtime.CompilerServices;
 #if NETCOREAPP3_1_OR_GREATER
 using System.Runtime.InteropServices;
@@ -86,7 +85,6 @@ private MemoryOwner(int start, int length, ArrayPool<T> pool, T[] array)
     /// <summary>
     /// Gets an empty <see cref="MemoryOwner{T}"/> instance.
     /// </summary>
-    [Pure]
     public static MemoryOwner<T> Empty
     {
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
@@ -100,7 +98,6 @@ public static MemoryOwner<T> Empty
     /// <returns>A <see cref="MemoryOwner{T}"/> instance of the requested length.</returns>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="size"/> is not valid.</exception>
     /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static MemoryOwner<T> Allocate(int size) => new(size, ArrayPool<T>.Shared, AllocationMode.Default);
 
@@ -112,7 +109,6 @@ public static MemoryOwner<T> Empty
     /// <returns>A <see cref="MemoryOwner{T}"/> instance of the requested length.</returns>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="size"/> is not valid.</exception>
     /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool) => new(size, pool, AllocationMode.Default);
 
@@ -124,7 +120,6 @@ public static MemoryOwner<T> Empty
     /// <returns>A <see cref="MemoryOwner{T}"/> instance of the requested length.</returns>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="size"/> is not valid.</exception>
     /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static MemoryOwner<T> Allocate(int size, AllocationMode mode) => new(size, ArrayPool<T>.Shared, mode);
 
@@ -137,7 +132,6 @@ public static MemoryOwner<T> Empty
     /// <returns>A <see cref="MemoryOwner{T}"/> instance of the requested length.</returns>
     /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="size"/> is not valid.</exception>
     /// <remarks>This method is just a proxy for the <see langword="private"/> constructor, for clarity.</remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static MemoryOwner<T> Allocate(int size, ArrayPool<T> pool, AllocationMode mode) => new(size, pool, mode);
 
@@ -211,7 +205,6 @@ public Span<T> Span
     /// the buffer itself has been disposed or not. This check should not be removed, and it's also
     /// the reason why the method to get a reference at a specified offset is not present.
     /// </remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public ref T DangerousGetReference()
     {
@@ -236,7 +229,6 @@ public ref T DangerousGetReference()
     /// not used after the current <see cref="MemoryOwner{T}"/> instance is disposed. Doing so is considered undefined behavior,
     /// as the same array might be in use within another <see cref="MemoryOwner{T}"/> instance.
     /// </remarks>
-    [Pure]
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public ArraySegment<T> DangerousGetArray()
     {
@@ -311,7 +303,6 @@ public void Dispose()
     }
 
     /// <inheritdoc/>
-    [Pure]
     public override string ToString()
     {
         // Normally we would throw if the array has been disposed,