Merge pull request #67 from CommunityToolkit/dev/dot-terminated-exceptions

Add missing trailing dot to exception messages

Author: Sergio0694

CommunityToolkit.Common/Collections/ObservableGroupedCollectionExtensions.cs

@@ -34,7 +34,7 @@ public static ObservableGroup<TKey, TValue> First<TKey, TValue>(this ObservableG
         {
             static void ThrowArgumentExceptionForKeyNotFound()
             {
-                throw new InvalidOperationException("The requested key was not present in the collection");
+                throw new InvalidOperationException("The requested key was not present in the collection.");
             }
 
             ThrowArgumentExceptionForKeyNotFound();

CommunityToolkit.Common/Extensions/ISettingsStorageHelperExtensions.cs

@@ -76,6 +76,6 @@ public static void Delete<TKey>(this ISettingsStorageHelper<TKey> storageHelper,
 
     private static void ThrowKeyNotFoundException<TKey>(TKey key)
     {
-        throw new KeyNotFoundException($"The given key '{key}' was not present");
+        throw new KeyNotFoundException($"The given key '{key}' was not present.");
     }
 }

CommunityToolkit.Diagnostics/Generated/ThrowHelper.Collection.g.cs

@@ -28,7 +28,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForIsEmpty<T>(<#=item.Type#> <#=item.Name#>, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must be empty, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must be empty, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -37,7 +37,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeEqualTo<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -46,7 +46,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeNotEqualTo<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size not equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size not equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -55,7 +55,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeGreaterThan<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size over {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size over {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -64,7 +64,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeGreaterThanOrEqualTo<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size of at least {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size of at least {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -73,7 +73,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeLessThan<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -82,7 +82,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeLessThanOrEqualTo<T>(<#=item.Type#> <#=item.Name#>, int size, string name)
             {
-                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than or equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}", name);
+                throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than or equal to {size}, had a size of {AssertString(<#=item.Name#>.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -91,7 +91,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeEqualTo<T>(<#=item.Type#> source, <#=item.DestinationType#> destination, string name)
             {
-                throw new ArgumentException($"The source {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size equal to {AssertString(destination.<#=item.Size#>)} (the destination), had a size of {AssertString(source.<#=item.Size#>)}", name);
+                throw new ArgumentException($"The source {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size equal to {AssertString(destination.<#=item.Size#>)} (the destination), had a size of {AssertString(source.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -100,7 +100,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentExceptionForHasSizeLessThanOrEqualTo<T>(<#=item.Type#> source, <#=item.DestinationType#> destination, string name)
             {
-                throw new ArgumentException($"The source {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than or equal to {AssertString(destination.<#=item.Size#>)} (the destination), had a size of {AssertString(source.<#=item.Size#>)}", name);
+                throw new ArgumentException($"The source {AssertString(name)} ({typeof(<#=item.Type#>).ToTypeString()}) must have a size less than or equal to {AssertString(destination.<#=item.Size#>)} (the destination), had a size of {AssertString(source.<#=item.Size#>)}.", name);
             }
 
             /// <summary>
@@ -109,7 +109,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentOutOfRangeExceptionForIsInRangeFor<T>(int index, <#=item.Type#> <#=item.Name#>, string name)
             {
-                throw new ArgumentOutOfRangeException(name, index, $"Parameter {AssertString(name)} (int) must be in the range given by <0> and {AssertString(<#=item.Name#>.<#=item.Size#>)} to be a valid index for the target collection ({typeof(<#=item.Type#>).ToTypeString()}), was {AssertString(index)}");
+                throw new ArgumentOutOfRangeException(name, index, $"Parameter {AssertString(name)} (int) must be in the range given by <0> and {AssertString(<#=item.Name#>.<#=item.Size#>)} to be a valid index for the target collection ({typeof(<#=item.Type#>).ToTypeString()}), was {AssertString(index)}.");
             }
 
             /// <summary>
@@ -118,7 +118,7 @@ GenerateTextForItems(EnumerableTypes, item =>
             [DoesNotReturn]
             public static void ThrowArgumentOutOfRangeExceptionForIsNotInRangeFor<T>(int index, <#=item.Type#> <#=item.Name#>, string name)
             {
-                throw new ArgumentOutOfRangeException(name, index, $"Parameter {AssertString(name)} (int) must not be in the range given by <0> and {AssertString(<#=item.Name#>.<#=item.Size#>)} to be an invalid index for the target collection ({typeof(<#=item.Type#>).ToTypeString()}), was {AssertString(index)}");
+                throw new ArgumentOutOfRangeException(name, index, $"Parameter {AssertString(name)} (int) must not be in the range given by <0> and {AssertString(<#=item.Name#>.<#=item.Size#>)} to be an invalid index for the target collection ({typeof(<#=item.Type#>).ToTypeString()}), was {AssertString(index)}.");
             }
 <#
 });

CommunityToolkit.Diagnostics/Generated/ThrowHelper.Collection.tt

@@ -25,7 +25,7 @@ private static partial class ThrowHelper
         [DoesNotReturn]
         public static void ThrowArgumentExceptionForIsNotEmptyWithSpan<T>(string name)
         {
-            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(Span<T>).ToTypeString()}) must not be empty", name);
+            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(Span<T>).ToTypeString()}) must not be empty.", name);
         }
 
         /// <summary>
@@ -36,7 +36,7 @@ public static void ThrowArgumentExceptionForIsNotEmptyWithSpan<T>(string name)
         [DoesNotReturn]
         public static void ThrowArgumentExceptionForIsNotEmptyWithReadOnlySpan<T>(string name)
         {
-            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(ReadOnlySpan<T>).ToTypeString()}) must not be empty", name);
+            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(ReadOnlySpan<T>).ToTypeString()}) must not be empty.", name);
         }
 
         /// <summary>
@@ -46,7 +46,7 @@ public static void ThrowArgumentExceptionForIsNotEmptyWithReadOnlySpan<T>(string
         [DoesNotReturn]
         public static void ThrowArgumentExceptionForIsNotEmpty<T>(string name)
         {
-            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(T).ToTypeString()}) must not be empty", name);
+            throw new ArgumentException($"Parameter {AssertString(name)} ({typeof(T).ToTypeString()}) must not be empty.", name);
         }
     }
 }