Rename unit test methods for consistency

Author: Sergio0694

tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ObservableGroup.cs

@@ -13,7 +13,7 @@ namespace CommunityToolkit.Mvvm.UnitTests.Collections;
 public class Test_ObservableGroup
 {
     [TestMethod]
-    public void Ctor_ShouldHaveExpectedState()
+    public void Test_ObservableGroup_Ctor_ShouldHaveExpectedState()
     {
         ObservableGroup<string, int> group = new("key");
 
@@ -22,7 +22,7 @@ public void Ctor_ShouldHaveExpectedState()
     }
 
     [TestMethod]
-    public void Ctor_WithGrouping_ShouldHaveExpectedState()
+    public void Test_ObservableGroup_Ctor_WithGrouping_ShouldHaveExpectedState()
     {
         IntGroup source = new("key", new[] { 1, 2, 3 });
         ObservableGroup<string, int> group = new(source);
@@ -32,7 +32,7 @@ public void Ctor_WithGrouping_ShouldHaveExpectedState()
     }
 
     [TestMethod]
-    public void Ctor_WithCollection_ShouldHaveExpectedState()
+    public void Test_ObservableGroup_Ctor_WithCollection_ShouldHaveExpectedState()
     {
         int[] source = new[] { 1, 2, 3 };
         ObservableGroup<string, int> group = new("key", source);
@@ -42,7 +42,7 @@ public void Ctor_WithCollection_ShouldHaveExpectedState()
     }
 
     [TestMethod]
-    public void Add_ShouldRaiseEvent()
+    public void Test_ObservableGroup_Add_ShouldRaiseEvent()
     {
         bool collectionChangedEventRaised = false;
         int[] source = new[] { 1, 2, 3 };
@@ -58,7 +58,7 @@ public void Add_ShouldRaiseEvent()
     }
 
     [TestMethod]
-    public void Update_ShouldRaiseEvent()
+    public void Test_ObservableGroup_Update_ShouldRaiseEvent()
     {
         bool collectionChangedEventRaised = false;
         int[] source = new[] { 1, 2, 3 };
@@ -74,7 +74,7 @@ public void Update_ShouldRaiseEvent()
     }
 
     [TestMethod]
-    public void Remove_ShouldRaiseEvent()
+    public void Test_ObservableGroup_Remove_ShouldRaiseEvent()
     {
         bool collectionChangedEventRaised = false;
         int[] source = new[] { 1, 2, 3 };
@@ -90,7 +90,7 @@ public void Remove_ShouldRaiseEvent()
     }
 
     [TestMethod]
-    public void Clear_ShouldRaiseEvent()
+    public void Test_ObservableGroup_Clear_ShouldRaiseEvent()
     {
         bool collectionChangedEventRaised = false;
         int[] source = new[] { 1, 2, 3 };
@@ -108,7 +108,7 @@ public void Clear_ShouldRaiseEvent()
     [TestMethod]
     [DataRow(0)]
     [DataRow(3)]
-    public void IReadOnlyObservableGroup_ShouldReturnExpectedValues(int count)
+    public void Test_ObservableGroup_IReadOnlyObservableGroup_ShouldReturnExpectedValues(int count)
     {
         ObservableGroup<string, int> group = new("key", Enumerable.Range(0, count));
         IReadOnlyObservableGroup iReadOnlyObservableGroup = group;
@@ -119,35 +119,35 @@ public void IReadOnlyObservableGroup_ShouldReturnExpectedValues(int count)
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NullKey()
+    public void Test_ObservableGroup_Ctor_NullKey()
     {
         _ = new ObservableGroup<string, int>((string)null!);
     }
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NullGroup()
+    public void Test_ObservableGroup_Ctor_NullGroup()
     {
         _ = new ObservableGroup<string, int>((IGrouping<string, int>)null!);
     }
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NullKeyWithNotNullElements()
+    public void Test_ObservableGroup_Ctor_NullKeyWithNotNullElements()
     {
         _ = new ObservableGroup<string, int>(null!, new int[0]);
     }
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NotNullKeyWithNullElements()
+    public void Test_ObservableGroup_Ctor_NotNullKeyWithNullElements()
     {
         _ = new ObservableGroup<string, int>("A", null!);
     }
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NullKeySetter()
+    public void Test_ObservableGroup_Ctor_NullKeySetter()
     {
         ObservableGroup<string, int> group = new("A");
 

tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ObservableGroupedCollection.cs

@@ -14,15 +14,15 @@ namespace CommunityToolkit.Mvvm.UnitTests.Collections;
 public class Test_ObservableGroupedCollection
 {
     [TestMethod]
-    public void Ctor_ShouldHaveExpectedValues()
+    public void Test_ObservableGroupedCollection_Ctor_ShouldHaveExpectedValues()
     {
         ObservableGroupedCollection<string, int> groupCollection = new();
 
         Assert.AreEqual(groupCollection.Count, 0);
     }
 
     [TestMethod]
-    public void Ctor_WithGroups_ShouldHaveExpectedValues()
+    public void Test_ObservableGroupedCollection_Ctor_WithGroups_ShouldHaveExpectedValues()
     {
         List<IGrouping<string, int>> groups = new()
         {
@@ -42,7 +42,7 @@ public void Ctor_WithGroups_ShouldHaveExpectedValues()
 
     [TestMethod]
     [ExpectedException(typeof(ArgumentNullException))]
-    public void Ctor_NullCollection()
+    public void Test_ObservableGroupedCollection_Ctor_NullCollection()
     {
         _ = new ObservableGroupedCollection<string, int>(null!);
     }

tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ObservableGroupedCollectionExtensions.cs

@@ -12,7 +12,7 @@ namespace CommunityToolkit.Mvvm.UnitTests.Collections;
 public class Test_ObservableGroupedCollectionExtensions
 {
     [TestMethod]
-    public void First_WhenGroupExists_ShouldReturnFirstGroup()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKey_WhenGroupExists_ShouldReturnFirstGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -29,7 +29,7 @@ public void First_WhenGroupExists_ShouldReturnFirstGroup()
 
     [TestMethod]
     [ExpectedException(typeof(InvalidOperationException))]
-    public void First_WhenGroupDoesNotExist_ShouldThrow()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKey_WhenGroupDoesNotExist_ShouldThrow()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -39,7 +39,7 @@ public void First_WhenGroupDoesNotExist_ShouldThrow()
     }
 
     [TestMethod]
-    public void FirstOrDefault_WhenGroupExists_ShouldReturnFirstGroup()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKeyOrDefault_WhenGroupExists_ShouldReturnFirstGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -55,7 +55,7 @@ public void FirstOrDefault_WhenGroupExists_ShouldReturnFirstGroup()
     }
 
     [TestMethod]
-    public void FirstOrDefault_WhenGroupDoesNotExist_ShouldReturnNull()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKeyOrDefault_WhenGroupDoesNotExist_ShouldReturnNull()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -67,7 +67,7 @@ public void FirstOrDefault_WhenGroupDoesNotExist_ShouldReturnNull()
     }
 
     [TestMethod]
-    public void ElementAt_WhenGroupExistsAndIndexInRange_ShouldReturnFirstGroupValue()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKey_WhenGroupExistsAndIndexInRange_ShouldReturnFirstGroupValue()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -84,7 +84,7 @@ public void ElementAt_WhenGroupExistsAndIndexInRange_ShouldReturnFirstGroupValue
     [DataRow(-1)]
     [DataRow(3)]
     [ExpectedException(typeof(ArgumentOutOfRangeException))]
-    public void ElementAt_WhenGroupExistsAndIndexOutOfRange_ShouldReturnThrow(int index)
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKey_WhenGroupExistsAndIndexOutOfRange_ShouldReturnThrow(int index)
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -96,18 +96,7 @@ public void ElementAt_WhenGroupExistsAndIndexOutOfRange_ShouldReturnThrow(int in
     }
 
     [TestMethod]
-    [ExpectedException(typeof(InvalidOperationException))]
-    public void ElementAt_WhenGroupDoesNotExist_ShouldThrow()
-    {
-        ObservableGroupedCollection<string, int> groupedCollection = new();
-
-        _ = groupedCollection.AddGroup("A", new[] { 23 });
-
-        _ = groupedCollection.FirstGroupByKey("I do not exist")[0];
-    }
-
-    [TestMethod]
-    public void ElementAtOrDefault_WhenGroupExistsAndIndexInRange_ShouldReturnValue()
+    public void Test_ObservableGroupedCollectionExtensions_FirstGroupByKey_WhenGroupExistsAndIndexInRange_ShouldReturnValue()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -121,7 +110,7 @@ public void ElementAtOrDefault_WhenGroupExistsAndIndexInRange_ShouldReturnValue(
     }
 
     [TestMethod]
-    public void AddGroup_WithItem_ShouldAddGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddGroup_WithItem_ShouldAddGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -134,7 +123,7 @@ public void AddGroup_WithItem_ShouldAddGroup()
     }
 
     [TestMethod]
-    public void AddGroup_WithCollection_ShouldAddGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddGroup_WithCollection_ShouldAddGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -147,7 +136,7 @@ public void AddGroup_WithCollection_ShouldAddGroup()
     }
 
     [TestMethod]
-    public void AddGroup_WithParamsCollection_ShouldAddGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddGroup_WithParamsCollection_ShouldAddGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -160,7 +149,7 @@ public void AddGroup_WithParamsCollection_ShouldAddGroup()
     }
 
     [TestMethod]
-    public void AddItem_WhenTargetGroupDoesNotExists_ShouldCreateAndAddNewGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddItem_WhenTargetGroupDoesNotExists_ShouldCreateAndAddNewGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -173,7 +162,7 @@ public void AddItem_WhenTargetGroupDoesNotExists_ShouldCreateAndAddNewGroup()
     }
 
     [TestMethod]
-    public void AddItem_WhenSingleTargetGroupAlreadyExists_ShouldAddItemToExistingGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddItem_WhenSingleTargetGroupAlreadyExists_ShouldAddItemToExistingGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -202,7 +191,7 @@ public void AddItem_WhenSingleTargetGroupAlreadyExists_ShouldAddItemToExistingGr
     }
 
     [TestMethod]
-    public void AddItem_WhenSeveralTargetGroupsAlreadyExist_ShouldAddItemToFirstExistingGroup()
+    public void Test_ObservableGroupedCollectionExtensions_AddItem_WhenSeveralTargetGroupsAlreadyExist_ShouldAddItemToFirstExistingGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -235,7 +224,7 @@ public void AddItem_WhenSeveralTargetGroupsAlreadyExist_ShouldAddItemToFirstExis
     }
 
     [TestMethod]
-    public void RemoveGroup_WhenGroupDoesNotExists_ShouldDoNothing()
+    public void Test_ObservableGroupedCollectionExtensions_RemoveGroup_WhenGroupDoesNotExists_ShouldDoNothing()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -249,7 +238,7 @@ public void RemoveGroup_WhenGroupDoesNotExists_ShouldDoNothing()
     }
 
     [TestMethod]
-    public void RemoveGroup_WhenSingleGroupExists_ShouldRemoveGroup()
+    public void Test_ObservableGroupedCollectionExtensions_RemoveGroup_WhenSingleGroupExists_ShouldRemoveGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -264,7 +253,7 @@ public void RemoveGroup_WhenSingleGroupExists_ShouldRemoveGroup()
     }
 
     [TestMethod]
-    public void RemoveGroup_WhenSeveralGroupsExist_ShouldRemoveFirstGroup()
+    public void Test_ObservableGroupedCollectionExtensions_RemoveGroup_WhenSeveralGroupsExist_ShouldRemoveFirstGroup()
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -286,7 +275,7 @@ public void RemoveGroup_WhenSeveralGroupsExist_ShouldRemoveFirstGroup()
     [TestMethod]
     [DataRow(true)]
     [DataRow(false)]
-    public void RemoveItem_WhenGroupDoesNotExist_ShouldDoNothing(bool removeGroupIfEmpty)
+    public void Test_ObservableGroupedCollectionExtensions_RemoveItem_WhenGroupDoesNotExist_ShouldDoNothing(bool removeGroupIfEmpty)
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -307,7 +296,7 @@ public void RemoveItem_WhenGroupDoesNotExist_ShouldDoNothing(bool removeGroupIfE
     [TestMethod]
     [DataRow(true)]
     [DataRow(false)]
-    public void RemoveItem_WhenGroupExistsAndItemDoesNotExist_ShouldDoNothing(bool removeGroupIfEmpty)
+    public void Test_ObservableGroupedCollectionExtensions_RemoveItem_WhenGroupExistsAndItemDoesNotExist_ShouldDoNothing(bool removeGroupIfEmpty)
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -328,7 +317,7 @@ public void RemoveItem_WhenGroupExistsAndItemDoesNotExist_ShouldDoNothing(bool r
     [TestMethod]
     [DataRow(true)]
     [DataRow(false)]
-    public void RemoveItem_WhenGroupAndItemExist_ShouldRemoveItemFromGroup(bool removeGroupIfEmpty)
+    public void Test_ObservableGroupedCollectionExtensions_RemoveItem_WhenGroupAndItemExist_ShouldRemoveItemFromGroup(bool removeGroupIfEmpty)
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();
 
@@ -349,7 +338,7 @@ public void RemoveItem_WhenGroupAndItemExist_ShouldRemoveItemFromGroup(bool remo
     [TestMethod]
     [DataRow(true, true)]
     [DataRow(false, false)]
-    public void RemoveItem_WhenRemovingLastItem_ShouldRemoveGroupIfRequired(bool removeGroupIfEmpty, bool expectGroupRemoved)
+    public void Test_ObservableGroupedCollectionExtensions_RemoveItem_WhenRemovingLastItem_ShouldRemoveGroupIfRequired(bool removeGroupIfEmpty, bool expectGroupRemoved)
     {
         ObservableGroupedCollection<string, int> groupedCollection = new();