Skip to content

Commit dfa1430

Browse files
AmbratolmAmbratolm
authored andcommitted
Minor (no)rank name display fix
1 parent 1c05c08 commit dfa1430

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

bot/cogs/game_cogs/combat_cog.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,8 @@ async def attack(self, interaction: Interaction, member: Member):
237237
if attack.defender_is_promoted
238238
else " 🔻" if attack.defender_is_demoted else ""
239239
)
240-
attacker_rank_name = attacker_actor.rank.name if attacker_actor.rank else None
241-
defender_rank_name = defender_actor.rank.name if defender_actor.rank else None
240+
attacker_rank_name = attacker_actor.rank.name if attacker_actor.rank else "?"
241+
defender_rank_name = defender_actor.rank.name if defender_actor.rank else "?"
242242
post_combat_embed.add_field(
243243
name=f"{attacker_actor.display_name}",
244244
value=f"**Gold{attacker_gold_mod_emoji}**\n"
@@ -296,18 +296,15 @@ async def revive(self, interaction: Interaction):
296296
db.save(actor)
297297

298298
# Send private response
299-
await interaction.followup.send(
300-
embed=EmbedX.success(
301-
f"You have recovered!\nIt cost **💰 {revive_cost}** gold."
302-
)
303-
)
304-
response_msg = f"✨ You have recovered for **{revive_cost}** gold."
299+
response_msg = f"You have recovered!\nIt cost **💰 {revive_cost}** gold."
305300
if actor.gold < 0:
306301
await interaction.followup.send(
307302
embed=EmbedX.warning(
308-
f"⚠️ You are now in **debt**!\nYour current balance is **💰 {actor.gold}** gold.\n"
303+
f"{response_msg}\nYou are now in **debt**!\nYour current balance is **💰 {actor.gold}** gold.\n"
309304
)
310305
)
306+
else:
307+
await interaction.followup.send(embed=EmbedX.success(response_msg))
311308

312309
# Create & send public embed
313310
embed = EmbedX.info(

bot/cogs/game_cogs/leaderboard_cog.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ async def leaderboard(self, interaction: Interaction):
4646
if i == 0:
4747
top_actor = actor
4848
name = member.mention
49-
rank = actor.rank
49+
rank = actor.rank.name if actor.rank else "?"
5050
level = str(actor.level)
5151
xp = naturalsize(actor.xp, binary=False, gnu=True).replace("B", "")
5252
gold = naturalsize(actor.gold, binary=False, gnu=True).replace("B", "")

0 commit comments

Comments
 (0)