Skip to content

Commit 79f8d84

Browse files
committed
Fixing after merge
1 parent eb7456f commit 79f8d84

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

MainClass.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,7 @@ private static void RegularParametersParsing(string[] args)
574574
"-o, --output");
575575
}
576576

577-
if (metadataFormatString == null && parseInput.DepositionMetadataFile == null
578-
&& parseInput.ExperimentMetadataFile == null && outputFormatString == null)
577+
if (metadataFormatString == null && outputFormatString == null)
579578
{
580579
parseInput.OutputFormat = OutputFormat.IndexMzML;
581580
}

ParseInput.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public string RawFilePath
2929
if (value != null)
3030
{
3131
RawFileNameWithoutExtension = Path.GetFileNameWithoutExtension(value);
32+
//do we need it?
3233
var splittedPath = value.Split('/');
3334
_rawFileName = splittedPath[splittedPath.Length - 1];
3435
}
@@ -93,6 +94,7 @@ public string RawFilePath
9394

9495
public string BucketName { get; set; }
9596

97+
//this property assigned but never used
9698
/// <summary>
9799
/// The raw file name.
98100
/// </summary>

Writer/MzMlSpectrumWriter.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,7 +1181,7 @@ private SpectrumType ConstructMSSpectrum(int scanNumber)
11811181
//tune version < 3
11821182
if (trailerData.Has("SPS Mass 1:"))
11831183
{
1184-
foreach (var label in trailerData.MatchKeys(SPSentry))
1184+
foreach (var label in trailerData.MatchKeys(_spSentry))
11851185
{
11861186
var mass = trailerData.AsDouble(label).GetValueOrDefault(0);
11871187
if (mass > 0) SPSMasses.Add((double)mass); //zero means mass does not exist
@@ -1191,7 +1191,7 @@ private SpectrumType ConstructMSSpectrum(int scanNumber)
11911191
//tune version == 3
11921192
if (trailerData.Has("SPS Masses:"))
11931193
{
1194-
foreach (var labelvalue in trailerData.MatchValues(SPSentry3))
1194+
foreach (var labelvalue in trailerData.MatchValues(_spSentry3))
11951195
{
11961196
foreach (var mass in labelvalue.Trim().Split(new char[] { ',' }, StringSplitOptions.RemoveEmptyEntries))
11971197
{
@@ -1372,7 +1372,7 @@ private SpectrumType ConstructMSSpectrum(int scanNumber)
13721372
});
13731373

13741374
// FAIMS
1375-
if(FAIMSCV != null && FAIMSON)
1375+
if(FAIMSCV != null)
13761376
{
13771377
spectrumCvParams.Add(new CVParamType
13781378
{

0 commit comments

Comments
 (0)