ZSPACE-12104 Solve code review issues.

zhaoheting-zontal · zhaoheting-zontal · commit dc22d8741da2 · 2023-02-27T06:31:44.000Z
diff --git a/Writer/MetadataWriter.cs b/Writer/MetadataWriter.cs
@@ -481,13 +481,9 @@ private void WriteTextMetadata(IRawDataPlus rawFile, int firstScanNumber, int la
             string[] userTexts = rawFile.SampleInformation.UserText;
             if (!userLabels.IsNullOrEmpty() && !userTexts.IsNullOrEmpty())
             {
-                if (userLabels.Length > userTexts.Length)
-                {
-                    throw new RawFileParserException();
-                }
                 for (int i = 0; i < userLabels.Length; i++)
                 {
-                    if (!userTexts[i].IsNullOrEmpty())
+                    if (i < userTexts.Length && !userTexts[i].IsNullOrEmpty())
                     {
                         output.Add(userLabels[i] + "=" + userTexts[i]);
                     }

Original file line number	Diff line number	Diff line change
`@@ -481,13 +481,9 @@ private void WriteTextMetadata(IRawDataPlus rawFile, int firstScanNumber, int la`
`481`	`481`	`string[] userTexts = rawFile.SampleInformation.UserText;`
`482`	`482`	`if (!userLabels.IsNullOrEmpty() && !userTexts.IsNullOrEmpty())`
`483`	`483`	`{`
`484`		`- if (userLabels.Length > userTexts.Length)`
`485`		`- {`
`486`		`- throw new RawFileParserException();`
`487`		`- }`
`488`	`484`	`for (int i = 0; i < userLabels.Length; i++)`
`489`	`485`	`{`
`490`		`- if (!userTexts[i].IsNullOrEmpty())`
	`486`	`+ if (i < userTexts.Length && !userTexts[i].IsNullOrEmpty())`
`491`	`487`	`{`
`492`	`488`	`output.Add(userLabels[i] + "=" + userTexts[i]);`
`493`	`489`	`}`