fix type_complexity issues with clippy

Author: ArthurDeclercq

src/ms2_spectrum.rs

@@ -2,6 +2,9 @@ use pyo3::prelude::*;
 
 use crate::precursor::Precursor;
 
+type MS2SpectrumReduceArgs = (String, Vec<f32>, Vec<f32>, Option<Precursor>);
+type MS2SpectrumReduceReturn = (PyObject, MS2SpectrumReduceArgs);
+
 #[pyclass(module = "ms2rescore_rs", get_all, set_all)]
 #[derive(Debug, Clone)]
 pub struct MS2Spectrum {
@@ -18,12 +21,7 @@ impl MS2Spectrum {
         intensity: Vec<f32>,
         precursor: Option<Precursor>,
     ) -> Self {
-        MS2Spectrum {
-            identifier,
-            mz,
-            intensity,
-            precursor,
-        }
+        MS2Spectrum { identifier, mz, intensity, precursor }
     }
 }
 
@@ -47,8 +45,16 @@ impl MS2Spectrum {
         )
     }
 
-    pub fn __reduce__(&self, py: Python<'_>) -> PyResult<(PyObject, (String, Vec<f32>, Vec<f32>, Option<Precursor>))> {
+    pub fn __reduce__(&self, py: Python<'_>) -> PyResult<MS2SpectrumReduceReturn> {
         let cls = py.import("ms2rescore_rs")?.getattr("MS2Spectrum")?;
-        Ok((cls.into(), (self.identifier.clone(), self.mz.clone(), self.intensity.clone(), self.precursor.clone())))
+        Ok((
+            cls.into(),
+            (
+                self.identifier.clone(),
+                self.mz.clone(),
+                self.intensity.clone(),
+                self.precursor.clone(),
+            ),
+        ))
     }
 }

src/precursor.rs

@@ -1,6 +1,8 @@
 use pyo3::prelude::*;
 
-/// Precursor information.
+type PrecursorReduceArgs = (f64, f64, f64, usize, f64);
+type PrecursorReduceReturn = (PyObject, PrecursorReduceArgs);
+
 #[pyclass(module = "ms2rescore_rs", get_all, set_all)]
 #[derive(Debug, Clone)]
 pub struct Precursor {
@@ -16,13 +18,7 @@ impl Precursor {
     #[new]
     #[pyo3(signature = (mz=0.0, rt=0.0, im=0.0, charge=0, intensity=0.0))]
     pub fn new(mz: f64, rt: f64, im: f64, charge: usize, intensity: f64) -> Self {
-        Precursor {
-            mz,
-            rt,
-            im,
-            charge,
-            intensity,
-        }
+        Precursor { mz, rt, im, charge, intensity }
     }
 
     pub fn __repr__(&self) -> String {
@@ -32,20 +28,8 @@ impl Precursor {
         )
     }
 
-    pub fn __reduce__(&self, py: Python<'_>) -> PyResult<(PyObject, (f64, f64, f64, usize, f64))> {
+    pub fn __reduce__(&self, py: Python<'_>) -> PyResult<PrecursorReduceReturn> {
         let cls = py.import("ms2rescore_rs")?.getattr("Precursor")?;
         Ok((cls.into(), (self.mz, self.rt, self.im, self.charge, self.intensity)))
     }
 }
-
-impl Default for Precursor {
-    fn default() -> Self {
-        Precursor {
-            mz: 0.0,
-            rt: 0.0,
-            im: 0.0,
-            charge: 0,
-            intensity: 0.0,
-        }
-    }
-}