Skip to content

Commit 8ed3eef

Browse files
committed
Test pinned dependencies for pyinstaller through dependency group
1 parent 149687c commit 8ed3eef

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,18 @@ jobs:
4545
run: uv run ms2rescore --help
4646

4747
test-windows-installer:
48-
# Only run on push to main (e.g., after PR merge)
49-
if: ${{ github.ref == 'refs/heads/main' }}
5048
runs-on: windows-latest
5149
steps:
5250
- uses: actions/checkout@v4
5351

54-
- uses: actions/setup-python@v5
52+
- name: Install uv
53+
uses: astral-sh/setup-uv@v6
5554
with:
56-
python-version: "3.12"
55+
python-version: "3.11"
56+
enable-cache: true
5757

5858
- name: Install package and dependencies
59-
run: |
60-
# Using pip to ensure proper environment discovery by PyInstaller
61-
python -m pip install --upgrade pip
62-
pip install --only-binary :all: .[ionmob,idxml] pyinstaller
59+
run: uv pip install --group installer .
6360

6461
- name: Install Inno Setup
6562
uses: crazy-max/ghaction-chocolatey@v1

pyproject.toml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ authors = [
1919
{ name = "Ralf Gabriels", email = "[email protected]" },
2020
{ name = "Arthur Declercq", email = "[email protected]" },
2121
{ name = "Ana Sílvia C. Silva" },
22+
{ name = "Robbe Devreese" },
2223
{ name = "Robbin Bouwmeester" },
2324
{ name = "Louise Buur" },
2425
]
@@ -37,12 +38,12 @@ dependencies = [
3738
"customtkinter>=5,<6",
3839
"deeplc>=3.1",
3940
"deeplcretrainer",
40-
"im2deep==1.1.1",
41+
"im2deep>=1.1",
4142
"jinja2>=3",
4243
"lxml>=4.5",
4344
"mokapot==0.10", # 0.11.0 will introduce API changes
4445
"ms2pip>=4.0.0",
45-
"ms2rescore_rs>=0.4.3",
46+
"ms2rescore_rs>=0.4",
4647
"numpy>=1.25",
4748
"packaging>=25.0",
4849
"pandas>=1",
@@ -71,6 +72,14 @@ docs = [
7172
"sphinx-autobuild",
7273
"toml",
7374
]
75+
installer = [
76+
# Pinned dependencies for reproducible Windows installer builds
77+
"pyinstaller",
78+
"pyopenms==3.3",
79+
"ionmob>=0.2",
80+
"tensorflow",
81+
"im2deep==1.1.1",
82+
]
7483

7584
[project.urls]
7685
GitHub = "https://github.com/compomics/ms2rescore"

0 commit comments

Comments
 (0)