Skip to content

Commit f47062a

Browse files
authored
Merge pull request #237 from CompOmics/update-python-versions
Default to Python 3.12, add idxml extra, upgrade DeepLC ≥ 3.1, and fix ignored profile config parameter
2 parents 876e4ca + c404b9d commit f47062a

File tree

7 files changed

+65
-79
lines changed

7 files changed

+65
-79
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Install uv and set the Python version
1717
uses: astral-sh/setup-uv@v6
1818
with:
19-
python-version: "3.11"
19+
python-version: "3.12"
2020
enable-cache: true
2121

2222
- name: Install the project

.github/workflows/test.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ jobs:
2323
needs: check-python-package
2424
runs-on: ubuntu-latest
2525
strategy:
26+
fail-fast: false
2627
matrix:
27-
python-version: ["3.9", "3.10", "3.11"]
28+
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
2829
steps:
2930
- uses: actions/checkout@v4
3031

@@ -52,13 +53,13 @@ jobs:
5253

5354
- uses: actions/setup-python@v5
5455
with:
55-
python-version: "3.11"
56+
python-version: "3.12"
5657

5758
- name: Install package and dependencies
5859
run: |
5960
# Using pip to ensure proper environment discovery by PyInstaller
6061
python -m pip install --upgrade pip
61-
pip install --only-binary :all: .[ionmob] pyinstaller
62+
pip install --only-binary :all: .[ionmob,idxml] pyinstaller
6263
6364
- name: Install Inno Setup
6465
uses: crazy-max/ghaction-chocolatey@v1

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ ADD ms2rescore /ms2rescore/ms2rescore
3131

3232
# Install the project and its dependencies using the lockfile and settings
3333
RUN --mount=type=cache,target=/root/.cache/uv \
34-
uv sync --no-dev
34+
uv sync --no-dev --all-extras
3535

3636
# Place executables in the environment at the front of the path
3737
ENV PATH="/ms2rescore/.venv/bin:$PATH"

ms2rescore/__init__.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@
1919
module="psims.mzmlb",
2020
)
2121

22+
# Attempt to suppress pyopenms warning about OPENMS_DATA_PATH already set
23+
filterwarnings(
24+
"ignore",
25+
message="Warning: OPENMS_DATA_PATH environment variable already exists.*",
26+
category=UserWarning,
27+
module="pyopenms",
28+
)
29+
2230
from ms2rescore._version import get_version # noqa: E402
2331
from ms2rescore.config_parser import parse_configurations # noqa: E402
2432
from ms2rescore.core import rescore # noqa: E402

ms2rescore/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ def main(tims=False):
247247

248248
# Run MS²Rescore
249249
try:
250-
if cli_args.profile:
250+
if config["ms2rescore"]["profile"]:
251251
profiled_rescore = profile(rescore, config["ms2rescore"]["output_path"])
252252
profiled_rescore(configuration=config)
253253
else:

pyproject.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ classifiers = [
3030
"Topic :: Scientific/Engineering :: Bio-Informatics",
3131
"Development Status :: 5 - Production/Stable",
3232
]
33-
requires-python = ">=3.9"
33+
requires-python = ">=3.10"
3434
dependencies = [
3535
"cascade-config>=0.4.0",
3636
"click>=7",
3737
"customtkinter>=5,<6",
38-
"deeplc>=3.0,<3.1",
38+
"deeplc>=3.1",
3939
"deeplcretrainer",
4040
"im2deep>=0.3.1",
4141
"jinja2>=3",
@@ -55,6 +55,7 @@ dependencies = [
5555

5656
[project.optional-dependencies]
5757
ionmob = ["ionmob>=0.2", "tensorflow"]
58+
idxml = ["pyopenms>=3.3"]
5859

5960
[dependency-groups]
6061
dev = ["ruff", "black", "pytest>=8.4.2", "pytest-cov", "pre-commit>=4.3.0"]

uv.lock

Lines changed: 47 additions & 71 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)