Skip to content

Commit c1b0095

Browse files
committed
remove checksum check in parquet tests
1 parent 09bc968 commit c1b0095

File tree

2 files changed

+14
-23
lines changed

2 files changed

+14
-23
lines changed

tests/test_data/test.pq

5.05 KB
Binary file not shown.

tests/test_io/test_parquet.py

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"""Tests for psm_utils.io.tsv."""
22

3-
import hashlib
43
import os
54

65
from psm_utils.io.parquet import ParquetReader, ParquetWriter
@@ -32,40 +31,32 @@
3231
]
3332

3433

35-
def compute_checksum(filename):
36-
hash_func = hashlib.sha256()
37-
with open(filename, "rb") as f:
38-
for chunk in iter(lambda: f.read(4096), b""):
39-
hash_func.update(chunk)
40-
return hash_func.hexdigest()
41-
42-
4334
class TestParquetWriter:
44-
expected_checksum = "1e5ee7afc5d4131bce8f1d0908136b8c559303abb7bbd7d052afa111d5e64f0c"
45-
4635
def test_write_psm(self):
4736
with ParquetWriter("test.pq") as writer:
4837
for test_case in test_cases:
4938
writer.write_psm(PSM(**test_case))
50-
actual_checksum = compute_checksum("test.pq")
51-
assert actual_checksum == self.expected_checksum, "Checksums do not match"
39+
40+
with ParquetReader("test.pq") as reader:
41+
for i, psm in enumerate(reader):
42+
assert psm == PSM(**test_cases[i])
43+
5244
os.remove("test.pq")
5345

5446
def test_write_file(self):
5547
with ParquetWriter("test.pq") as writer:
5648
writer.write_file(PSMList(psm_list=[PSM(**t) for t in test_cases]))
57-
actual_checksum = compute_checksum("test.pq")
58-
assert actual_checksum == self.expected_checksum, "Checksums do not match"
59-
# os.remove("test.pq")
49+
50+
with ParquetReader("test.pq") as reader:
51+
for i, psm in enumerate(reader):
52+
assert psm == PSM(**test_cases[i])
53+
54+
os.remove("test.pq")
6055

6156

6257
class TestParquetReader:
6358
def test_iter(self):
64-
# Write test cases to file
65-
ParquetWriter("test.pq").write_file(PSMList(psm_list=[PSM(**t) for t in test_cases]))
66-
6759
# Read test cases from file
68-
for i, psm in enumerate(ParquetReader("test.pq")):
69-
assert psm == PSM(**test_cases[i])
70-
71-
os.remove("test.pq")
60+
with ParquetReader("tests/test_data/test.pq") as reader:
61+
for i, psm in enumerate(reader):
62+
assert psm == PSM(**test_cases[i])

0 commit comments

Comments
 (0)