Start filled layer tests

Author: robotgryphon

src/api/java/dev/compactmods/crafting/api/recipe/layers/dim/IDynamicSizedRecipeLayer.java

@@ -13,5 +13,5 @@ public interface IDynamicSizedRecipeLayer {
      * Used to recalculate dynamic-sized recipe layers. Expected to be called
      * any time components or base recipe dimensions change.
      */
-    void recalculateRequirements();
+    default void recalculateRequirements() {}
 }

src/main/java/dev/compactmods/crafting/recipes/layers/FilledComponentRecipeLayer.java

@@ -28,6 +28,7 @@ public class FilledComponentRecipeLayer implements IRecipeLayer, IDynamicSizedRe
         ).apply(in, FilledComponentRecipeLayer::new));
 
     public FilledComponentRecipeLayer(String component) {
+        this.recipeDimensions = AxisAlignedBB.ofSize(0, 0, 0);
         this.componentKey = component;
     }
 
@@ -92,14 +93,5 @@ public void setComponent(String component) {
      */
     public void setRecipeDimensions(AxisAlignedBB dimensions) {
         this.recipeDimensions = dimensions;
-        this.recalculateRequirements();
-    }
-
-    /**
-     * Used to recalculate dynamic-sized recipe layers. Expected to be called
-     * any time components or base recipe dimensions change.
-     */
-    public void recalculateRequirements() {
-
     }
 }

src/test/java/dev/compactmods/crafting/tests/recipes/layers/FilledLayerTests.java

@@ -0,0 +1,52 @@
+package dev.compactmods.crafting.tests.recipes.layers;
+
+import com.google.gson.JsonElement;
+import com.mojang.serialization.JsonOps;
+import dev.compactmods.crafting.recipes.layers.FilledComponentRecipeLayer;
+import dev.compactmods.crafting.tests.util.FileHelper;
+import net.minecraft.util.math.AxisAlignedBB;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+public class FilledLayerTests {
+
+    private FilledComponentRecipeLayer getLayerFromFile(String filename) {
+        JsonElement layerJson = FileHelper.INSTANCE.getJsonFromFile(filename);
+
+        return FilledComponentRecipeLayer.CODEC.parse(JsonOps.INSTANCE, layerJson)
+                .getOrThrow(false, Assertions::fail);
+    }
+
+    @Test
+    @Tag("minecraft")
+    void CanCreateLayerInstance() {
+        getLayerFromFile("layers/filled/basic.json");
+    }
+
+    @Test
+    @Tag("minecraft")
+    void ReturnsNoFilledIfDimensionsNull() {
+        final FilledComponentRecipeLayer layer = getLayerFromFile("layers/filled/basic.json");
+
+        int filled = Assertions.assertDoesNotThrow(layer::getNumberFilledPositions);
+        Assertions.assertEquals(0, filled);
+    }
+
+    @Test
+    @Tag("minecraft")
+    void CanUpdateDimensions() {
+        final FilledComponentRecipeLayer layer = getLayerFromFile("layers/filled/basic.json");
+
+        int filledBefore = layer.getNumberFilledPositions();
+
+        AxisAlignedBB newDims = new AxisAlignedBB(0, 0, 0, 5, 1, 5);
+        Assertions.assertDoesNotThrow(() -> layer.setRecipeDimensions(newDims));
+
+        int filledAfter = layer.getNumberFilledPositions();
+
+        Assertions.assertNotEquals(filledBefore, filledAfter, "Expected component count to change after growing layer dimensions.");
+    }
+
+
+}

src/test/resources/layers/filled/basic.json

@@ -0,0 +1,4 @@
+{
+  "type": "compactcrafting:filled",
+  "component":"Gl"
+}

src/test/resources/layers/filled/tests/filled_basic.json

@@ -0,0 +1,25 @@
+{
+  "world": {
+    "type": "compactcrafting:filled",
+    "component": "Gl"
+  },
+
+  "worldBlocks": {
+    "Gl": {
+      "type": "compactcrafting:block",
+      "block": "minecraft:glass"
+    }
+  },
+
+  "layer": {
+    "type": "compactcrafting:filled",
+    "component":"Gl"
+  },
+
+  "components": {
+    "Gl": {
+      "type": "compactcrafting:block",
+      "block": "minecraft:glass"
+    }
+  }
+}