Fix rendering of YABBA barrels

And other tile entities that require a valid or known world.
Fixes #395

Author: davenonymous

src/main/java/org/dave/compactmachines3/gui/machine/widgets/WidgetMachinePreview.java

@@ -23,6 +23,7 @@
 import org.dave.compactmachines3.gui.machine.GuiMachineData;
 import org.dave.compactmachines3.misc.ConfigurationHandler;
 import org.dave.compactmachines3.misc.RenderTickCounter;
+import org.dave.compactmachines3.utility.ChunkUtils;
 import org.dave.compactmachines3.utility.Logz;
 import org.lwjgl.opengl.GL11;
 
@@ -239,10 +240,19 @@ public void renderLayer(BlockRendererDispatcher blockrendererdispatcher, BufferB
 
             ForgeHooksClient.setRenderLayer(renderLayer);
 
+            try {
+                TileEntity te = CompactMachines3.clientWorldData.worldClone.getTileEntity(pos);
+                if (te != null && ChunkUtils.erroneousTiles.contains(te.getClass().getName())) {
+                    continue;
+                }
+            } catch(Exception e) {
+                continue;
+            }
+
             try {
                 blockrendererdispatcher.renderBlock(state, pos, CompactMachines3.clientWorldData.worldClone, buffer);
-            } catch (Exception e) {
-                e.printStackTrace();
+            } catch (Throwable e) {
+                Logz.debug("Failed rendering of block: %s", state.getBlock());
             }
 
             ForgeHooksClient.setRenderLayer(null);
@@ -292,7 +302,13 @@ private void renderTileEntities(TileEntityRendererDispatcher renderer, List<Bloc
         }
         ForgeHooksClient.setRenderLayer(BlockRenderLayer.SOLID);
         for (BlockPos pos : toRender) {
-            TileEntity te = CompactMachines3.clientWorldData.worldClone.getTileEntity(pos);
+            TileEntity te;
+            try {
+                te = CompactMachines3.clientWorldData.worldClone.getTileEntity(pos);
+            } catch (Exception e) {
+                continue;
+            }
+
             if(te != null) {
                 te.setWorld(CompactMachines3.clientWorldData.worldClone);
                 te.setPos(pos);

src/main/java/org/dave/compactmachines3/utility/ChunkUtils.java

@@ -19,11 +19,14 @@
 import org.dave.compactmachines3.world.data.provider.ExtraTileDataProviderRegistry;
 
 import java.lang.reflect.Field;
+import java.util.ArrayList;
 import java.util.List;
 
 public class ChunkUtils {
     private static Field updatePacketNBTField;
 
+    public static List<String> erroneousTiles = new ArrayList<>();
+
     public static IBlockAccess getBlockAccessFromChunk(Chunk chunk) {
         return new ChunkBlockAccess(chunk);
     }
@@ -239,13 +242,27 @@ public static void loadEntities(World worldIn, NBTTagCompound compound, Chunk ch
             TileEntity tileentity = TileEntity.create(worldIn, nbttagcompound2);
             if (tileentity != null)
             {
-                tileentity.setWorld(worldIn);
+                if(erroneousTiles.contains(tileentity.getClass().getName())) {
+                    continue;
+                }
 
-                for(AbstractExtraTileDataProvider provider : ExtraTileDataProviderRegistry.getDataProviders(tileentity)) {
-                    String tagName = String.format("cm3_extra:%s", provider.getName());
-                    if(nbttagcompound2.hasKey(tagName)) {
-                        provider.readExtraData(tileentity, (NBTTagCompound) nbttagcompound2.getTag(tagName));
+                try {
+                    tileentity.setWorld(worldIn);
+                } catch (Exception e) {
+                    Logz.warn("Unable to render tile-entity %s in a fake world. Skipping.", tileentity.getClass().getName());
+                    erroneousTiles.add(tileentity.getClass().getName());
+                    continue;
+                }
+
+                try {
+                    for (AbstractExtraTileDataProvider provider : ExtraTileDataProviderRegistry.getDataProviders(tileentity)) {
+                        String tagName = String.format("cm3_extra:%s", provider.getName());
+                        if (nbttagcompound2.hasKey(tagName)) {
+                            provider.readExtraData(tileentity, (NBTTagCompound) nbttagcompound2.getTag(tagName));
+                        }
                     }
+                } catch (Exception e) {
+                    Logz.warn("Unable to provide extra tile-entity data for %s", tileentity.getClass().getName());
                 }
 
                 chunk.addTileEntity(tileentity);