Cmake: the handling of the case without TBB doesn't work

[srpgilles]

In ctrackConfig.cmake, there is the block:

if(NOT MSVC AND NOT CTRACK_DISABLE_EXECUTION_POLICY)
    include(CMakeFindDependencyMacro)
    find_dependency(TBB QUIET)
    if(NOT TBB_FOUND)
        message(STATUS "TBB not found. Disabling parallel execution for ctrack.")
        set(CTRACK_DISABLE_EXECUTION_POLICY ON)
    endif()
endif()

When TBB is not found in the find_dependency line, it stops the installation with the failure - apparently QUIET is just there to limit the verbosity of the output.

I don't quite get how to provide CTRACK_DISABLE_EXECUTION_POLICY (I'm not super at ease with CMake configuration); it is not propagated when DISABLE_PAR is set and giving a CTRACK_DISABLE_EXECUTION_POLICY is the CMake command doesn't quite work to avoid entirely the block above.

[Compaile]

Hi, are you working on the latest release or master branch? Can you give me more Information how you are currently building/installing ctrack? On the current version if you build ctrack from source you can provide DISABLE_PAR and it should propagate. You can also always include it directly via header and set the #define CTRACK_DISABLE_EXECUTION_POLICY in code.

[Compaile]

see #6
when you set CTRACK_DISABLE_EXECUTION_POLICY urself does it compile? then its probably a cmake bug i will need to look at and fix. Thanks for the report

[srpgilles]

I'm working with the latest release tarball (1.1.0)

The installation itself is fine; it's when I try to use it in another library that I meet the issue.

In this other library the call that fails is just `find_package(ctrack REQUIRED HINTS directory where to look for the package config file)

The error is:

CMake Error at /gnu/store/5bfm0m2sx9fzc4hx1gwrnv805ha8xvsr-cmake-minimal-3.31.8/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindTBB.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "TBB", but
  CMake did not find one.

  Could not find a package configuration file provided by "TBB" with any of
  the following names:

    TBBConfig.cmake
    tbb-config.cmake

  Add the installation prefix of "TBB" to CMAKE_PREFIX_PATH or set "TBB_DIR"
  to a directory containing one of the above files.  If "TBB" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  /gnu/store/a0f4hwi9vdgiw6rgbcsqmbr13wc9gpj9-ctrack-1.1.0/lib/cmake/ctrack/ctrackConfig.cmake:31 (find_dependency)
  cmake/MoReFEMSettings.cmake:197 (find_package)
  CMakeLists.txt:34 (include)

(This is while building with Guix hence the weird path).

I am pretty sure it is a CMake issue, but as I said I am not super at ease with this tool.

[Compaile]

ahh i see. Good point. Yes will fix it soon. Thanks