Skip to content

Commit 569db46

Browse files
committed
Remove add-iam-policy-binding to roles/artifactregistry.reader post API deploy
May not be needed
1 parent 9493ee6 commit 569db46

File tree

3 files changed

+28
-14
lines changed

3 files changed

+28
-14
lines changed

backend/api/README.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,22 @@ gcloud compute backend-services update api-backend \
7070
```shell
7171
gcloud iam service-accounts create ci-deployer \
7272
--display-name="CI Deployer"
73-
gcloud projects add-iam-policy-binding compass-130ba --member="serviceAccount:[email protected]" --role="roles/artifactregistry.writer"
74-
gcloud projects add-iam-policy-binding compass-130ba --member="serviceAccount:[email protected]" --role="roles/storage.objectAdmin"
73+
gcloud projects add-iam-policy-binding compass-130ba \
74+
--member="serviceAccount:[email protected]" \
75+
--role="roles/artifactregistry.writer"
76+
gcloud projects add-iam-policy-binding compass-130ba \
77+
--member="serviceAccount:[email protected]" \
78+
--role="roles/storage.objectAdmin"
79+
gcloud projects add-iam-policy-binding compass-130ba \
80+
--member="serviceAccount:[email protected]" \
81+
--role="roles/storage.admin"
82+
gcloud projects add-iam-policy-binding compass-130ba \
83+
--member="serviceAccount:[email protected]" \
84+
--role="roles/compute.admin"
85+
gcloud iam service-accounts add-iam-policy-binding \
86+
87+
--member="serviceAccount:[email protected]" \
88+
--role="roles/iam.serviceAccountUser"
7589
gcloud iam service-accounts keys create keyfile.json [email protected]
7690
```
7791

backend/api/deploy-api.sh

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@ export TF_VAR_image_url=$IMAGE_URL
5454
export TF_VAR_env=$ENV
5555
tofu apply -auto-approve
5656

57-
INSTANCE_NAME=$(gcloud compute instances list \
58-
--filter="zone:(us-west1-c)" \
59-
--sort-by="~creationTimestamp" \
60-
--format="value(name)" \
61-
--limit=1)
62-
SERVICE_ACCOUNT_EMAIL=$(gcloud compute instances describe ${INSTANCE_NAME} \
63-
--zone us-west1-c \
64-
--format="value(serviceAccounts.email)")
65-
gcloud projects add-iam-policy-binding ${PROJECT} \
66-
--member="serviceAccount:$SERVICE_ACCOUNT_EMAIL" \
67-
--role="roles/artifactregistry.reader"
57+
#INSTANCE_NAME=$(gcloud compute instances list \
58+
# --filter="zone:(us-west1-c)" \
59+
# --sort-by="~creationTimestamp" \
60+
# --format="value(name)" \
61+
# --limit=1)
62+
#SERVICE_ACCOUNT_EMAIL=$(gcloud compute instances describe ${INSTANCE_NAME} \
63+
# --zone us-west1-c \
64+
# --format="value(serviceAccounts.email)")
65+
#gcloud projects add-iam-policy-binding ${PROJECT} \
66+
# --member="serviceAccount:$SERVICE_ACCOUNT_EMAIL" \
67+
# --role="roles/artifactregistry.reader"
6868

6969
echo "✅ Deployment complete! Image: ${IMAGE_URL}"

backend/api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@compass/api",
33
"description": "Backend API endpoints",
4-
"version": "1.0.8",
4+
"version": "1.0.9",
55
"private": true,
66
"scripts": {
77
"watch:serve": "tsx watch src/serve.ts",

0 commit comments

Comments
 (0)