removed AssertCheckResultByLabel and its call cause of dubplication

Author: taimurhafeez

tests/e2e/framework/common.go

@@ -2175,30 +2175,6 @@ func (f *Framework) AssertHasCheck(suiteName, scanName string, check compv1alpha
 
 	return nil
 }
-
-// AssertCheckResultByLabel verifies that a ComplianceCheckResult with the expected name exists
-// when filtering by a specific label selector
-func (f *Framework) AssertCheckResultByLabel(namespace, labelKey, labelValue, expectedCheckName string) error {
-	var checkList compv1alpha1.ComplianceCheckResultList
-	checkListOpts := client.MatchingLabels{
-		labelKey: labelValue,
-	}
-	listOpts := client.InNamespace(namespace)
-
-	if err := f.Client.List(context.TODO(), &checkList, &checkListOpts, &listOpts); err != nil {
-		return fmt.Errorf("failed to list ComplianceCheckResults with label %s=%s: %w", labelKey, labelValue, err)
-	}
-
-	// Check if the expected check name is in the list
-	for _, check := range checkList.Items {
-		if check.Name == expectedCheckName {
-			return nil
-		}
-	}
-
-	return fmt.Errorf("ComplianceCheckResult %s not found in list filtered by label %s=%s", expectedCheckName, labelKey, labelValue)
-}
-
 func (f *Framework) AssertHasRemediations(suiteName, scanName, roleLabel string, remNameList []string) error {
 	var scanSuiteMapNames = make(map[string]bool)
 	var scanSuiteRemediations []compv1alpha1.ComplianceRemediation

tests/e2e/parallel/main_test.go

@@ -983,21 +983,17 @@ func TestScanProducesRemediationsAndLabels(t *testing.T) {
 	}
 	// Use the first check to verify labels are working correctly
 	firstCheck := checkList.Items[0]
-	// Verify all required labels are present and can be queried
-	labelsToVerify := map[string]string{
-		compv1alpha1.SuiteLabel:                         bindingName,
-		compv1alpha1.ComplianceScanLabel:                firstCheck.Labels[compv1alpha1.ComplianceScanLabel],
-		compv1alpha1.ComplianceCheckResultSeverityLabel: firstCheck.Labels[compv1alpha1.ComplianceCheckResultSeverityLabel],
-		compv1alpha1.ComplianceCheckResultStatusLabel:   firstCheck.Labels[compv1alpha1.ComplianceCheckResultStatusLabel],
-	}
-	for label, value := range labelsToVerify {
-		if value == "" {
+	// Verify all required labels are present
+	labelsToVerify := []string{
+		compv1alpha1.SuiteLabel,
+		compv1alpha1.ComplianceScanLabel,
+		compv1alpha1.ComplianceCheckResultSeverityLabel,
+		compv1alpha1.ComplianceCheckResultStatusLabel,
+	}
+	for _, label := range labelsToVerify {
+		if firstCheck.Labels[label] == "" {
 			t.Fatalf("check %s is missing label %s", firstCheck.Name, label)
 		}
-		err = f.AssertCheckResultByLabel(f.OperatorNamespace, label, value, firstCheck.Name)
-		if err != nil {
-			t.Fatal(err)
-		}
 	}
 }