Skip to content

Commit 4c0cf63

Browse files
committed
Use better og images
1 parent 414e7b6 commit 4c0cf63

File tree

2 files changed

+26
-7
lines changed

2 files changed

+26
-7
lines changed

apps/components_guide_web/lib/components_guide_web/controllers/accessibility_first_controller.ex

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,43 @@ defmodule ComponentsGuideWeb.AccessibilityFirstController do
33
require Logger
44

55
def index(conn, _params) do
6-
render(conn, "index.html", article: "intro")
6+
conn
7+
|> assign(:page_title, page_title(nil))
8+
|> render("index.html", article: "intro")
79
end
810

911
def show(conn, %{"id" => "widgets-cheatsheet"}) do
10-
render(conn, "widgets-cheatsheet.html")
12+
conn
13+
|> assign(:page_title, "Accessible Widgets Cheatsheet")
14+
|> render("widgets-cheatsheet.html")
1115
end
1216

1317
def show(conn, %{"id" => "properties-cheatsheet"}) do
14-
render(conn, "properties-cheatsheet.html")
18+
conn
19+
|> assign(:page_title, "Accessible Properties Cheatsheet")
20+
|> render("properties-cheatsheet.html")
1521
end
1622

1723
@articles ["navigation", "landmarks", "roles", "accessible-name", "forms", "content"]
1824

1925
def show(conn, %{"id" => article}) when article in @articles do
20-
render(conn, "index.html", article: article)
26+
conn
27+
|> assign(:page_title, page_title(article))
28+
|> render("index.html", article: article)
2129
end
2230

2331
def show(conn, _params) do
2432
raise Phoenix.Router.NoRouteError, conn: conn, router: ComponentsGuideWeb.Router
2533
end
34+
35+
defp page_title("navigation"), do: "Accessibility-First Navigation"
36+
defp page_title("landmarks"), do: "Accessibility-First Landmarks"
37+
defp page_title("roles"), do: "Accessibility-First Roles"
38+
defp page_title("forms"), do: "Accessibility-First Forms"
39+
defp page_title("content"), do: "Accessibility-First Content"
40+
defp page_title("accessible-name"), do: "Learning Accessible Names"
41+
42+
defp page_title(_) do
43+
"Accessibility-First Development"
44+
end
2645
end

apps/components_guide_web/lib/components_guide_web/templates/layout/root.html.leex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
<%
1313
stamp_query = case assigns[:page_title] do
1414
nil ->
15-
"source=Components.Guide"
15+
[primary: "Components.Guide", secondary: "Learn accessibility, web standards, testing React & more"]
1616

1717
title ->
18-
URI.encode_query(source: "Components.Guide", headline: title)
18+
[primary: "Components.Guide", secondary: title]
1919
end
2020
%>
21-
<meta property="og:image" content="https://stamp.vercel.app/api/poster?<%= stamp_query %>">
21+
<meta property="og:image" content="https://postage-stamp.collected.workers.dev/1/poster?<%= URI.encode_query(stamp_query) %>">
2222

2323
<script defer type="text/javascript" src="<%= Routes.static_path(@conn, "/js/app.js") %>"></script>
2424

0 commit comments

Comments
 (0)