Osmosis DevNet setup, XCVM config/events refactoring, Nix improvements (#3951)

Generally, ensure that setup of storage is easy to do and full of data
to do all possible routing (like Osmosis does, but more general in all
directions and solvers), and using that setup against Osmosis.

So uploaded contracts to Osmosis and initialized.


- separate devnet for cosmos only for faster dev
- aligned config/folders/messages/transports of xcvm on whole stack
- made data folder of dotsama devnet same as cosmos
(/tmp/composable-devnet/)
- updated XCVM spec as per latest state
- added into language, not implemented yet, swap instruction to XCVM
named and modelled with parity XCM (will work on parity, picasso,
osmosis, problem solver)
- tests for assets not compiled, mostly useless and simplistic - removed
instead of fixing (tests will be in DevNet directly via bash)
- generated schema for xcvm
- fixed nix docs/examples to ensure people run properly nix with all
parameters
- fixed memo handling (again, had to cp paste some code
hashedone/serde-cw-value#3) and its integration
with centauri (now they cannot handle wasm, so it skips it )
- disable run of CI in hash tag (i do not want to spam people)
- renamed Multihop XCM IBC some struct as per previos request of
@RustNinja
- updated cosmos.nix deps to latest centauri
- clean up of nix and speed ups builds of nix

Required for merge:
- [x] `pr-workflow-check / draft-release-check` is ✅ success
- Other rules GitHub shows you, or can be read in
[configuration](../terraform/github.com/branches.tf)

Makes review faster:
- [x] PR title is my best effort to provide summary of changes and has
clear text to be part of release notes
- [x] I marked PR by `misc` label if it should not be in release notes
- [x] Linked Zenhub/Github/Slack/etc reference if one exists
https://github.com/ComposableFi/research/issues/249
https://github.com/ComposableFi/research/issues/244
- [x] I was clear on what type of deployment required to release my
changes (node, runtime, contract, indexer, on chain operation, frontend,
infrastructure) if any in PR title or description
- [x] Added reviewer into `Reviewers`
- [x] I tagged(`@`) or used other form of notification of one person who
I think can handle best review of this PR
- [x] I have proved that PR has no general regressions of relevant
features and processes required to release into production
- [x] Any dependency updates made, was done according guides from
relevant dependency
- Clicking all checkboxes 
- Adding detailed description of changes when it feels appropriate (for
example when PR is big)


![image](https://github.com/ComposableFi/composable/assets/757125/8fbcc4fb-ba2a-49f1-9bb9-7c5f258758e7)

Author: dzmitry-lahoda

.github/workflows/pr-workflow-check.yaml

@@ -14,6 +14,7 @@ on:
 
 jobs:
   pr-workflow-check:
+    if: ${{ !contains('#WIP', github.event.pull_request.title) && !contains('#wip', github.event.pull_request.title) }}
     uses: ./.github/workflows/pr-workflow.yml
     with:
       github_event_name: ${{ github.event_name }}

.github/workflows/pull-request-comments.yml

@@ -24,22 +24,22 @@ jobs:
             
             ```shell
             # run Composable node
-            nix run "github:ComposableFi/composable/${{ github.ref }}" --allow-import-from-derivation --print-build-logs --option sandbox relaxed --show-trace --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config 
+            nix run "github:ComposableFi/composable/${{ github.ref }}" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
             ````
 
             ```shell
             # run local Picasso DevNet (for CosmWasm development)
-            nix run "github:ComposableFi/composable/${{ github.ref }}#devnet-picasso" --allow-import-from-derivation --print-build-logs --option sandbox relaxed --show-trace --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config 
+            nix run "github:ComposableFi/composable/${{ github.ref }}#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
             ```
 
             ```shell
             # CosmWasm on Substrate CLI tool
-            nix run "github:ComposableFi/composable/${{ github.ref }}#ccw" --allow-import-from-derivation --print-build-logs --option sandbox relaxed --show-trace --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config 
+            nix run "github:ComposableFi/composable/${{ github.ref }}#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
             ```
 
             ```shell
             # run cross chain devnet with Dotsama and Cosmos nodes 
-            nix run "github:ComposableFi/composable/${{ github.ref }}#devnet-xc-fresh" --allow-import-from-derivation --print-build-logs --option sandbox relaxed --show-trace --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config 
+            nix run "github:ComposableFi/composable/${{ github.ref }}#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
             ```
             
             [About nix](https://docs.composable.finance/nix.html)

Dockerfile

@@ -23,7 +23,7 @@ RUN usermod --append --groups sudo ${USER} --shell /bin/bash && \
     sed --in-place 's/%sudo.*ALL/%sudo   ALL=(ALL:ALL) NOPASSWD:ALL/' /etc/sudoers
 
 RUN mkdir --parents /etc/nix/ && \
-    echo "sandbox = false" >> /etc/nix/nix.conf && \
+    echo "sandbox = relaxed" >> /etc/nix/nix.conf && \
     echo "experimental-features = nix-command flakes" >> /etc/nix/nix.conf && \
     echo "narinfo-cache-negative-ttl = 30" >> /etc/nix/nix.conf  && \
     echo "trusted-users = root vscode" >> /etc/nix/nix.conf  && \

code/Cargo.lock

@@ -134,6 +134,8 @@ pallet-xcm = { git = "https://github.com/paritytech/polkadot", rev = "c22e1c4173
 log = { version = "0.4.14", default-features = false }
 
 ibc-rs-scale = { package = "ibc", git = "https://github.com/dzmitry-lahoda-forks/ibc-rs.git", rev = "c305fb9a7f3750e6daa0d9aefa84d53d64cd4fee", default-features = false }
+ibc-proto = { git = "https://github.com/cosmos/ibc-proto-rs.git", rev = "af385af", default-features = false }
+
 democracy = { package = "pallet-democracy", git = "https://github.com/ComposableFi/substrate", rev = "c74d73bfe1e4f725b3f7d81c997ba9c940bf6005", default-features = false }
 executive = { package = "frame-executive", git = "https://github.com/ComposableFi/substrate", rev = "c74d73bfe1e4f725b3f7d81c997ba9c940bf6005", default-features = false }
 indices = { package = "pallet-indices", git = "https://github.com/ComposableFi/substrate", rev = "c74d73bfe1e4f725b3f7d81c997ba9c940bf6005", default-features = false }
@@ -333,8 +335,10 @@ scale-info = { version = "2.1.1", default-features = false, features = [
 
 schemars = { version = "0.8.12", default-feautes = false }
 
-prost = {version = "0.11.0", default-features = false, features = ["prost-derive"]}
-prost-types = {version = "0.11.1", default-features = false}
+prost = { version = "0.11.0", default-features = false, features = [
+  "prost-derive",
+] }
+prost-types = { version = "0.11.1", default-features = false }
 prost-build = "0.11.9"
 
 
@@ -351,12 +355,17 @@ cosmwasm-vm = { git = "https://github.com/ComposableFi/cosmwasm-vm", rev = "1cc4
 cosmwasm-vm-wasmi = { git = "https://github.com/ComposableFi/cosmwasm-vm", rev = "1cc47415577d67448ff483ad530b889cceafde77", default-features = false }
 cosmwasm-orchestrate = { git = "https://github.com/ComposableFi/cosmwasm-vm", rev = "1cc47415577d67448ff483ad530b889cceafde77" }
 serde-json-wasm = { git = "https://github.com/dzmitry-lahoda-forks/serde-json-wasm", rev = "8a7e522c0e4de36a6dfb535766f26a9941017d81", default-features = false }
-serde-cw-value = { git = "https://github.com/dzmitry-lahoda-forks/serde-cw-value", rev = "fe16466caee886908645de5a8e0518dbac6d98df", default-features = false }
+serde-cw-value = { git = "https://github.com/dzmitry-lahoda-forks/serde-cw-value", rev = "b91ac6d797fd24c00758ad3995a55dc820279595", default-features = false }
 cw-storage-plus = { git = "https://github.com/dzmitry-lahoda-forks/cw-storage-plus", rev = "d0a2cf126cae3e3960c787ebcfc9baa54f59f71c", default-features = false }
-cosmwasm-schema = { git = "https://github.com/dzmitry-lahoda-forks/cosmwasm", rev = "1277597cbf380a8d04dbe676d9cb344ca31634b6", default-features = false}
-cw-utils = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus",  rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false}
-cw20 = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus",  rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false, features = ["std"]}
-cw20-base = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus",  rev = "458e2eb014253d2131219e518c64475a8348c5a3", features = ["library"]}
+cosmwasm-schema = { git = "https://github.com/dzmitry-lahoda-forks/cosmwasm", rev = "1277597cbf380a8d04dbe676d9cb344ca31634b6", default-features = false }
+
+cw-utils = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus", rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false }
+cw20 = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus", rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false, features = [
+  "std",
+] }
+cw20-base = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus", rev = "458e2eb014253d2131219e518c64475a8348c5a3", features = [
+  "library",
+] }
 
 derive_more = { version = "1.0.0-beta.2", default-features = false, features = ["full"] }
 hex = { version = "0.4.3", default-features = false, features = [
@@ -369,7 +378,7 @@ cosmwasm-std = { git = "https://github.com/dzmitry-lahoda-forks/cosmwasm", rev =
   "iterator",
   "cosmwasm_1_2",
 ] }
-cw2 = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus",  rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false}
+cw2 = { git = "https://github.com/dzmitry-lahoda-forks/cw-plus", rev = "458e2eb014253d2131219e518c64475a8348c5a3", default-features = false }
 
 serde = { version = '1.0.136', default-features = false, features = ["derive"] }
 

code/Cargo.toml

@@ -29,9 +29,10 @@
           cargoBuildCommand = "cargo build --release --package ${name}";
           cargoExtraArgs = "--features=builtin-wasm";
           CW_XC_GATEWAY_WASM_PATH =
-            "${self'.packages.xcvm-contracts}/lib/cw_xc_gateway.wasm";
+            "${self'.packages.xc-cw-contracts}/lib/cw_xc_gateway.wasm";
           CW_XC_INTERPRETER_WASM_PATH =
-            "${self'.packages.xcvm-contracts}/lib/cw_xc_interpreter.wasm";
+            "${self'.packages.xc-cw-contracts}/lib/cw_xc_interpreter.wasm";
+          CW_20_BASE_WASM_PATH = self'.packages.cw20_base;
           PICASSO_RUNTIME = "${picasso-runtime}/lib/runtime.optimized.wasm";
           COMPOSABLE_RUNTIME =
             "${composable-runtime}/lib/runtime.optimized.wasm";

code/composable-nodes.nix

@@ -24,7 +24,7 @@ bech32-no_std = { workspace = true, default-features = false, features = [
 ] }
 bitflags = "1.3.2"
 composable-support = { default-features = false, path = "../composable-support" }
-xc-core = { default-features = false, path = "../../../xcvm/lib/core" }
+xc-core = { default-features = false, path = "../../../xcvm/lib/core"}
 plotters = { version = "0.3.1", optional = true }
 scale-info = { version = "2.1.1", default-features = false, features = [
   "derive",
@@ -43,7 +43,7 @@ sha2 = { workspace = true, default-features = false }
 
 schemars = { optional = true, workspace = true, default-features = false }
 
-cosmwasm-schema = { workspace = true, default-features = false, optional = true}
+cosmwasm-schema = { workspace = true, default-features = false, optional = true }
 
 thiserror = { workspace = true, default-features = false }
 

code/parachain/frame/composable-traits/Cargo.toml

@@ -1,24 +1,26 @@
 //! mapping of proper CW/Cosmos enabled types to Centauri
 
 use crate::prelude::*;
-use xc_core::ibc::ics20::MemoData;
+use xc_core::transport::ibc::ics20::Memo;
 
 pub struct Map;
 impl Map {
-	pub fn from_cw(mut value: MemoData) -> pallet_ibc::ics20::MemoData {
-		let next = value.forward.next.take().map(|e| Box::new(Map::from_cw(*e)));
-		let value = value.forward;
-		let forward = pallet_ibc::ics20::Forward {
-			receiver: value.receiver,
-			port: value.port.map(|x| x.to_string()),
-			channel: value.channel.map(|x| x.to_string()),
-			timeout: value.timeout,
-			retries: value.retries.map(Into::into),
-			para_id: value.substrate.and_then(|x| x.para_id),
-			substrate: value.substrate.map(|_| true),
-			next,
-		};
+	pub fn try_from_xc_memo(value: Memo) -> Option<pallet_ibc::ics20::MemoData> {
+		value.forward.map(|value| {
+			let next: Option<Box<pallet_ibc::ics20::MemoData>> =
+				value.next.and_then(|e| Map::try_from_xc_memo(*e)).map(Box::new);
+			let forward = pallet_ibc::ics20::Forward {
+				receiver: value.receiver,
+				port: value.port.map(|x| x.to_string()),
+				channel: value.channel.map(|x| x.to_string()),
+				timeout: value.timeout,
+				retries: value.retries.map(Into::into),
+				para_id: value.substrate.and_then(|x| x.para_id),
+				substrate: Some(value.substrate.is_some()),
+				next,
+			};
 
-		pallet_ibc::ics20::MemoData { forward }
+			pallet_ibc::ics20::MemoData { forward }
+		})
 	}
 }

code/parachain/frame/composable-traits/src/centauri.rs

@@ -49,9 +49,9 @@ pub mod pallet {
 	use ibc_primitives::Timeout as IbcTimeout;
 	use ibc_rs_scale::core::ics24_host::identifier::{ChannelId, PortId};
 	use pallet_ibc::{MultiAddress, TransferParams};
-	use xc_core::ibc::ics20::{
-		pfm::{Forward, IbcSubstrate},
-		MemoData,
+	use xc_core::transport::ibc::ics20::{
+		pfm::{ForwardingMemo, XcmHop},
+		Memo,
 	};
 	use xcm::latest::prelude::*;
 
@@ -331,20 +331,20 @@ pub mod pallet {
 		/// Return Ok(None) if `list_chain_name_address` is empty
 		pub fn create_memo(
 			mut list_chain_name_address: ListChainNameAddress,
-		) -> Result<Option<MemoData>, DispatchError> {
+		) -> Result<Option<Memo>, DispatchError> {
 			list_chain_name_address.reverse(); // reverse to create memo from the end
 
 			//osmosis(ibc) <- huahua(ibc) <- centauri(ibc)  =  ibc transfer from composable to
 			//picasso with memo substrate(xcm) hop can be only the last one
 			//moonriver(xcm) = ibc transfer from composable to picasso
 			//polkadot(xcm) = ibc transfer from picasso to composable
 
-			let mut last_memo_data: Option<MemoData> = None;
+			let mut last_memo_data: Option<Memo> = None;
 
 			for (i, name, address) in list_chain_name_address {
 				let mut forward = if i.chain_hop == ChainHop::Xcm {
 					let memo_receiver = scale_info::prelude::format!("0x{}", hex::encode(address));
-					Forward::new_xcm_memo(memo_receiver, IbcSubstrate::new(i.para_id))
+					ForwardingMemo::new_xcm_memo(memo_receiver, XcmHop::new(i.para_id))
 				} else {
 					let memo_receiver = if i.chain_hop == ChainHop::SubstrateIbc {
 						scale_info::prelude::format!("0x{}", hex::encode(address))
@@ -368,7 +368,7 @@ pub mod pallet {
 						})?
 					};
 
-					Forward::new_ibc_memo(
+					ForwardingMemo::new_ibc_memo(
 						memo_receiver,
 						PortId::transfer(),
 						ChannelId::new(i.channel_id),
@@ -379,7 +379,7 @@ pub mod pallet {
 				if let Some(memo_memo) = last_memo_data {
 					forward.next = Some(Box::new(memo_memo));
 				};
-				let new_memo = MemoData::forward(forward);
+				let new_memo = Memo::forward(forward);
 				last_memo_data = Some(new_memo);
 			}
 			Ok(last_memo_data)
@@ -684,8 +684,9 @@ pub mod pallet {
 				return None;
 			};
 			if let Some(memo_data) = memo_data {
-				let memo_result =
-					<T as pallet_ibc::Config>::MemoMessage::try_from(Map::from_cw(memo_data));
+				let memo_result = <T as pallet_ibc::Config>::MemoMessage::try_from(
+					Map::try_from_xc_memo(memo_data)?,
+				);
 
 				let Ok(memo_result) = memo_result else{
 						<Pallet<T>>::deposit_event(crate::Event::<T>::FailedCallback {

code/parachain/frame/pallet-multihop-xcm-ibc/src/lib.rs

@@ -1,4 +1,4 @@
-use sp_core::{ConstU32};
+use sp_core::ConstU32;
 use sp_runtime::BoundedBTreeMap;
 use subxt::utils::AccountId32;