Fix Sonar

Author: ComputerDaddyGuy

src/main/java/io/github/computerdaddyguy/jfiletreeprettyprinter/cli/exception/DefaultExecutionExceptionHandler.java

@@ -3,6 +3,7 @@
 import io.github.computerdaddyguy.jfiletreeprettyprinter.cli.io.ConsoleOutput;
 import jakarta.validation.ConstraintViolationException;
 import java.util.Objects;
+import java.util.stream.Collectors;
 import org.jspecify.annotations.NullMarked;
 import picocli.CommandLine;
 import picocli.CommandLine.IExecutionExceptionHandler;
@@ -28,12 +29,16 @@ public int handleExecutionException(Exception ex, CommandLine commandLine, Parse
 
 	private int handleExternalOptionsException(ExternalOptionsException e) {
 		output.printError(e.getMessage() + ": " + e.getOptionsPath().toString());
-		e.printStackTrace();
 		return 1;
 	}
 
 	private int handleConstraintViolationException(ConstraintViolationException e) {
-		output.printError(e.getMessage() + ": TODO");
+		output.printError(
+			"Invalid options file:" + System.lineSeparator() +
+				e.getConstraintViolations().stream()
+					.map(violation -> "  -> " + violation.getPropertyPath() + ": " + violation.getMessage())
+					.collect(Collectors.joining(System.lineSeparator()))
+		);
 		return 1;
 	}
 

src/main/java/io/github/computerdaddyguy/jfiletreeprettyprinter/cli/options/reader/SimpleExternalOptionsReader.java

@@ -45,7 +45,8 @@ public ExternalOptions readExternalOptions(Path targetPath, @Nullable Path optio
 		output.printDebug("Options file found: %s", optionsPath);
 
 		var externalOptions = load(output, optionsPath);
-		validate(output, optionsPath, externalOptions);
+		validate(externalOptions);
+		output.printDebug("Options file is valid");
 		return externalOptions;
 	}
 
@@ -63,23 +64,18 @@ private ExternalOptions load(ConsoleOutput output, Path optionsPath) {
 		}
 	}
 
-	private void validate(ConsoleOutput output, Path optionsPath, ExternalOptions externalOptions) {
-		try {
-			var validatorFactory = Validation.byDefaultProvider()
-				.configure()
-				.messageInterpolator(new ParameterMessageInterpolator())
-				.buildValidatorFactory();
-			var validator = validatorFactory.getValidator();
-
-			var violations = validator.validate(externalOptions);
-			if (!violations.isEmpty()) {
-				throw new ConstraintViolationException(violations);
-			}
+	private void validate(ExternalOptions externalOptions) {
+		var validatorFactory = Validation.byDefaultProvider()
+			.configure()
+			.messageInterpolator(new ParameterMessageInterpolator())
+			.buildValidatorFactory();
+		var validator = validatorFactory.getValidator();
 
-			output.printDebug("Options file is valid");
-		} catch (ConstraintViolationException e) {
-			throw new ExternalOptionsException(optionsPath, "Invalid options file", e);
+		var violations = validator.validate(externalOptions);
+		if (!violations.isEmpty()) {
+			throw new ConstraintViolationException(violations);
 		}
+
 	}
 
 }

src/test/java/io/github/computerdaddyguy/jfiletreeprettyprinter/cli/FileTreePrettyPrinterCommandLineTest.java

@@ -105,7 +105,10 @@ void invalid_options() throws IOException {
 		var exHandler = new DefaultExecutionExceptionHandler(output);
 		var cli = new FileTreePrettyPrinterCommandLine(output, optionsLoader, exHandler);
 
-		Consumer<String> outputAssertor = out -> assertThat(out).startsWith("[ERROR] Invalid options file:").contains("invalid.yaml");
+		Consumer<String> outputAssertor = out -> assertThat(out)
+			.startsWith("[ERROR] Invalid options file:")
+			.contains("childLimit.limits[0].matcher.glob:")
+			.contains("childLimit.limits[1].matcher.glob:");
 		runErrorTest(cli, args, outputAssertor);
 	}
 

src/test/resources/cli/options/invalid.yaml

@@ -1,2 +1,11 @@
 childLimit:
-  type: static
+  type: dynamic
+  limits:
+  - limit: 2
+    matcher:
+      type: "name"
+      glob: ""
+  - limit: 3
+    matcher:
+      type: "name"
+      glob: ""