Skip to content

Commit 4a2e55f

Browse files
authored
Merge pull request #366 from ComputerScienceHouse/develop
dev -> main
2 parents c2a9f45 + 2b374b1 commit 4a2e55f

File tree

3 files changed

+7
-20
lines changed

3 files changed

+7
-20
lines changed

Dockerfile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,20 @@
11
FROM docker.io/jekyll/builder as builder
2-
32
RUN gem install bundler:2.2.3
4-
53
RUN mkdir /site; \
64
chown -R jekyll:jekyll /site
75
WORKDIR /site
8-
96
COPY Gemfile Gemfile.lock /site/
107
RUN bundle install
11-
128
COPY . /site/
13-
149
RUN bundle exec rake build:production
1510

1611
FROM docker.io/httpd:2.4
17-
1812
RUN apt update && apt install -y sssd
19-
2013
RUN rm -rf /usr/local/apache2/htdocs/*
2114
COPY --from=builder /site/_site/ /usr/local/apache2/htdocs/
2215
COPY httpd-suffix.conf httpd-suffix.conf
2316
RUN cat httpd-suffix.conf >> /usr/local/apache2/conf/httpd.conf
2417
COPY entrypoint.sh /entrypoint.sh
18+
EXPOSE 80
2519
ENTRYPOINT ["/usr/bin/bash", "/entrypoint.sh"]
2620
CMD ["httpd-foreground"]

README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,16 @@ This site is written using [Jekyll](https://jekyllrb.com/), a static site genera
88

99
## Local Development
1010

11-
#### Prerequisites:
12-
1. [Ruby](https://www.ruby-lang.org/en/documentation/installation/)
13-
2. [Bundler](https://bundler.io/) (`gem install bundler`)
11+
Build the container: `docker build -t cshpublicsite .`
12+
Run the container: `docker run -p 4000:80 cshpublicsite`
13+
You will be able to access the site at http://localhost:4000.
1414

15-
#### Instructions
16-
1. `bundle install`
17-
2. Add necessary environment variables (they MUST be defined!!!):
18-
* `export CSHPUBSITE_ASSETS_URL="https://assets.csh.rit.edu/pubsite"`
19-
* `export CSHPUBSITE_S3_URL="https://s3.csh.rit.edu"`
20-
3. `bundle exec jekyll serve`
21-
22-
The site should now serve locally at `localhost:4000`, and auto-build when you change/create files in the repo!
15+
You can either edit files in the container, or rebuild the container when you want to test changes.
2316

2417
## Contributing
2518

2619
1. [Fork](https://help.github.com/en/articles/fork-a-repo) this repository
27-
- Optionally create a new [git branch](https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell) if your change is more than a small tweak (`git checkout -b BRANCH-NAME-HERE`)
20+
- Create a new [git branch](https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell) if your change is more than a small tweak (`git checkout -b BRANCH-NAME-HERE`)
2821
3. Make your changes locally, commit, and push to your fork
2922
4. Create a [Pull Request](https://help.github.com/en/articles/about-pull-requests) on this repo for our Webmasters to review
3023

about/eboard.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ <h3>Isaac Ingram</h3>
8282
</div>
8383
<div class="col-12 col-lg-9">
8484
<h2 class="header">House History</h2>
85-
<h3>Sam Cordry</h3>
85+
<h3>Logan Endes</h3>
8686
<p class="long-form">
8787
The primary responsibility of the History director is keeping the line of communication between CSH
8888
and our alumni open.

0 commit comments

Comments
 (0)