fix boolean handling (python is the worst language and truthiness is fake)

Qelxiros · Qelxiros · commit 41b911278ce1 · 2025-10-21T16:51:02.000-04:00
diff --git a/conditional/util/member.py b/conditional/util/member.py
@@ -201,7 +201,7 @@ def gatekeep_status(username):
         )
         .filter(
             MemberCommitteeAttendance.uid == username,
-            CommitteeMeeting.approved is True,
+            bool(CommitteeMeeting.approved),
             CommitteeMeeting.timestamp >= semester_start,
         )
         .count()
@@ -214,7 +214,7 @@ def gatekeep_status(username):
         )
         .filter(
             MemberSeminarAttendance.uid == username,
-            TechnicalSeminar.approved is True,
+            bool(TechnicalSeminar.approved),
             TechnicalSeminar.timestamp >= semester_start,
         )
         .count()

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ def gatekeep_status(username):`
`201`	`201`	`)`
`202`	`202`	`.filter(`
`203`	`203`	`MemberCommitteeAttendance.uid == username,`
`204`		`- CommitteeMeeting.approved is True,`
	`204`	`+ bool(CommitteeMeeting.approved),`
`205`	`205`	`CommitteeMeeting.timestamp >= semester_start,`
`206`	`206`	`)`
`207`	`207`	`.count()`
`@@ -214,7 +214,7 @@ def gatekeep_status(username):`
`214`	`214`	`)`
`215`	`215`	`.filter(`
`216`	`216`	`MemberSeminarAttendance.uid == username,`
`217`		`- TechnicalSeminar.approved is True,`
	`217`	`+ bool(TechnicalSeminar.approved),`
`218`	`218`	`TechnicalSeminar.timestamp >= semester_start,`
`219`	`219`	`)`
`220`	`220`	`.count()`