fix linting errors

Author: liam-middlebrook

conditional/blueprints/attendance.py

@@ -91,8 +91,8 @@ def get_non_alumni_non_coop(internal=False):
 
     if internal:
         return eligible_members
-    else:
-        return jsonify({'members': eligible_members}), 200
+
+    return jsonify({'members': eligible_members}), 200
 
 
 @attendance_bp.route('/attendance/cm_members')
@@ -314,15 +314,15 @@ def alter_house_attendance(uid, hid):
         member_meeting.attendance_status = "Attended"
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        freshman_meeting = FreshmanHouseMeetingAttendance.query.filter(
-            FreshmanHouseMeetingAttendance.fid == uid,
-            FreshmanHouseMeetingAttendance.meeting_id == hid
-        ).first()
 
-        freshman_meeting.attendance_status = "Attended"
-        db.session.commit()
-        return jsonify({"success": True}), 200
+    freshman_meeting = FreshmanHouseMeetingAttendance.query.filter(
+        FreshmanHouseMeetingAttendance.fid == uid,
+        FreshmanHouseMeetingAttendance.meeting_id == hid
+    ).first()
+
+    freshman_meeting.attendance_status = "Attended"
+    db.session.commit()
+    return jsonify({"success": True}), 200
 
 
 @attendance_bp.route('/attendance/alter/hm/<uid>/<hid>', methods=['POST'])

conditional/blueprints/conditional.py

@@ -117,5 +117,5 @@ def conditional_delete(cid):
         db.session.flush()
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        return "Must be evals director to delete!", 401
+
+    return "Must be evals director to delete!", 401

conditional/blueprints/intro_evals.py

@@ -165,9 +165,9 @@ def get_fid_cm_count(member_id):
 
     if internal:
         return ie_members
-    else:
-        # return names in 'first last (username)' format
-        return render_template(request,
-                               'intro_evals.html',
-                               username=user_name,
-                               members=ie_members)
+
+    # return names in 'first last (username)' format
+    return render_template(request,
+                           'intro_evals.html',
+                           username=user_name,
+                           members=ie_members)

conditional/blueprints/major_project_submission.py

@@ -121,5 +121,5 @@ def major_project_delete(pid):
         db.session.flush()
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        return "Must be project owner to delete!", 401
+
+    return "Must be project owner to delete!", 401

conditional/blueprints/member_management.py

@@ -373,13 +373,13 @@ def get_hm_date(hm_id):
                 'missed_hm': hms_missed,
                 'user': 'eval'
             }), 200
-    else:
-        return jsonify(
-            {
-                'name': account.cn,
-                'active_member': ldap_is_active(account),
-                'user': 'financial'
-            }), 200
+
+    return jsonify(
+        {
+            'name': account.cn,
+            'active_member': ldap_is_active(account),
+            'user': 'financial'
+        }), 200
 
 
 @member_management_bp.route('/manage/user/<fid>', methods=['DELETE'])

conditional/blueprints/spring_evals.py

@@ -113,8 +113,8 @@ def get_cm_count(member_id):
     # return names in 'first last (username)' format
     if internal:
         return sp_members
-    else:
-        return render_template(request,
-                               'spring_evals.html',
-                               username=user_name,
-                               members=sp_members)
+
+    return render_template(request,
+                           'spring_evals.html',
+                           username=user_name,
+                           members=sp_members)

frontend/javascript/app.js

@@ -5,8 +5,8 @@ Raven
     .install();
 
 // Capture unhandled exceptions in promises
-window.addEventListener('unhandledrejection', (err) => {
-    Raven.captureException(err.reason);
+window.addEventListener('unhandledrejection', err => {
+  Raven.captureException(err.reason);
 });
 
 // Load the rest of the modules

frontend/javascript/modules/errorReport.js

@@ -1,19 +1,19 @@
 import Raven from 'raven-js';
 
 export default class ErrorReport {
-    constructor(btn) {
-        this.btn = btn;
-        this.eventId = this.btn.dataset.event;
-        this.render();
-    }
-    
-    render() {
-        this.btn.addEventListener('click', () => this._invokeRavenModal());
-    }
-    
-    _invokeRavenModal() {
-        Raven.showReportDialog({
-            eventId: this.eventId
-        });
-    }
+  constructor(btn) {
+    this.btn = btn;
+    this.eventId = this.btn.dataset.event;
+    this.render();
+  }
+
+  render() {
+    this.btn.addEventListener('click', () => this._invokeRavenModal());
+  }
+
+  _invokeRavenModal() {
+    Raven.showReportDialog({
+      eventId: this.eventId
+    });
+  }
 }