Skip to content

Commit 1ddcc51

Browse files
authored
Merge pull request #52 from devinmatte/ui_and_mobile
Compacting buttons, Fixing links, adding more icon support
2 parents ea89ca7 + 207c048 commit 1ddcc51

File tree

7 files changed

+43
-20
lines changed

7 files changed

+43
-20
lines changed
Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1-
.sign-packet {
2-
float: right;
3-
text-align: right;
4-
}
1+
button {
2+
&.sign-packet {
3+
float: right;
4+
text-align: right;
5+
}
6+
7+
&.sign-button {
8+
float: right;
9+
}
510

6-
.sign-button {
7-
float: right;
11+
&.signed-button {
12+
float: right;
13+
}
814
}

gulpfile.js/tasks/favicon.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ gulp.task('generate-favicon', function(done) {
2929
desktopBrowser: {},
3030
windows: {
3131
pictureAspect: 'whiteSilhouette',
32-
backgroundColor: '#9f00a7',
32+
backgroundColor: '#b0197e',
3333
onConflict: 'override',
3434
assets: {
3535
windows80Ie10Tile: true,
@@ -43,7 +43,7 @@ gulp.task('generate-favicon', function(done) {
4343
},
4444
androidChrome: {
4545
pictureAspect: 'noChange',
46-
themeColor: '#222222',
46+
themeColor: '#b0197e',
4747
manifest: {
4848
display: 'standalone',
4949
orientation: 'notSet',
@@ -57,7 +57,7 @@ gulp.task('generate-favicon', function(done) {
5757
},
5858
safariPinnedTab: {
5959
pictureAspect: 'silhouette',
60-
themeColor: '#222222'
60+
themeColor: '#b0197e'
6161
}
6262
},
6363
settings: {

packet/routes/shared.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,20 @@
11
from datetime import datetime
22
from itertools import chain
33

4-
from flask import render_template
4+
from flask import render_template, redirect
55

66
from packet import auth, app
77
from packet.models import Freshman, Packet
88
from packet.packet import get_signatures, get_number_required, get_number_signed, get_upperclassmen_percent
99
from packet.utils import before_request, signed_packet
1010

1111

12+
@app.route('/logout')
13+
@auth.oidc_logout
14+
def logout():
15+
return redirect("/")
16+
17+
1218
@app.route("/packet/<uid>")
1319
@auth.oidc_auth
1420
@before_request

packet/templates/active_packets.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ <h3 class="page-title">Active Packets</h3>
4646
{% if (info.onfloor and info.uid != packet.freshman.rit_username) or info.realm == "csh" %}
4747
<td class="sign-packet" align="right">
4848
{% if not packet.did_sign %}
49-
<button class="btn btn-primary sign-button"
49+
<button class="btn btn-sm btn-primary sign-button"
5050
data-freshman_uid="{{ packet.freshman.rit_username }}"
5151
data-freshman_name="{{ packet.freshman.name }}">
5252
Sign
5353
</button>
5454
{% else %}
55-
<button class="btn btn-primary" disabled="disabled"><i
55+
<button class="btn btn-sm btn-primary signed-button" disabled="disabled"><i
5656
class="fa fa-check"></i>&nbsp;Signed
5757
</button>
5858
{% endif %}

packet/templates/include/head.html

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,22 @@
88
<title>CSH Packet</title>
99

1010
<link rel="manifest" href="/static/manifest.json">
11+
<meta name="theme-color" content="#b0197e">
1112
<meta name="theme-color" href="https://themeswitcher.csh.rit.edu/api/colour">
13+
14+
<!-- Icons -->
1215
<link rel="shortcut icon" href="{{ url_for('static', filename='favicon.ico') }}">
1316

17+
<link rel="apple-touch-icon" sizes="180x180" href="{{ url_for('static', filename='apple-touch-icon.png') }}">
18+
<link rel="icon" type="image/png" sizes="32x32" href="{{ url_for('static', filename='favicon-32x32.png') }}">
19+
<link rel="icon" type="image/png" sizes="16x16" href="{{ url_for('static', filename='favicon-16x16.png') }}">
20+
21+
<meta name="msapplication-TileColor" content="#b0197e">
22+
<meta name="msapplication-TileImage" content="{{ url_for('static', filename='mstile-144x144.png') }}">
23+
<meta name="msapplication-config" content="{{ url_for('static', filename='browserconfig.xml') }}">
24+
25+
<link rel="mask-icon" href="{{ url_for('static', filename='assets/logo.svg') }}" color="#b0197e">
26+
1427
<link rel="stylesheet" type="text/css"
1528
href="https://cdn.datatables.net/rowgroup/1.0.2/css/rowGroup.dataTables.min.css">
1629
<link rel="stylesheet" type="text/css" href="https://cdn.datatables.net/1.10.16/css/dataTables.bootstrap4.min.css">
@@ -20,12 +33,10 @@
2033
integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
2134
<link rel="stylesheet" href="https://themeswitcher.csh.rit.edu/api/get" media="screen">
2235

23-
<link href="https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.6-rc.0/css/select2.min.css" rel="stylesheet"/>
24-
2536
<script src="https://unpkg.com/sweetalert/dist/sweetalert.min.js"></script>
2637

2738
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/all.css" integrity="sha384-mzrmE5qonljUremFsqc01SB46JvROS7bZs3IO2EmfFsd15uHvIt+Y8vEf7N7fWAU" crossorigin="anonymous">
2839

29-
<link rel="stylesheet" href="/static/css/packet.css">
40+
<link rel="stylesheet" href="/static/css/packet.min.css">
3041

3142
</head>

packet/templates/include/nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<div class="dropdown-menu" aria-labelledby="user01">
3434
<input id="userInfo" hidden value="{{ info.uid }}">
3535
{% if info.realm == "csh" %}
36-
<a class="dropdown-item" href="/">Profile</a>
36+
<a class="dropdown-item" href="https://profiles.csh.rit.edu/">Profile</a>
3737
<a class="dropdown-item" href="https://themeswitcher.csh.rit.edu/">Theme</a>
3838
<div class="dropdown-divider"></div>
3939
{% endif %}

packet/templates/packet.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ <h3>{{ freshman.name }}</h3>
1515
data-freshman_name="{{ freshman.name }}">Sign
1616
</button>
1717
{% else %}
18-
<button class="btn btn-primary" disabled="disabled"><i
18+
<button class="btn btn-primary signed-button" disabled="disabled"><i
1919
class="fa fa-check"></i>&nbsp;Signed
2020
</button>
2121
{% endif %}
@@ -52,7 +52,7 @@ <h5>Upperclassmen Score</h5>
5252
</div>
5353
<div id="eval-blocks">
5454
<div id="eval-table">
55-
<div class="card mb-3">
55+
<div class="card mb-2">
5656
<div class="card-header">
5757
<b>EBoard Signatures</b>
5858
<b class="signature-count">{{ signed_dict.eboard }}/{{ signatures.eboard.count() }}</b>
@@ -178,8 +178,8 @@ <h5>Upperclassmen Score</h5>
178178
<tbody>
179179
{% for m in signatures.misc %}
180180
<tr {% if m.signed %}style="background-color: #4caf505e" {% endif %}>
181-
<td width="5%">
182-
{{ loop.index }}.&nbsp;
181+
<td width="3%">
182+
{{ loop.index }}.
183183
</td>
184184
<td>
185185
{% if info.realm == "csh" %}

0 commit comments

Comments
 (0)