Skip to content

Commit 2a54c87

Browse files
committed
Adding all members and ebaord to page
1 parent 8e7020a commit 2a54c87

File tree

5 files changed

+62
-8
lines changed

5 files changed

+62
-8
lines changed

frontend/scss/components/_datatables.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,9 @@ div {
2727
width: 100%;
2828
}
2929
}
30+
31+
.eval-blocks {
32+
margin-bottom: 30px;
33+
}
3034
}
35+

packet/ldap.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,19 @@ def ldap_get_eboard():
8585
) + _ldap_get_group_members("eboard-financial") + _ldap_get_group_members("eboard-history"
8686
) + _ldap_get_group_members("eboard-imps") + _ldap_get_group_members("eboard-opcomm"
8787
) + _ldap_get_group_members("eboard-research") + _ldap_get_group_members("eboard-social"
88-
) + _ldap_get_group_members("eboard-secretary")
88+
) + _ldap_get_group_members("eboard-secretary") + _ldap_get_group_members("eboard-pr")
8989

9090
return members
9191

9292

93+
def ldap_get_live_onfloor():
94+
members = []
95+
onfloor = ldap_get_onfloor_members()
96+
for member in onfloor:
97+
if ldap_get_roomnumber(member) and not ldap_is_eboard(member):
98+
members.append(member)
99+
return members
100+
93101
# Status checkers
94102

95103
def ldap_is_active(account):
@@ -155,4 +163,4 @@ def ldap_get_roomnumber(account):
155163
try:
156164
return account.roomNumber
157165
except AttributeError:
158-
return ""
166+
return None

packet/models.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@
1111
# The required number of off-floor and alumni signatures
1212
REQUIRED_MISC_SIGNATURES = 15
1313

14+
1415
def end_date():
1516
return datetime.now() + timedelta(days=14)
1617

18+
1719
class Freshman(db.Model):
1820
__tablename__ = "freshman"
1921
rit_username = Column(String(10), primary_key=True)
@@ -29,15 +31,16 @@ def current_packet(self):
2931
"""
3032
return self.packets[0]
3133

34+
3235
class Packet(db.Model):
3336
__tablename__ = "packet"
3437
id = Column(Integer, primary_key=True, autoincrement=True)
3538
freshman_username = Column(ForeignKey("freshman.rit_username"))
3639
start = Column(DateTime, default=datetime.now, nullable=False)
3740
end = Column(DateTime, default=end_date, nullable=False)
38-
info_eboard = Column(Text, nullable=True) # Used to fulfil the eboard description requirement
39-
info_events = Column(Text, nullable=True) # Used to fulfil the events list requirement
40-
info_achieve = Column(Text, nullable=True) # Used to fulfil the technical achievements list requirement
41+
info_eboard = Column(Text, nullable=True) # Used to fulfil the eboard description requirement
42+
info_events = Column(Text, nullable=True) # Used to fulfil the events list requirement
43+
info_achieve = Column(Text, nullable=True) # Used to fulfil the technical achievements list requirement
4144

4245
freshman = relationship("Freshman", back_populates="packets")
4346
upper_signatures = relationship("UpperSignature")
@@ -60,6 +63,7 @@ def signatures_received(self):
6063

6164
return upper_count + fresh_count + misc_count
6265

66+
6367
class UpperSignature(db.Model):
6468
__tablename__ = "signature_upper"
6569
packet_id = Column(Integer, ForeignKey("packet.id"), primary_key=True)
@@ -70,6 +74,7 @@ class UpperSignature(db.Model):
7074

7175
packet = relationship("Packet", back_populates="upper_signatures")
7276

77+
7378
class FreshSignature(db.Model):
7479
__tablename__ = "signature_fresh"
7580
packet_id = Column(Integer, ForeignKey("packet.id"), primary_key=True)
@@ -79,6 +84,7 @@ class FreshSignature(db.Model):
7984

8085
packet = relationship("Packet", back_populates="fresh_signatures")
8186

87+
8288
class MiscSignature(db.Model):
8389
__tablename__ = "signature_misc"
8490
packet_id = Column(Integer, ForeignKey("packet.id"), primary_key=True)

packet/routes.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from packet.utils import before_request
99
from . import auth, app
1010
from .models import Freshman
11-
from .ldap import ldap_get_eboard
11+
from .ldap import ldap_get_live_onfloor, ldap_get_eboard
1212

1313

1414
@app.route("/")
@@ -34,8 +34,9 @@ def index(info=None):
3434
@auth.oidc_auth
3535
@before_request
3636
def freshman_packet(uid, info=None):
37+
onfloor = ldap_get_live_onfloor()
3738
eboard = ldap_get_eboard()
38-
return render_template("packet.html", info=info, eboard=eboard, uid=uid)
39+
return render_template("packet.html", info=info, eboard=eboard, onfloor=onfloor, uid=uid)
3940

4041

4142
@app.route("/csh-auth/")

packet/templates/packet.html

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ <h3 class="page-title">Packet Name</h3>
99
</div>
1010
<div id="eval-blocks">
1111
<div id="eval-table">
12-
<div class="card">
12+
<div class="card mb-3">
1313
<div class="card-body table-fill">
1414
<div class="card-body table-fill">
1515
<div class="table-responsive">
@@ -43,6 +43,40 @@ <h3 class="page-title">Packet Name</h3>
4343
</div>
4444
</div>
4545
</div>
46+
<div class="card mb-3">
47+
<div class="card-body table-fill">
48+
<div class="card-body table-fill">
49+
<div class="table-responsive">
50+
<table class="table table-striped no-bottom-margin" data-module="table"
51+
data-searchable="true" data-sort-column="3" data-sort-order="asc"
52+
data-length-changable="true" data-paginated="false">
53+
<thead>
54+
<tr>
55+
<th>Name</th>
56+
<th>Signature</th>
57+
</tr>
58+
</thead>
59+
<tbody>
60+
{% for m in onfloor %}
61+
<tr>
62+
<td>
63+
<img class="eval-user-img" alt="{{ m['uid'] }}"
64+
src="https://profiles.csh.rit.edu/image/{{ m['uid'] }}"
65+
width="30"
66+
height="30"/> {{ m['name'] }}
67+
</td>
68+
<td>
69+
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span>
70+
{{ m['signed'] }}
71+
</td>
72+
</tr>
73+
{% endfor %}
74+
</tbody>
75+
</table>
76+
</div>
77+
</div>
78+
</div>
79+
</div>
4680
</div>
4781
</div>
4882
</div>

0 commit comments

Comments
 (0)