Restore pylint

Author: Will-Hellinger

.dockerignore

@@ -7,3 +7,4 @@ __pycache__/
 .venv/
 .scannerwork/
 .ruff_cache/
+.devcontainer/

.github/workflows/python-app.yml

@@ -29,9 +29,10 @@ jobs:
         run: |
           python -m pip install uv
           if [ -f requirements.txt ]; then uv pip install -r requirements.txt --system; fi
-      - name: Lint with ruff
+      - name: Lint with ruff and pylint
         run: |
           ruff check packet
+          pylint packet/routes packet
 
   typecheck:
     runs-on: ubuntu-latest

.pylintrc

@@ -0,0 +1,98 @@
+[MASTER]
+ignore = ,input
+persistent = yes
+load-plugins = pylint_quotes
+
+[MESSAGES CONTROL]
+disable =
+    missing-docstring,
+	fixme,
+	duplicate-code,
+	no-member,
+	parse-error,
+	bad-continuation,
+	too-few-public-methods,
+	global-statement,
+	cyclic-import,
+	locally-disabled,
+	file-ignored,
+	no-else-return,
+	unnecessary-lambda
+
+[REPORTS]
+output-format = text
+files-output = no
+reports = no
+
+[FORMAT]
+max-line-length = 120
+max-statement-lines = 75
+single-line-if-stmt = no
+no-space-check = trailing-comma,dict-separator
+max-module-lines = 1000
+indent-string = '    '
+string-quote=single-avoid-escape
+triple-quote=single
+docstring-quote=double
+
+[MISCELLANEOUS]
+notes = FIXME,XXX,TODO
+
+[SIMILARITIES]
+min-similarity-lines = 4
+ignore-comments = yes
+ignore-docstrings = yes
+ignore-imports = no
+
+[BASIC]
+# Regular expression which should only match correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression which should only match correct module level names
+const-rgx=(([A-Za-z_][A-Za-z1-9_]*)|(__.*__))$
+
+# Regular expression which should only match correct class names
+class-rgx=[A-Z_][a-zA-Z0-9_]+$
+
+# Regular expression which should only match correct function names
+function-rgx=[a-z_][a-z0-9_]{2,35}$
+
+# Regular expression which should only match correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match correct instance attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match correct argument names
+argument-rgx=[a-z_][a-z0-9_]{0,30}$
+
+# Regular expression which should only match correct variable names
+variable-rgx=[a-z_][a-z0-9_]{0,30}$
+
+# Regular expression which should only match correct list comprehension /
+# generator expression variable names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=logger,id,ID
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=apply,input
+
+[DESIGN]
+max-args = 10
+ignored-argument-names = _.*
+max-locals = 20
+max-returns = 6
+max-branches = 15
+max-statements = 55
+max-parents = 7
+max-attributes = 10
+min-public-methods = 2
+max-public-methods = 20
+
+[EXCEPTIONS]
+overgeneral-exceptions = builtins.Exception

README.md

@@ -133,12 +133,13 @@ All DB commands are from the `Flask-Migrate` library and are used to configure D
 docs [here](https://flask-migrate.readthedocs.io/en/latest/) for details. 
 
 ## Code standards
-This project is configured to use ruff and mypy. Commits will be ruffed and typechecked by GitHub actions and if the
+This project is configured to use ruff, pylint, and mypy. Commits will be ruffed, pylinted, and typechecked by GitHub actions and if the
 score drops your build will fail blocking you from merging. To make your life easier just run it before making a PR.
 
-To run ruff and mypy use these commands:
+To run ruff, pylint, and mypy use these commands:
 ```bash
 ruff check packet
+pylint packet/routes packet
 mypy --disable-error-code import --disable-error-code name-defined --disallow-untyped-defs --exclude routes packet
 ```
 

gulpfile.js/index.js

@@ -20,4 +20,4 @@ requireDir('./tasks', {recurse: true});
 // Default task
 gulp.task('default', gulp.parallel('css', 'js'));
 gulp.task('production', gulp.parallel('css', 'js', 'generate-favicon'));
-gulp.task('lint', gulp.parallel('ruff'));
+gulp.task('lint', gulp.parallel('ruff', 'pylint'));

gulpfile.js/tasks/pylint.js

@@ -0,0 +1,12 @@
+const gulp = require('gulp');
+const exec = require('child_process').exec;
+
+let pylintTask = (cb) => {
+    exec('pylint --load-plugins pylint_quotes packet/routes packet', function (err, stdout, stderr) {
+        console.log(stdout);
+        console.log(stderr);
+        cb(err);
+    });
+};
+
+gulp.task('pylint', pylintTask);

requirements.in

@@ -3,14 +3,15 @@ Flask-Mail==0.10.0
 Flask-Migrate~=2.7.0
 Flask-pyoidc~=3.7.0
 Flask~=1.1.4
-csh-ldap @ git+https://github.com/costowell/csh_ldap.git@v2.5.0
+csh-ldap @ git+https://github.com/ComputerScienceHouse/csh_ldap.git@2.5.0
 ddtrace==3.12.2
 flask_sqlalchemy~=2.5.1
 gunicorn~=20.0.4
 mypy==1.17.1
 onesignal-sdk~=1.0.0
 psycopg2-binary~=2.9.3
 ruff==0.12.11
+pylint==3.3.8
 sentry-sdk~=1.5.12
 sqlalchemy[mypy]~=1.4.31
 

requirements.txt

@@ -2,12 +2,14 @@
 # This file is autogenerated by pip-compile with Python 3.12
 # by the following command:
 #
-#    pip-compile --cert=None --client-cert=None --index-url=None --pip-args=None '.\requirements.in'
+#    pip-compile --cert=None --client-cert=None --index-url=None --pip-args=None requirements.in
 #
 alembic==1.16.4
     # via flask-migrate
 annotated-types==0.7.0
     # via pydantic
+astroid==3.3.11
+    # via pylint
 blinker==1.9.0
     # via flask-mail
 bytecode==0.16.2
@@ -26,12 +28,14 @@ click==7.1.2
     #   pip-tools
 cryptography==45.0.6
     # via oic
-csh-ldap @ git+https://github.com/costowell/csh_ldap.git@v2.5.0
+csh-ldap @ git+https://github.com/ComputerScienceHouse/csh_ldap.git@2.5.0
     # via -r requirements.in
 ddtrace==3.12.2
     # via -r requirements.in
 defusedxml==0.7.1
     # via oic
+dill==0.4.0
+    # via pylint
 dnspython==2.7.0
     # via srvlookup
 envier==0.6.1
@@ -68,6 +72,8 @@ importlib-metadata==8.7.0
     # via opentelemetry-api
 importlib-resources==6.5.2
     # via flask-pyoidc
+isort==6.0.1
+    # via pylint
 itsdangerous==1.1.0
     # via flask
 jinja2==2.11.3
@@ -81,6 +87,8 @@ markupsafe==2.0.1
     #   -r requirements.in
     #   jinja2
     #   mako
+mccabe==0.7.0
+    # via pylint
 mypy==1.17.1
     # via
     #   -r requirements.in
@@ -99,6 +107,8 @@ pep517==0.13.1
     # via pip-tools
 pip-tools==6.6.2
     # via -r requirements.in
+platformdirs==4.4.0
+    # via pylint
 protobuf==6.32.0
     # via ddtrace
 psycopg2-binary==2.9.10
@@ -123,6 +133,8 @@ pydantic-settings==2.10.1
     # via oic
 pyjwkest==1.4.2
     # via oic
+pylint==3.3.8
+    # via -r requirements.in
 python-dotenv==1.1.1
     # via pydantic-settings
 python-ldap==3.4.4
@@ -148,6 +160,8 @@ sqlalchemy2-stubs==0.0.2a38
     # via sqlalchemy
 srvlookup==2.0.0
     # via csh-ldap
+tomlkit==0.13.3
+    # via pylint
 typing-extensions==4.14.1
     # via
     #   alembic