Refactors for conciseness

Also because Joel likes comprehensions

Author: mxmeinhold

packet/commands.py

@@ -9,7 +9,7 @@
 
 from . import app, db
 from .models import Freshman, Packet, FreshSignature, UpperSignature, MiscSignature
-from .ldap import ldap_get_eboard, ldap_get_active_members
+from .ldap import ldap_get_active_members, ldap_is_eboard, ldap_is_intromember
 
 
 @app.cli.command("create-secret")
@@ -113,8 +113,7 @@ def create_packets(freshmen_csv):
     end = datetime.combine(base_date, packet_end_time) + timedelta(days=14)
 
     print("Fetching data from LDAP...")
-    eboard = set(member.uid for member in ldap_get_eboard())
-    all_upper = set(member.uid for member in ldap_get_active_members())
+    all_upper = list(filter(lambda member: not ldap_is_intromember(member), ldap_get_active_members()))
 
     # Create the new packets and the signatures for each freshman in the given CSV
     freshmen_in_csv = parse_csv(freshmen_csv)
@@ -124,7 +123,7 @@ def create_packets(freshmen_csv):
         db.session.add(packet)
 
         for member in all_upper:
-            db.session.add(UpperSignature(packet=packet, member=member, eboard=member in eboard))
+            db.session.add(UpperSignature(packet=packet, member=member.uid, eboard=ldap_is_eboard(member)))
 
         for onfloor_freshman in Freshman.query.filter_by(onfloor=True).filter(Freshman.rit_username !=
                                                                               freshman.rit_username).all():
@@ -140,14 +139,13 @@ def ldap_sync():
     Updates the upper and misc sigs in the DB to match ldap.
     """
     print("Fetching data from LDAP...")
-    eboard = set(member.uid for member in ldap_get_eboard())
-    all_upper = set(member.uid for member in ldap_get_active_members())
+    all_upper = {member.uid: member for member in filter(lambda member: not ldap_is_intromember(member), ldap_get_active_members())}
 
     print("Applying updates to the DB...")
     for packet in Packet.query.filter(Packet.end > datetime.now()).all():
         # Update the eboard state of all UpperSignatures
         for sig in packet.upper_signatures:
-            sig.eboard = sig.member in eboard
+            sig.eboard = ldap_is_eboard(all_upper[sig.member])
 
         # Migrate UpperSignatures that are from accounts that are not active anymore
         for sig in filter(lambda sig: sig.member not in all_upper, packet.upper_signatures):
@@ -164,7 +162,7 @@ def ldap_sync():
         # pylint: disable=cell-var-from-loop
         upper_sigs = set(map(lambda sig: sig.member, packet.upper_signatures))
         for member in filter(lambda member: member not in upper_sigs, all_upper):
-            db.session.add(UpperSignature(packet=packet, member=member, eboard=member in eboard))
+            db.session.add(UpperSignature(packet=packet, member=member, eboard=ldap_is_eboard(all_upper[member]))
 
     db.session.commit()
     print("Done!")