Now pylint compatible

Author: Will-Hellinger

packet/__init__.py

@@ -5,6 +5,8 @@
 import logging
 import os
 
+from typing import Union
+
 import onesignal
 from flask import Flask
 from flask_gzip import Gzip
@@ -13,8 +15,6 @@
 from flask_pyoidc.provider_configuration import ProviderConfiguration, ClientMetadata
 from flask_sqlalchemy import SQLAlchemy
 
-from typing import Union
-
 import sentry_sdk
 from sentry_sdk.integrations.flask import FlaskIntegration
 from sentry_sdk.integrations.sqlalchemy import SqlalchemyIntegration
@@ -99,14 +99,14 @@
     'models',
     'context_processors',
     'commands',
-    'api',
-    'shared',
+    'api', # pylint: disable=undefined-all-variable
+    'shared', # pylint: disable=undefined-all-variable
 )
 
 if app.config['REALM'] == 'csh':
-    from .routes import upperclassmen as upperclassmen
-    from .routes import admin as admin
+    from .routes import upperclassmen as upperclassmen # pylint: disable=useless-import-alias
+    from .routes import admin as admin # pylint: disable=useless-import-alias
 else:
-    from .routes import freshmen as freshmen
+    from .routes import freshmen as freshmen # pylint: disable=useless-import-alias
 
 app.logger.info('Routes registered')

packet/commands.py

@@ -4,11 +4,12 @@
 
 import sys
 
+from typing import Union
 from secrets import token_hex
-from datetime import datetime, time, date
+from datetime import datetime, time, date\
+
 import csv
 import click
-from typing import Union
 
 from . import app, db
 from .models import Packet, FreshSignature, UpperSignature, MiscSignature
@@ -208,22 +209,18 @@ def fetch_results(file_path: str, use_csv: bool, date_str: str) -> None:
         writer.writerows(data)
     else:
         for row in data:
-            """
-            Old
-
-            file_handle.write(
-                f'''
-                {row[0]}
-                \t{column_titles[1]}: {row[1]}
-                \t{column_titles[2]}: {row[2]}
-                \t{column_titles[3]}: {row[3]}
-                \t{column_titles[4]}: {row[4]}
-                \t{column_titles[5]}: {row[5]}
-
-                \t{column_titles[6]}: {row[6]}
-                '''
-            )
-            """
+            # Old
+            #file_handle.write(
+            #    f'''
+            #    {row[0]}
+            #    \t{column_titles[1]}: {row[1]}
+            #    \t{column_titles[2]}: {row[2]}
+            #    \t{column_titles[3]}: {row[3]}
+            #    \t{column_titles[4]}: {row[4]}
+            #    \t{column_titles[5]}: {row[5]}
+            #    \t{column_titles[6]}: {row[6]}
+            #    '''
+            #)
 
             out: str = str(row[0]) + '\n'
 

packet/ldap.py

@@ -4,7 +4,7 @@
 
 from functools import lru_cache
 from datetime import date
-from typing import Optional, cast, Any, Union
+from typing import Optional, cast, Any
 
 from csh_ldap import CSHLDAP, CSHMember
 
@@ -34,7 +34,7 @@ def __init__(
 
         self.room_number: Optional[int] = room_number if room_number else None
 
-        self.cn: str = cn if cn else uid.title()
+        self.cn: str = cn if cn else uid.title() # pylint: disable=invalid-name
 
     def __eq__(self, other: Any) -> bool:
         """
@@ -401,7 +401,7 @@ def is_on_coop(self, member: CSHMember) -> bool:
 
         return self._is_member_of_group(member, 'spring_coop')
 
-    def get_roomnumber(self, member: CSHMember) -> Optional[int]:
+    def get_roomnumber(self, member: CSHMember) -> Optional[int]: # pylint: disable=no-self-use
         """
         Get the room number of a member.
 

packet/utils.py

@@ -255,11 +255,14 @@ def sync_freshman(freshmen_list: dict) -> None:
     # Update the freshmen signatures of each open or future packet
     for packet in Packet.query.filter(Packet.end > datetime.now()).all():
         current_fresh_sigs = set(map(lambda fresh_sig: fresh_sig.freshman_username, packet.fresh_signatures))
-        for list_freshman in filter(
-            lambda list_freshman: list_freshman.rit_username not in current_fresh_sigs
-            and list_freshman.rit_username != packet.freshman_username,
-            freshmen_list.values(),
-        ):
+
+        for list_freshman in freshmen_list.values():
+            if list_freshman.rit_username in current_fresh_sigs:
+                continue
+
+            if list_freshman.rit_username == packet.freshman_username:
+                continue
+
             db.session.add(FreshSignature(packet=packet, freshman=freshmen_in_db[list_freshman.rit_username]))
 
     db.session.commit()
@@ -375,7 +378,10 @@ def sync_with_ldap() -> None:
 
         # Create UpperSignatures for any new active members
         upper_sigs = set(map(lambda sig: sig.member, packet.upper_signatures))
-        for member in filter(lambda member: member not in upper_sigs, all_upper):
+        for member in all_upper:
+            if member in upper_sigs:
+                continue
+
             sig = UpperSignature(packet=packet, member=member)
             sig.eboard = ldap.get_eboard_role(all_upper[sig.member])
             sig.active_rtp = sig.member in rtp