Merge branch 'develop' into HEAD

Author: JoelEager

config.env.py

@@ -23,3 +23,6 @@
 # LDAP config
 LDAP_BIND_DN = environ.get("PACKET_LDAP_BIND_DN", None)
 LDAP_BIND_PASS = environ.get("PACKET_LDAP_BIND_PASS", None)
+
+# Slack URL for pushing to #general
+SLACK_WEBHOOK_URL = environ.get("PACKET_SLACK_URL", None)

packet/models.py

@@ -103,6 +103,12 @@ def did_sign(self, username, is_csh):
         # The user must be a misc CSHer that hasn't signed this packet or an off-floor freshmen
         return False
 
+    def is_100(self):
+        """
+        Checks if this packet has reached 100%
+        """
+        return self.signatures_required().total == self.signatures_recieved().total
+
     @classmethod
     def open_packets(cls):
         """

packet/routes/api.py

@@ -1,5 +1,5 @@
 from packet import app, db
-from packet.utils import before_request, packet_auth
+from packet.utils import before_request, packet_auth, notify_slack
 from packet.models import Packet, MiscSignature
 
 
@@ -10,25 +10,32 @@ def sign(packet_id, info):
     packet = Packet.by_id(packet_id)
 
     if packet is not None and packet.is_open():
+        was_100 = packet.is_100()
         if app.config["REALM"] == "csh":
             # Check if the CSHer is an upperclassman and if so, sign that row
             for sig in filter(lambda sig: sig.member == info["uid"], packet.upper_signatures):
                 sig.signed = True
                 db.session.commit()
                 app.logger.info("Member {} signed packet {} as an upperclassman".format(info["uid"], packet_id))
+                if not was_100 and packet.is_100():
+                    notify_slack(packet.freshman.name)
                 return "Success: Signed Packet: " + packet.freshman_username
 
             # The CSHer is a misc so add a new row
             db.session.add(MiscSignature(packet=packet, member=info["uid"]))
             db.session.commit()
             app.logger.info("Member {} signed packet {} as a misc".format(info["uid"], packet_id))
+            if not was_100 and packet.is_100():
+                notify_slack(packet.freshman.name)
             return "Success: Signed Packet: " + packet.freshman_username
         else:
             # Check if the freshman is onfloor and if so, sign that row
             for sig in filter(lambda sig: sig.freshman_username == info["uid"], packet.fresh_signatures):
                 sig.signed = True
                 db.session.commit()
                 app.logger.info("Freshman {} signed packet {}".format(info["uid"], packet_id))
+                if not was_100 and packet.is_100():
+                    notify_slack(packet.freshman.name)
                 return "Success: Signed Packet: " + packet.freshman_username
 
     app.logger.warn("Failed to add {}'s signature to packet {}".format(info["uid"], packet_id))

packet/utils.py

@@ -87,3 +87,15 @@ def wrapped_function(*args, **kwargs):
         return func(*args, **kwargs)
 
     return wrapped_function
+
+def notify_slack(name: str):
+    """
+    Sends a congratulate on sight decree to Slack
+    """
+    if app.config["SLACK_WEBHOOK_URL"] is None:
+        app.logger.warn("SLACK_WEBHOOK_URL not configured, not sending message to slack.")
+        return
+
+    msg = f'{name} got :100: on packet. Shower on sight.'
+    requests.put(app.config["SLACK_WEBHOOK_URL"], json={'text':msg})
+    app.logger.info("Posted 100% notification to slack for " + name)