Moving signed_notification into commit_sig

Author: devinmatte

packet/routes/api.py

@@ -24,21 +24,18 @@ def sign(packet_id, info):
             for sig in filter(lambda sig: sig.member == info["uid"], packet.upper_signatures):
                 sig.signed = True
                 app.logger.info("Member {} signed packet {} as an upperclassman".format(info["uid"], packet_id))
-                packet_signed_notification(packet, info["uid"])
-                return commit_sig(packet, was_100)
+                return commit_sig(packet, was_100, info["uid"])
 
             # The CSHer is a misc so add a new row
             db.session.add(MiscSignature(packet=packet, member=info["uid"]))
             app.logger.info("Member {} signed packet {} as a misc".format(info["uid"], packet_id))
-            packet_signed_notification(packet, info["uid"])
-            return commit_sig(packet, was_100)
+            return commit_sig(packet, was_100, info["uid"])
         else:
             # Check if the freshman is onfloor and if so, sign that row
             for sig in filter(lambda sig: sig.freshman_username == info["uid"], packet.fresh_signatures):
                 sig.signed = True
                 app.logger.info("Freshman {} signed packet {}".format(info["uid"], packet_id))
-                packet_signed_notification(packet, info["uid"])
-                return commit_sig(packet, was_100)
+                return commit_sig(packet, was_100, info["uid"])
 
     app.logger.warn("Failed to add {}'s signature to packet {}".format(info["uid"], packet_id))
     return "Error: Signature not valid.  Reason: Unknown"
@@ -67,7 +64,8 @@ def report(info):
     return "Success: " + get_rit_name(info['uid']) + " sent a report"
 
 
-def commit_sig(packet, was_100):
+def commit_sig(packet, was_100, uid):
+    packet_signed_notification(packet, uid)
     db.session.commit()
     if not was_100 and packet.is_100():
         packet_100_percent_notification(packet)