Merge pull request #221 from MoralCode/fix-delete

devinmatte · web-flow · commit 16322e7228a8 · 2019-12-04T15:40:14.000-05:00
account for current page and page size when hiding schedules (fix #183)
diff --git a/assets/src/modules/sm/Schedule/directives/scheduleActionsDirective.js b/assets/src/modules/sm/Schedule/directives/scheduleActionsDirective.js
@@ -142,7 +142,10 @@ angular.module('sm').directive('scheduleActions', function ($http, $q, shareServ
 
       hide: function () {
         ga('send', 'event', 'schedule', 'hide')
-        scope.$parent.$parent.state.schedules.splice(scope.$index, 1)
+        const appstate = scope.$parent.$parent.state
+        const pageStartIndex = appstate.displayOptions.currentPage * appstate.displayOptions.pageSize
+
+        appstate.schedules.splice(pageStartIndex + scope.$index, 1)
       }
     }
   };
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "schedulemaker",
-  "version": "3.1.2",
+  "version": "3.1.3",
   "private": true,
   "description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",
   "main": "index.php",

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,10 @@ angular.module('sm').directive('scheduleActions', function ($http, $q, shareServ`
`142`	`142`
`143`	`143`	`hide: function () {`
`144`	`144`	`ga('send', 'event', 'schedule', 'hide')`
`145`		`- scope.$parent.$parent.state.schedules.splice(scope.$index, 1)`
	`145`	`+ const appstate = scope.$parent.$parent.state`
	`146`	`+ const pageStartIndex = appstate.displayOptions.currentPage * appstate.displayOptions.pageSize`
	`147`	`+`
	`148`	`+ appstate.schedules.splice(pageStartIndex + scope.$index, 1)`
`146`	`149`	`}`
`147`	`150`	`}`
`148`	`151`	`};`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "schedulemaker",`
`3`		`- "version": "3.1.2",`
	`3`	`+ "version": "3.1.3",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",`
`6`	`6`	`"main": "index.php",`