Skip to content

Commit 21194ef

Browse files
committed
Fixes #65 Rate My professors link updated
Fixes #66 Start time can now be 0 without failing. Fixes #61 Students enrolled now displays in the course selection
1 parent 364ade7 commit 21194ef

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

assets/src/modules/sm/App/providers/RMPUrlFilter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ angular.module('sm').filter('RMPUrl', function() {
44
if(input && input != "TBA") {
55
var nameParts = input.split(" "),
66
lastName = nameParts[nameParts.length - 1];
7-
return '<a target="_blank" href="http://www.ratemyprofessors.com/SelectTeacher.jsp?searchName=' + lastName + '&search_submit1=Search&sid=807">' + input + '</a>';
7+
return '<a target="_blank" href="http://www.ratemyprofessors.com/search.jsp?queryBy=teacherName&queryoption=HEADER&query=' + lastName + '&facetSearch=true&schoolName=rochester+institute+of+technology">' + input + '</a>';
88
} else {
99
return '<a href="#">' + input + '</a>';
1010
}

assets/src/modules/sm/Generate/templates/courseselect.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ <h4 class="list-group-item-heading">{{$index + 1}}. {{section.courseNum}}</h4>
4646
<button type="button" class="btn btn-block" ng-click="section.selected = !section.selected" ng-class="{'btn-danger':section.selected, 'btn-success':!section.selected}"><i class="fa" ng-class="{'fa-minus':section.selected, 'fa-plus':!section.selected}"></i> <i class="fa fa-shopping-cart"></i></button>
4747
</div>
4848
</div>
49+
<div class="text-center">
50+
<div class="well-sm" style=" background-color: #ddd; margin: 8px 0;" title="Other students enrolled as of 6AM today">{{section.curenroll}}/{{section.maxenroll}} <i class="fa fa-user"></i></div>
51+
</div>
4952
</div>
5053
</div>
5154
</li>

assets/src/modules/sm/Generate/templates/generate.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ <h2 class="panel-title">Times You Don't Want Classes</h2>
208208
<div class="panel-body">
209209
<div class="row form-inline">
210210
<div class="col-xs-12">
211+
<pre>{{state.drawOptions}}</pre>
211212
<div class="form-group">&nbsp;Display <strong>{{state.schedules.length}}</strong> schedules from&nbsp;</div>
212213
<div class="form-group inline-sm">
213214
<select id="options-startTime" ng-change="ensureCorrectEndTime()" class="form-control" ng-model="state.drawOptions.startTime" ng-options="key as ui.optionLists.times.values[key] for key in ui.optionLists.times.keys"></select>

assets/src/modules/sm/Schedule/directives/scheduleDirective.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ angular.module('sm').directive('schedule', function($timeout, $filter) {
1010
start: parseInt(options.startTime),
1111
end: parseInt(options.endTime)
1212
};*/
13-
if(!this.drawOptions.startTime || !this.drawOptions.endTime) return false;
14-
13+
if((!this.drawOptions.startTime && this.drawOptions.startTime !== 0) || !this.drawOptions.endTime) return false;
1514
this.scope.hiddenCourses = [];
1615
this.scope.onlineCourses = [];
1716
this.scope.scheduleItems = [];

0 commit comments

Comments
 (0)