Skip to content

Commit 30c5403

Browse files
committed
Fixes for iCal support, comma courses, and versioning.
1 parent 58a2995 commit 30c5403

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

.htaccess

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ RewriteRule ^schedule.php$ http://schedule-old.csh.rit.edu/schedule.php [NC,L,R=
1111

1212
RewriteCond %{HTTP:Accept} application/json [NC]
1313
RewriteRule ^(schedule|generate|entity|search|status|rmp)(?:/([^/]*))*$ api/$1.php [L]
14+
RewriteRule ^schedule/[^/]*/ical$ api/schedule.php [L]
1415

1516

1617
# Don't rewrite files or directories

api/generate.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,9 @@ function timeStringToMinutes($str) {
210210
$courseOptions = array();
211211
foreach(explode(',', $_POST['course']) as $course) {
212212
// If the course has enough characters for a lab section but
213-
// but doesn't match OR there are <= 9 characters but it isn't
213+
// but doesn't match OR there are <= 12 characters but it isn't
214214
// numeric, then they fucked up.
215-
if(strlen($course) > 11) {
215+
if(strlen($course) > 13) {
216216
die(json_encode(array("error" => "argument", "msg" => "Your courses must be in the format XXXX-XXX-XXLX")));
217217
}
218218

api/schedule.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function generateIcal($schedule) {
5151
$code .= "CALSCALE:GREGORIAN\r\n";
5252

5353
// Iterate over all the courses
54-
foreach($schedule['courses'][0] as $course) {
54+
foreach($schedule['courses'] as $course) {
5555
// Skip classes that don't meet
5656
if(empty($course['times'])) {
5757
continue;
@@ -245,16 +245,12 @@ function renderSvg($svg, $id) {
245245
case "ical":
246246
// iCAL FORMAT SCHEDULE ////////////////////////////////////////////
247247
// If we don't have a schedule, die!
248-
if(empty($_GET['id'])) {
248+
if(empty($id)) {
249249
die("You must provide a schedule");
250250
}
251251

252-
// Database connection is required
253-
require_once("inc/databaseConn.php");
254-
require_once("inc/timeFunctions.php");
255-
256252
// Decode the schedule
257-
$schedule = getScheduleFromId(hexdec($_GET['id']));
253+
$schedule = getScheduleFromId($id);
258254

259255
// Set header for ical mime, output the xml
260256
header("Content-Type: text/calendar");

index.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
}
1818

1919
// REQUIRED FILES
20+
$APP_ROOT = "./";
2021
require_once('./inc/config.php');
2122
require_once('./inc/databaseConn.php');
2223
require_once('./inc/timeFunctions.php');
@@ -90,7 +91,7 @@
9091
</div>
9192
<footer class="main default">
9293
<div class="csh"><a target="_blank" href="http://www.csh.rit.edu/"><img src="<?=$HTTPROOTADDRESS?>img/csh.png" alt="CSH" /></a></div>
93-
<a ui-sref="help">Help</a> | <a href="/status">Status</a> | <a target="_blank" href="https://github.com/ComputerScienceHouse/schedulemaker/issues">Report Issues</a>
94+
Version: <?=$APP_VERSION?> | <a ui-sref="help">Help</a> | <a href="/status">Status</a> | <a target="_blank" href="https://github.com/ComputerScienceHouse/schedulemaker/issues">Report Issues</a>
9495
<div>
9596
Idea: John Resig (phytar at csh.rit.edu)<br>
9697
Development v2: Ben Russell (benrr101 at csh.rit.edu),<br>

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "schedulemaker",
3-
"version": "3.0.0",
3+
"version": "3.0.1",
44
"private": true,
55
"description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",
66
"main": "index.php",
@@ -38,6 +38,9 @@
3838
"bugs": {
3939
"url": "https://github.com/ComputerScienceHouse/schedulemaker/issues"
4040
},
41+
"config": {
42+
"stateVersion": 1
43+
},
4144
"homepage": "http://schedule.csh.rit.edu",
4245
"devDependencies": {
4346
"gulp": "^3.6.0",

0 commit comments

Comments
 (0)