Fixing linting errors phase 3

Author: devinmatte

assets/src/modules/sm/App/providers/entityDataRequestFactory.js

@@ -1,7 +1,7 @@
 angular.module('sm').factory('entityDataRequest', function ($http) {
   var entityDataRequest = function (params, callback) {
     return $http.post('/entity/' + params.action, $.param(params))
-  };
+  }
   return {
     getSchoolsForTerm: function (opts) {
       return entityDataRequest({

assets/src/modules/sm/Browse/directives/browseListDirective.js

@@ -11,7 +11,6 @@ angular.module('sm').directive('browseList', function ($http, entityDataRequest)
         var hIndex = hierarchy.indexOf(attrs.browseList)
         if (hIndex === -1) {
           throw 'browseList mode does not exist'
-          return
         }
         var itemName = hierarchy[hIndex]
         var childrenName = hierarchy[hIndex + 1] + 's'

assets/src/modules/sm/Schedule/directives/scheduleActionsDirective.js

@@ -130,7 +130,7 @@ angular.module('sm').directive('scheduleActions', function ($http, $q, shareServ
         ga('send', 'event', 'schedule', 'print')
 
         var reloadSchedule = angular.copy(scope.state.drawOptions)
-        reloadSchedule.term = scope.state.requestOptions.term,
+        reloadSchedule.term = scope.state.requestOptions.term
         reloadSchedule.courses = scope.schedule
 
         var popup = openPopup(920, 800)

assets/src/modules/sm/Schedule/directives/scheduleDirective.js

@@ -138,7 +138,7 @@ angular.module('sm').directive('schedule', function ($timeout, $filter) {
       timeTop = timeTop / 7.5
       timeTop = Math.floor(timeTop)
       timeTop = timeTop * 5
-      timeTop += 19					// Offset for the header
+      timeTop += 19 // Offset for the header
 
       // Add Padding for Formatting Time
       function pad (d) {
@@ -162,16 +162,15 @@ angular.module('sm').directive('schedule', function ($timeout, $filter) {
       }
 
       // Set event data
+      var location = ''
+      var instructor = ''
+      var courseNum = ''
       if (course.courseNum !== 'non') {
-        var location = ((this.drawOptions.bldgStyle === 'code') ? time.bldg.code : time.bldg.number) + '-' + time.room + ' (' + (String(hourLabel) + ':' + String(minuteLabel) + ' ' + ap) + ')'
-        var instructor = course.instructor
-        var courseNum = course.courseNum
-      } else {
-        var location = ''
-        var instructor = ''
-        var courseNum = ''
+        location = ((this.drawOptions.bldgStyle === 'code') ? time.bldg.code : time.bldg.number) + '-' + time.room + ' (' + (String(hourLabel) + ':' + String(minuteLabel) + ' ' + ap) + ')'
+        instructor = course.instructor
+        courseNum = course.courseNum
       }
-      course.title = course.title.replace(/&amp;/g, '&').replace(/&lt;/g, '<').replace(/&gt;/g, '>').replace(/&quot;/g, '"').replace(/&#039;/g, "\'").replace(/\\\\/, '\\')
+      course.title = course.title.replace(/&amp;/g, '&').replace(/&lt;/g, '<').replace(/&gt;/g, '>').replace(/&quot;/g, '"').replace(/&#039;/g, "'").replace(/\\\\/, '\\')
       this.scope.scheduleItems.push({
         title: course.title,
         content: {

assets/src/modules/sm/Status/controllers/StatusController.js

@@ -11,8 +11,8 @@ angular.module('sm').controller('StatusController', function ($scope, $http) {
       }
     })
 
-  $scope.timeConvert = function (UNIX_timestamp) {
-    var a = new Date(+UNIX_timestamp * 1000)
+  $scope.timeConvert = function (UnixTimestamp) {
+    var a = new Date(+UnixTimestamp * 1000)
     var months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
     var year = a.getFullYear()
     var month = months[a.getMonth()]