Skip to content

Commit d5bf288

Browse files
committed
Fixed minor ctrl+enter bugs and removed lab classes notification. Closes #82
1 parent 5f82777 commit d5bf288

File tree

6 files changed

+19
-15
lines changed

6 files changed

+19
-15
lines changed

.htaccess

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ RewriteRule ^ index.php [L]
3333

3434
# Set max-age one year in the future for all static assets
3535
# Allow caching for all assets
36-
<FilesMatch "\.(js|css|png|jpg|html)$">
37-
Header set Cache-Control "max-age=29030400, public"
38-
Header unset ETag
39-
FileETag None
40-
ExpiresActive On
41-
ExpiresDefault A29030400
42-
</FilesMatch>
36+
#<FilesMatch "\.(js|css|png|jpg|html)$">
37+
# Header set Cache-Control "max-age=29030400, public"
38+
# Header unset ETag
39+
# FileETag None
40+
# ExpiresActive On
41+
# ExpiresDefault A29030400
42+
#</FilesMatch>

assets/src/modules/sm/App/controllers/AppController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ angular.module('sm').controller("AppController", function($scope, localStorage,
3737
alert_generateFeatures: true,
3838
alert_searchFeatures: true,
3939
alert_browseFeatures: true,
40-
alert_labClasses: true,
40+
alert_labClasses: false,
4141
action_generateSchedules: false,
4242
};
4343

assets/src/modules/sm/App/providers/globalKbdShortcutsFactory.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
angular.module('sm').factory('globalKbdShortcuts', function($rootScope) {
22
var globalKbdShortcuts = {
3+
'bindCtrlEnter': function(callback) {
4+
Mousetrap.bind('mod+enter', function(e) {
5+
$rootScope.$apply(callback);
6+
return true;
7+
});
8+
9+
// Only allow to bind once, so mock function after first use
10+
this.bindCtrlEnter = function() {};
11+
},
312
'bindEnter': function(callback) {
413
Mousetrap.bind('enter', function(e) {
514
$rootScope.$apply(callback);

assets/src/modules/sm/App/templates/help.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ <h4>Keyboard Shortcuts</h4>
1919
</ul>
2020
<strong>Search Page</strong>
2121
<ul>
22-
<li><kbd>Ctrl</kbd> + <kbd>Enter</kbd>: Search</li>
22+
<li><kbd>Enter</kbd>: Search</li>
2323
<li><kbd>Ctrl</kbd> + <kbd>Left</kbd> or <kbd>Right</kbd>: Move between pages of results</li>
2424
</ul>
2525
</div>

assets/src/modules/sm/Generate/templates/generate.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
<form novalidate id="scheduleForm" name="schedule" class="container">
22
<div class="row">
33
<div class="col-md-8 clearfix">
4-
<div class="alert alert-success" ng-show="state.ui.alert_labClasses">
5-
<button type="button" class="close" data-dismiss="alert" aria-hidden="true" ng-click="state.ui.alert_labClasses = false"><i class="fa fa-times"></i></button>
6-
<strong>NEW!</strong> Lab classes and other sections should now be paired with their respective sections. Just enter in classes with labs and everything should work as you expected. Please <a target="_blank" href="https://github.com/ComputerScienceHouse/schedulemaker/issues">report any issues</a> that you find!
7-
8-
</div>
94
<div class="alert alert-info" ng-show="state.ui.alert_generateFeatures">
105
<button type="button" class="close" data-dismiss="alert" aria-hidden="true" ng-click="state.ui.alert_generateFeatures = false"><i class="fa fa-times"></i></button>
116
Use a comma to separate courses to see which course fits your schedule better. Add courses from the Browse or Search page to your schedule as well so you can easily create schedule combinations from anywhere! Also, check out the <a ui-sref="help">help</a> page for new keyboard shortcuts.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "schedulemaker",
3-
"version": "3.0.18",
3+
"version": "3.0.19",
44
"private": true,
55
"description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",
66
"main": "index.php",

0 commit comments

Comments
 (0)