Skip to content

Commit db1546f

Browse files
committed
Merge pull request #96 from JoelEager/master
Added readme, implemented a feature request, and updated .gitignore
2 parents 7362bcc + ddf90e1 commit db1546f

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed

.gitignore

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ node_modules/*
1313
assets/prod/*
1414
!assets/prod/.gitkeep
1515

16-
#### EDITOR IGNORES####
16+
# Other files
17+
_Local Working Files/*
18+
19+
#### EDITOR IGNORES ####
1720

1821
# Ignore PhpStorm files
1922
.idea
@@ -30,4 +33,4 @@ assets/prod/*
3033
*.suo
3134
web.config
3235
vwd.webinfo
33-
WebEssentials-Settings.json
36+
WebEssentials-Settings.json

assets/src/modules/sm/App/providers/RMPUrlFilter.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
angular.module('sm').filter('RMPUrl', function() {
33
return function(input) {
44
if(input && input != "TBA") {
5-
var nameParts = input.split(" "),
6-
lastName = nameParts[nameParts.length - 1];
7-
return '<a target="_blank" href="http://www.ratemyprofessors.com/search.jsp?queryBy=teacherName&queryoption=HEADER&query=' + lastName + '&facetSearch=true&schoolName=rochester+institute+of+technology">' + input + '</a>';
5+
var EscapedName = encodeURIComponent(input);
6+
return '<a target="_blank" href="http://www.ratemyprofessors.com/search.jsp?queryBy=teacherName&queryoption=HEADER&query=' + EscapedName + '&facetSearch=true&schoolName=rochester+institute+of+technology">' + input + '</a>';
87
} else {
98
return '<a href="#">' + input + '</a>';
109
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "schedulemaker",
3-
"version": "3.0.17",
3+
"version": "3.0.18",
44
"private": true,
55
"description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",
66
"main": "index.php",

readme.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# ScheduleMaker
2+
A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.
3+
4+
Instructions for setting up a dev environment:
5+
1. Install Apache (Use on XAMPP Windows: https://www.apachefriends.org/index.html)
6+
2. Install Node.js: https://nodejs.org/en/
7+
3. Clone either the master or a fork of this repo to your local machine
8+
4. Copy the config.example.php file to config.php in /inc/
9+
5. Contact a current dev to help with server/database config.
10+
11+
To build js files:
12+
Run "npm run-script build"

0 commit comments

Comments
 (0)