Skip to content

Commit e3e7668

Browse files
committed
Merge pull request #99 from JoelEager/master
A bunch of bug fixes and improvements (see description)
2 parents 84be05e + 8133a1d commit e3e7668

File tree

5 files changed

+14
-16
lines changed

5 files changed

+14
-16
lines changed

assets/src/modules/sm/App/controllers/AppController.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ angular.module('sm').controller("AppController", function($scope, localStorage,
7373
// Check if state version exists or is correct
7474
if(storedState.hasOwnProperty('meta') && storedState.meta.stateVersion == $scope.stateVersion) {
7575
$scope.state = storedState;
76-
console.log('asdjasdjk');
7776
if(!$scope.state.displayOptions.hasOwnProperty('creditWarning') || !$scope.state.displayOptions.creditWarning) {
7877
$scope.state.displayOptions.creditWarning = 18;
7978
}

assets/src/modules/sm/Schedule/directives/scheduleDirective.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ angular.module('sm').directive('schedule', function($timeout, $filter) {
144144
courseNum = '';
145145
}
146146
this.scope.scheduleItems.push({
147-
title:course.title,
147+
title: course.title.replace(/&amp;/g, "&").replace(/&lt;/g, "<").replace(/&gt;/g, ">").replace(/&$quot;/g, "\"").replace(/&#039;/g, "\'"),
148148
content: {
149-
location: location ,
149+
location: location,
150150
courseNum: courseNum,
151151
instructor: instructor
152152
},
@@ -159,7 +159,6 @@ angular.module('sm').directive('schedule', function($timeout, $filter) {
159159
},
160160
color: this.scope.ui.colors[course.courseIndex?(course.courseIndex - 1):this.courseDrawIndex - 1 % 10]
161161
});
162-
163162
}
164163
};
165164

assets/src/modules/sm/Schedule/directives/svgTextLineDirective.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ angular.module('sm').directive('svgTextLine', function() {
44
var text = attrs.svgTextLine;
55
var adjust = (scope.print)? 1: 0;
66
var cutoff = 25 + (adjust * -7);
7-
if(scope.grid.days.length > 3) {
8-
if(text.length > 14) {
7+
8+
if (scope.grid.days.length > 3) {
9+
if (text.length > 14) {
910
element = elm.get(0);
10-
element.setAttribute("textLength", (parseFloat(scope.grid.opts.daysWidth) + 1 - adjust )+ "%");
11+
element.setAttribute("textLength", (parseFloat(scope.grid.opts.daysWidth) - 1) + "%");
1112
element.setAttribute("lengthAdjust", "spacingAndGlyphs");
1213
}
13-
if(text.length > cutoff) {
14+
if (text.length > cutoff) {
1415
text = text.slice(0, cutoff - 3) + '...';
1516
}
1617
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "schedulemaker",
3-
"version": "3.0.19",
3+
"version": "3.0.20",
44
"private": true,
55
"description": "A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.",
66
"main": "index.php",

readme.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22
A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.
33

44
Instructions for setting up a dev environment:
5-
1. Install Apache (Use on XAMPP Windows: https://www.apachefriends.org/index.html)
6-
2. Install Node.js: https://nodejs.org/en/
7-
3. Clone either the master or a fork of this repo to your local machine
8-
4. Copy the config.example.php file to config.php in /inc/
9-
5. Contact a current dev to help with server/database config.
5+
>1. Install Apache (Use XAMPP if you're on Windows: https://www.apachefriends.org/index.html)
6+
>2. Install Node.js: https://nodejs.org/en/
7+
>3. Clone either the master or a fork of this repo to your local machine
8+
>4. Copy the config.example.php file to config.php in /inc/
9+
>5. Contact a current dev to help with server/database config.
1010
11-
To build js files:
12-
Run "npm run-script build"
11+
To build js files run "npm run-script build"

0 commit comments

Comments
 (0)