fix: removed prisma usage in middleware (#687)

* fix: removed prisma usage in middleware

* fix: removed potentially prisma-calling code

Author: q1zhen

app/components/custom/sidebar.vue

@@ -1,8 +1,6 @@
 <script setup lang="ts">
 import type { AllClubs } from '@@/types/api/user/all_clubs'
-import type { getRoleResponse } from '~~/utils/user-roles'
 import { useClerk, useUser } from 'vue-clerk'
-import { isAdmin } from '~~/utils/user-roles'
 
 const { user } = useUser()
 const config = useRuntimeConfig()
@@ -23,11 +21,11 @@ const { data: clubs, suspense: __s1 } = useQuery<AllClubs>({
 await __s1()
 
 const isUserAdmin = ref(false)
-const { data: roleData, suspense: __s2 } = useQuery<getRoleResponse>({
+const { data: roleData, suspense: __s2 } = useQuery<any>({
   queryKey: ['/api/user/check-role'],
 })
 await __s2()
-isUserAdmin.value = isAdmin(roleData.value)
+isUserAdmin.value = roleData.value?.success === true && roleData.value.role === 'ADMIN'
 
 if (clubs.value) {
   useState('isEnspireLoading').value = false

app/middleware/admin.ts

@@ -1,7 +1,6 @@
-import { Roles } from '@prisma/client'
 import { until } from '@vueuse/core'
 import { useClerk, useClerkProvider } from 'vue-clerk'
-import { getRole, isAdmin } from '~~/utils/user-roles'
+import { getRole } from '~~/utils/user-roles'
 
 export default defineNuxtRouteMiddleware(async () => {
   // Modified from auth.ts
@@ -18,7 +17,7 @@ export default defineNuxtRouteMiddleware(async () => {
     if (clerk.loaded && clerk.user?.id == null)
       return navigateTo('/sign-in')
     const response = await $fetch('/api/user/check-role')
-    if (!isAdmin(response))
+    if (!(response?.success === true && response.role === 'ADMIN'))
       return abortNavigation()
   }
 
@@ -27,7 +26,7 @@ export default defineNuxtRouteMiddleware(async () => {
     if (id == null)
       return navigateTo('/sign-in')
     const response = await getRole(id)
-    if (!isAdmin(response))
+    if (!(response?.success === true && response.role === 'ADMIN'))
       return abortNavigation()
   }
 })

utils/user-roles.ts

@@ -1,16 +1,14 @@
-import type { $Enums } from '@prisma/client'
 import { PrismaClient, Roles } from '@prisma/client'
 
-const prisma = new PrismaClient()
-
 export interface getRoleResponse {
   success: boolean
-  role: $Enums.Roles | null
+  role: string | null
   error?: string
 }
 
-export async function getRole(clerkId: string) {
+export async function getRole(clerkId: string): Promise<getRoleResponse> {
   try {
+    const prisma = new PrismaClient()
     const user = await prisma.user.findFirstOrThrow({
       where: {
         clerkUserId: clerkId,
@@ -30,7 +28,7 @@ export async function getRole(clerkId: string) {
   }
 }
 
-export function isRole(roleData: getRoleResponse | undefined, theRole: $Enums.Roles) {
+export function isRole(roleData: getRoleResponse | undefined, theRole: string) {
   return roleData?.success === true && roleData.role === theRole
 }