Missing perfdata units for perf checks reporting *BytesPerSecond values

[ccztux]

The performance data unit is missing for perf checks that provide *BytesPerSecond values, which leads to incorrect graph visualization.

Example:

root@localhost /home/zet/git-repos/check_vsphere # /usr/lib64/meg/plugins/check_vsphere perf --disable-ssl-verification --sessionfile /tmp/check_vsphere.192.168.0.160.session --host 192.168.0.170 --user monitoring --password mysecretpassword --vimtype HostSystem --vimname myesxhost.local --perfcounter disk:usage:average
OK: Counter disk:usage:average on HostSystem:myesxhost.local reported 24365 Kilobytes per second
| 'disk:usage:average'=24365.0;;;;
'monplugin_time'=0.186355s

I have fixed this and will provide the fix via a pull request:

root@localhost /home/zet/git-repos/check_vsphere # ./check_vsphere perf --disable-ssl-verification --sessionfile /tmp/check_vsphere.192.168.0.160.session --host 192.168.0.170 --user monitoring --password mysecretpassword --vimtype HostSystem --vimname myesxhost.local --perfcounter disk:usage:average
OK: Counter disk:usage:average on HostSystem:myesxhost.local reported 24365 Kilobytes per second
| 'disk:usage:average'=24365.0KB;;;;
'monplugin_time'=0.194689s

[datamuc]

Hi,

thank you for the submission. I had already considered that but decided against it. The development guidelines provide a very limited fixed list of supported units of measurement (UOM). The correct unit is "KB/s". Therefore, instead of using the incorrect unit, I preferred to omit the unit entirely.

I will discuss that issue with the team, though.

However, I would definitely accept an option that allows you to overwrite the unit of measurement (UOM) with whatever you prefer.