check_process: make process filter is case insensitive

Author: sni

Changes

@@ -6,6 +6,7 @@ next:
          - change like operator to be case insensitive
          - add new slike operator which is case sensitive
          - add support for str() operator
+         - check_process: make process filter is case insensitive
 
 0.31     Wed Feb 12 18:14:54 CET 2025
          - fix check_files thresholds on total_size

docs/checks/commands/check_process.md

@@ -72,10 +72,10 @@ Naemon Config
 
 ## Check Specific Arguments
 
-| Argument | Description                                                |
-| -------- | ---------------------------------------------------------- |
-| process  | The process to check, set to \* to check all. Default: \*  |
-| timezone | Sets the timezone for time metrics (default is local time) |
+| Argument | Description                                                                  |
+| -------- | ---------------------------------------------------------------------------- |
+| process  | The process to check, set to \* to check all. (Case insensitive) Default: \* |
+| timezone | Sets the timezone for time metrics (default is local time)                   |
 
 ## Attributes
 

pkg/snclient/check_process.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"runtime"
+	"strings"
 
 	"github.com/consol-monitoring/snclient/pkg/convert"
 )
@@ -33,7 +34,7 @@ func (l *CheckProcess) Build() *CheckData {
 			State: CheckExitOK,
 		},
 		args: map[string]CheckArgument{
-			"process":  {value: &l.processes, description: "The process to check, set to * to check all. Default: *", isFilter: true},
+			"process":  {value: &l.processes, description: "The process to check, set to * to check all. (Case insensitive) Default: *", isFilter: true},
 			"timezone": {value: &l.timeZoneStr, description: "Sets the timezone for time metrics (default is local time)"},
 		},
 		conditionAlias:  l.buildConditionAlias(),
@@ -116,6 +117,11 @@ func (l *CheckProcess) buildConditionAlias() map[string]map[string]string {
 func (l *CheckProcess) Check(ctx context.Context, _ *Agent, check *CheckData, _ []Argument) (*CheckResult, error) {
 	check.ExpandThresholdUnit([]string{"k", "m", "g", "p", "e", "ki", "mi", "gi", "pi", "ei"}, "B", []string{"rss", "virtual", "pagefile"})
 
+	// make process arg lowercase
+	for i := range l.processes {
+		l.processes[i] = strings.ToLower(l.processes[i])
+	}
+
 	err := l.fetchProcs(ctx, check)
 	if err != nil {
 		return nil, err

pkg/snclient/check_process_other.go

@@ -55,7 +55,7 @@ func (l *CheckProcess) fetchProcs(ctx context.Context, check *CheckData) error {
 			}
 		}
 
-		if len(l.processes) > 0 && !slices.Contains(l.processes, exe) && !slices.Contains(l.processes, "*") {
+		if len(l.processes) > 0 && !slices.Contains(l.processes, strings.ToLower(exe)) && !slices.Contains(l.processes, "*") {
 			continue
 		}
 

pkg/snclient/check_process_test.go

@@ -5,6 +5,7 @@ package snclient
 import (
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 
 	"github.com/consol-monitoring/snclient/pkg/convert"
@@ -52,5 +53,11 @@ func TestCheckProcess(t *testing.T) {
 	assert.Regexpf(t, `OK - all \d+ processes are ok.`, string(res.BuildPluginOutput()), "output ok")
 	assert.Regexpf(t, `rss'=\d{1,15}B;;;0`, string(res.BuildPluginOutput()), "rss ok")
 
+	// should work case insensitive
+	res = snc.RunCheck("check_process", []string{"process=" + strings.ToUpper(filepath.Base(myExe))})
+	assert.Equalf(t, CheckExitOK, res.State, "state ok")
+	assert.Regexpf(t, `OK - all \d+ processes are ok.`, string(res.BuildPluginOutput()), "output ok")
+	assert.Regexpf(t, `rss'=\d{1,15}B;;;0`, string(res.BuildPluginOutput()), "rss ok")
+
 	StopTestAgent(t, snc)
 }

pkg/snclient/check_process_windows.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"slices"
+	"strings"
 	"time"
 
 	"github.com/consol-monitoring/snclient/pkg/wmi"
@@ -63,7 +64,7 @@ func (l *CheckProcess) fetchProcs(_ context.Context, check *CheckData) error {
 	for i := range processData {
 		proc := processData[i]
 
-		if len(l.processes) > 0 && !slices.Contains(l.processes, proc.Name) && !slices.Contains(l.processes, "*") {
+		if len(l.processes) > 0 && !slices.Contains(l.processes, strings.ToLower(proc.Name)) && !slices.Contains(l.processes, "*") {
 			continue
 		}