fix check_process when empty-state is set to OK

Author: sni

.golangci.yml

@@ -126,6 +126,7 @@ issues:
     - "cyclomatic complexity .* of func .*.matchSingle"
     - "Function 'ParseINI' has too many statements"
     - "Function 'buildListMacros' has too many statements"
+    - "Function 'finalizeOutput' has too many statements"
     - "cognitive complexity .* of func .*ParseINI`"
     - "cognitive complexity .* of func .*ThresholdString"
     - "appendAssign: append result not assigned to the same slice"

Changes

@@ -2,6 +2,7 @@ This file documents the revision history for the SNClient+ agent.
 
 next:
          - add alpine support
+         - fix check_process when empty-state is set to OK
 
 0.31     Wed Feb 12 18:14:54 CET 2025
          - fix check_files thresholds on total_size

pkg/snclient/check_process_test.go

@@ -31,6 +31,11 @@ func TestCheckProcess(t *testing.T) {
 	assert.Equalf(t, "OK - no processes found with this filter. |'count'=0;0;0;0 'rss'=0B;;;0 'virtual'=0B;;;0 'cpu'=0%;;;0",
 		string(res.BuildPluginOutput()), "output matches")
 
+	res = snc.RunCheck("check_process", []string{"process=noneexisting.exe", "empty-state=0"})
+	assert.Equalf(t, CheckExitOK, res.State, "state ok")
+	assert.Equalf(t, "OK - no processes found with this filter. |'count'=0;0;0;0 'rss'=0B;;;0 'virtual'=0B;;;0 'cpu'=0%;;;0",
+		string(res.BuildPluginOutput()), "output matches")
+
 	res = snc.RunCheck("check_process", []string{"process=noneexisting.exe", "crit=count>0", "warn=none"})
 	assert.Equalf(t, CheckExitOK, res.State, "state ok")
 	assert.Regexpf(t, `OK - no processes found with this filter.`, string(res.BuildPluginOutput()), "output ok")

pkg/snclient/checkdata.go

@@ -96,6 +96,7 @@ type CheckData struct {
 	hasArgsFilter          bool // will be true if any arg supplied which has isFilter set
 	emptySyntax            string
 	emptyState             int64
+	emptyStateSet          bool
 	details                map[string]string
 	listData               []map[string]string
 	listCombine            string // join string for detail list
@@ -201,7 +202,8 @@ func (cd *CheckData) finalizeOutput() (*CheckResult, error) {
 		if cd.emptySyntax != "" {
 			cd.result.Output = cd.emptySyntax
 		}
-		if !cd.HasThreshold("count") {
+		if cd.emptyStateSet || !cd.HasThreshold("count") {
+			log.Debugf("exit code set by empty state: %d", cd.emptyState)
 			cd.result.State = cd.emptyState
 		}
 	case cd.showAll:
@@ -609,6 +611,7 @@ func (cd *CheckData) ParseArgs(args []string) (argList []Argument, err error) {
 			cd.emptySyntax = argValue
 		case "empty-state":
 			cd.emptyState = cd.parseStateString(argValue)
+			cd.emptyStateSet = true
 		case "show-all":
 			if argValue == "" {
 				cd.showAll = true