[BB-1013] fix pagination for scope (#33)

MarcusGoldschmidt · aldevv · web-flow · commit 6238f7445c70 · 2025-11-21T16:15:55.000-08:00
* fix pagination for scope

* fix wrong scope id

---------

Co-authored-by: Alejandro Bernal &lt;jbernalxyz@gmail.com&gt;
diff --git a/pkg/connector/roles.go b/pkg/connector/roles.go
@@ -252,6 +252,7 @@ func (o *roleBuilder) Grants(
 			grants = append(grants, nextGrant)
 		}
 
+		bag.Pop()
 		nextToken, err := bag.Marshal()
 		if err != nil {
 			return nil, "", nil, err
diff --git a/pkg/connector/scopes.go b/pkg/connector/scopes.go
@@ -88,5 +88,5 @@ func scopeResource(resourceServer client.ResourceServerScope, server *client.Res
 }
 
 func formatScopeId(resourceServer client.ResourceServerScope, server *client.ResourceServer) string {
-	return fmt.Sprintf("%s/%s", server.Identifier, resourceServer.Value)
+	return fmt.Sprintf("%s:%s", server.Identifier, resourceServer.Value)
 }

Original file line number	Diff line number	Diff line change
`@@ -252,6 +252,7 @@ func (o *roleBuilder) Grants(`
`252`	`252`	`grants = append(grants, nextGrant)`
`253`	`253`	`}`
`254`	`254`
	`255`	`+ bag.Pop()`
`255`	`256`	`nextToken, err := bag.Marshal()`
`256`	`257`	`if err != nil {`
`257`	`258`	`return nil, "", nil, err`
Original file line number	Diff line number	Diff line change
`@@ -88,5 +88,5 @@ func scopeResource(resourceServer client.ResourceServerScope, server *client.Res`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`func formatScopeId(resourceServer client.ResourceServerScope, server *client.ResourceServer) string {`
`91`		`- return fmt.Sprintf("%s/%s", server.Identifier, resourceServer.Value)`
	`91`	`+ return fmt.Sprintf("%s:%s", server.Identifier, resourceServer.Value)`
`92`	`92`	`}`