fix github deprecated calls

Author: aldevv

pkg/connector/api_token.go

@@ -9,7 +9,6 @@ import (
 	"github.com/conductorone/baton-sdk/pkg/pagination"
 	resourceSdk "github.com/conductorone/baton-sdk/pkg/types/resource"
 	"github.com/google/go-github/v69/github"
-	"github.com/shurcooL/githubv4"
 )
 
 func apiTokenResource(ctx context.Context, token *github.PersonalAccessToken) (*v2.Resource, error) {
@@ -49,7 +48,6 @@ func apiTokenResource(ctx context.Context, token *github.PersonalAccessToken) (*
 type apiTokenResourceType struct {
 	resourceType   *v2.ResourceType
 	client         *github.Client
-	graphClient    *githubv4.Client
 	hasSAMLEnabled *bool
 	orgCache       *orgNameCache
 }

pkg/connector/org.go

@@ -314,7 +314,7 @@ func (o *orgResourceType) Grant(ctx context.Context, principal *v2.Resource, en
 	}
 
 	// User is a member but grant is for admin, so make them an admin.
-	_, _, err = o.client.Organizations.EditOrgMembership(ctx, user.GetLogin(), orgName, &github.Membership{Role: github.String(orgRoleAdmin)})
+	_, _, err = o.client.Organizations.EditOrgMembership(ctx, user.GetLogin(), orgName, &github.Membership{Role: github.Ptr(orgRoleAdmin)})
 	if err != nil {
 		return nil, fmt.Errorf("github-connectorv2: failed to make user an admin : %w", err)
 	}
@@ -376,7 +376,7 @@ func (o *orgResourceType) Revoke(ctx context.Context, grant *v2.Grant) (annotati
 		return nil, nil
 	}
 
-	_, _, err = o.client.Organizations.EditOrgMembership(ctx, user.GetLogin(), orgName, &github.Membership{Role: github.String(orgRoleMember)})
+	_, _, err = o.client.Organizations.EditOrgMembership(ctx, user.GetLogin(), orgName, &github.Membership{Role: github.Ptr(orgRoleMember)})
 	if err != nil {
 		return nil, fmt.Errorf("github-connectorv2: failed to revoke org admin from user: %w", err)
 	}

test/mocks/github.go

@@ -391,8 +391,8 @@ func (mgh MockGitHub) getMembers(
 func userToMembership(user *github.User) github.Membership {
 	return github.Membership{
 		User:  user,
-		Role:  github.String("admin"),
-		State: github.String("active"),
+		Role:  github.Ptr("admin"),
+		State: github.Ptr("active"),
 	}
 }