Remove WithRequired field option from accessTokenField

MB Burch · MB Burch · commit 2a207b74b002 · 2025-05-30T14:15:52.000-06:00
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -4,12 +4,12 @@ import (
 	"github.com/conductorone/baton-sdk/pkg/field"
 )
 
+// TODO (mb): Make sure we don't need field.WithRequired(true) for required fields.
 var (
 	accessTokenField = field.StringField(
 		"token",
 		field.WithDisplayName("Personal access token"),
 		field.WithDescription("The GitHub access token used to connect to the GitHub API."),
-		field.WithRequired(true),
 		field.WithIsSecret(true),
 	)
 	orgsField = field.StringSliceField(

Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,12 @@ import (`
`4`	`4`	`"github.com/conductorone/baton-sdk/pkg/field"`
`5`	`5`	`)`
`6`	`6`
	`7`	`+// TODO (mb): Make sure we don't need field.WithRequired(true) for required fields.`
`7`	`8`	`var (`
`8`	`9`	`accessTokenField = field.StringField(`
`9`	`10`	`"token",`
`10`	`11`	`field.WithDisplayName("Personal access token"),`
`11`	`12`	`field.WithDescription("The GitHub access token used to connect to the GitHub API."),`
`12`		`- field.WithRequired(true),`
`13`	`13`	`field.WithIsSecret(true),`
`14`	`14`	`)`
`15`	`15`	`orgsField = field.StringSliceField(`